-
Notifications
You must be signed in to change notification settings - Fork 721
improve memory limits errors observability (add debugging details) #6551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve memory limits errors observability (add debugging details) #6551
Conversation
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
||
for (auto& [outputIndex, sinkInfo] : SinksMap) { | ||
if (auto* sink = GetSink(outputIndex, sinkInfo)) { | ||
if (!sinkInfo.AsyncOutput) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for reviewers: at extreme low limits this check prevents potential segfault
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
improve memory limits errors observability (add debugging details)
Changelog category
Additional information
...