Skip to content

Conversation

gridnevvvit
Copy link
Member

Changelog entry

improve memory limits errors observability (add debugging details)

Changelog category

  • Improvement

Additional information

...

@gridnevvvit gridnevvvit requested review from a team as code owners July 10, 2024 21:45
Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 21:47:01 UTC Pre-commit check for e17cbb5 has started.
2024-07-10 21:50:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 22:18:02 UTC Build successful.
2024-07-10 22:18:16 UTC Tests are running...
🔴 2024-07-11 00:19:53 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11116 10535 0 84 319 178

🟢 2024-07-11 00:20:43 UTC ydbd size 5.2 GiB changed* by +36.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 63653ea merge: e17cbb5 diff diff %
ydbd size 5 604 737 408 Bytes 5 604 774 456 Bytes +36.2 KiB +0.001%
ydbd stripped size 1 206 064 592 Bytes 1 206 071 152 Bytes +6.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation


for (auto& [outputIndex, sinkInfo] : SinksMap) {
if (auto* sink = GetSink(outputIndex, sinkInfo)) {
if (!sinkInfo.AsyncOutput)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reviewers: at extreme low limits this check prevents potential segfault

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 21:48:49 UTC Pre-commit check for e17cbb5 has started.
2024-07-10 21:51:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 22:35:53 UTC Build successful.
2024-07-10 22:36:07 UTC Tests are running...
🟢 2024-07-11 00:21:47 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39635 34399 0 0 5220 16

🟢 2024-07-11 00:22:22 UTC ydbd size 8.1 GiB changed* by +23.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 63653ea merge: e17cbb5 diff diff %
ydbd size 8 713 895 256 Bytes 8 713 919 264 Bytes +23.4 KiB +0.000%
ydbd stripped size 475 278 224 Bytes 475 279 760 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit enabled auto-merge (squash) July 11, 2024 10:27
Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 11:00:59 UTC Pre-commit check for e17cbb5 has started.
2024-07-11 11:03:31 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 11:17:48 UTC Build successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants