Skip to content

get rid of wide fields in wide combiner. Not used in llvm #6536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Jul 10, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner July 10, 2024 16:08
Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 16:16:14 UTC Pre-commit check for d70ae71 has started.
2024-07-10 16:18:46 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 16:25:54 UTC Build successful.

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 16:26:44 UTC Pre-commit check for d70ae71 has started.
2024-07-10 16:29:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 17:08:25 UTC Build successful.
2024-07-10 17:08:41 UTC Tests are running...
🔴 2024-07-10 19:08:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73200 59753 0 3 13428 16

🟢 2024-07-10 19:09:50 UTC ydbd size 8.1 GiB changed* by -8.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b999dc6 merge: d70ae71 diff diff %
ydbd size 8 713 868 136 Bytes 8 713 859 120 Bytes -8.8 KiB -0.000%
ydbd stripped size 475 276 560 Bytes 475 276 368 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 16:29:36 UTC Pre-commit check for d70ae71 has started.
2024-07-10 16:32:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 16:56:11 UTC Build successful.
2024-07-10 16:56:21 UTC Tests are running...
🔴 2024-07-10 18:55:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12149 11556 0 81 332 180

🟡 2024-07-10 18:55:51 UTC ydbd size 5.2 GiB changed* by +931.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 87e2787 merge: d70ae71 diff diff %
ydbd size 5 603 754 232 Bytes 5 604 707 848 Bytes +931.3 KiB +0.017%
ydbd stripped size 1 205 514 424 Bytes 1 206 059 824 Bytes +532.6 KiB +0.045%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 13:31:52 UTC Pre-commit check for 29b51d3 has started.
2024-07-11 13:34:22 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 13:39:19 UTC Build successful.

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 13:32:39 UTC Pre-commit check for 29b51d3 has started.
2024-07-11 13:35:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 13:59:06 UTC Build successful.
2024-07-11 13:59:16 UTC Tests are running...
🔴 2024-07-11 15:40:20 UTC Test run completed, no test results found for commit 2798fe7. Please check test log.
🟢 2024-07-11 15:40:48 UTC ydbd size 5.2 GiB changed* by -6.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 21bdc0e merge: 29b51d3 diff diff %
ydbd size 5 607 929 432 Bytes 5 607 923 072 Bytes -6.2 KiB -0.000%
ydbd stripped size 1 207 237 168 Bytes 1 207 235 888 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-11 15:40:49 UTC Check cancelled

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 13:52:31 UTC Pre-commit check for 29b51d3 has started.
2024-07-11 13:55:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 14:33:32 UTC Build successful.
2024-07-11 14:33:47 UTC Tests are running...
🔴 2024-07-11 15:40:20 UTC Test run completed, no test results found for commit 2798fe7. Please check test log.
🟢 2024-07-11 15:41:01 UTC ydbd size 8.1 GiB changed* by -8.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 50074e8 merge: 29b51d3 diff diff %
ydbd size 8 717 046 936 Bytes 8 717 038 232 Bytes -8.5 KiB -0.000%
ydbd stripped size 475 511 184 Bytes 475 510 992 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-11 15:41:02 UTC Check cancelled

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 15:46:55 UTC Pre-commit check for a9adb69 has started.
2024-07-11 15:49:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 16:13:01 UTC Build successful.
2024-07-11 16:13:18 UTC Tests are running...
🔴 2024-07-11 17:32:33 UTC Test run completed, no test results found for commit f1d16fa. Please check test log.
🟡 2024-07-11 17:33:35 UTC ydbd size 5.2 GiB changed* by +419.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 21bdc0e merge: a9adb69 diff diff %
ydbd size 5 607 929 432 Bytes 5 608 359 248 Bytes +419.7 KiB +0.008%
ydbd stripped size 1 207 237 168 Bytes 1 207 408 624 Bytes +167.4 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-11 17:33:36 UTC Check cancelled

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 16:05:40 UTC Pre-commit check for a9adb69 has started.
2024-07-11 16:08:32 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 16:14:21 UTC Build successful.

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 16:10:45 UTC Pre-commit check for a9adb69 has started.
2024-07-11 16:13:47 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 16:52:39 UTC Build successful.
2024-07-11 16:52:56 UTC Tests are running...
🔴 2024-07-11 17:32:29 UTC Test run completed, no test results found for commit f1d16fa. Please check test log.
🟡 2024-07-11 17:33:10 UTC ydbd size 8.1 GiB changed* by +764.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 21bdc0e merge: a9adb69 diff diff %
ydbd size 8 717 047 464 Bytes 8 717 829 824 Bytes +764.0 KiB +0.009%
ydbd stripped size 475 511 184 Bytes 475 642 320 Bytes +128.1 KiB +0.028%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-11 17:33:12 UTC Check cancelled

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 17:39:35 UTC Pre-commit check for d334437 has started.
2024-07-11 17:42:09 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 18:06:05 UTC Build successful.
2024-07-11 18:06:18 UTC Tests are running...
🔴 2024-07-11 20:06:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12152 11562 0 79 332 179

🟢 2024-07-11 20:07:25 UTC ydbd size 5.2 GiB changed* by -54.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a456848 merge: d334437 diff diff %
ydbd size 5 608 366 960 Bytes 5 608 311 056 Bytes -54.6 KiB -0.001%
ydbd stripped size 1 207 410 352 Bytes 1 207 330 064 Bytes -78.4 KiB -0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 17:39:40 UTC Pre-commit check for d334437 has started.
2024-07-11 17:42:12 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 17:48:16 UTC Build successful.

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 17:39:42 UTC Pre-commit check for d334437 has started.
2024-07-11 17:42:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 18:21:39 UTC Build successful.
2024-07-11 18:21:54 UTC Tests are running...
🔴 2024-07-11 20:27:29 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73206 59728 0 33 13429 16

🟡 2024-07-11 20:28:09 UTC ydbd size 8.1 GiB changed* by +695.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a456848 merge: d334437 diff diff %
ydbd size 8 717 839 304 Bytes 8 718 551 368 Bytes +695.4 KiB +0.008%
ydbd stripped size 475 642 768 Bytes 475 722 128 Bytes +77.5 KiB +0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 09:16:45 UTC Pre-commit check for 78496a8 has started.
2024-07-12 09:20:12 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-12 09:26:43 UTC Build successful.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 09:17:53 UTC Pre-commit check for 78496a8 has started.
2024-07-12 09:20:44 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-12 11:33:26 UTC Build successful.
🔴 2024-07-12 11:37:36 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11867 11274 0 82 334 177

🟢 2024-07-12 11:38:24 UTC ydbd size 5.2 GiB changed* by -5.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: da925c3 merge: 78496a8 diff diff %
ydbd size 5 608 994 920 Bytes 5 608 989 440 Bytes -5.4 KiB -0.000%
ydbd stripped size 1 207 400 432 Bytes 1 207 399 664 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 09:17:58 UTC Pre-commit check for 78496a8 has started.
2024-07-12 09:20:38 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-12 11:27:12 UTC Build successful.
🔴 2024-07-12 11:39:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72914 59433 0 35 13430 16

🟢 2024-07-12 11:40:32 UTC ydbd size 8.1 GiB changed* by -7.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: da925c3 merge: 78496a8 diff diff %
ydbd size 8 719 353 496 Bytes 8 719 345 864 Bytes -7.5 KiB -0.000%
ydbd stripped size 475 749 808 Bytes 475 749 680 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 14, 2024

2024-07-14 12:46:13 UTC Pre-commit check for f09739c has started.
2024-07-14 12:48:59 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-14 14:56:19 UTC Build successful.
🔴 2024-07-14 15:07:47 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72934 59480 0 2 13431 21

🟢 2024-07-14 15:08:34 UTC ydbd size 8.1 GiB changed* by -7.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38a7ef2 merge: f09739c diff diff %
ydbd size 8 691 727 952 Bytes 8 691 720 440 Bytes -7.3 KiB -0.000%
ydbd stripped size 473 720 880 Bytes 473 720 816 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 14, 2024

2024-07-14 12:46:15 UTC Pre-commit check for f09739c has started.
2024-07-14 12:49:00 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-14 12:55:15 UTC Build successful.

Copy link

github-actions bot commented Jul 14, 2024

2024-07-14 12:46:23 UTC Pre-commit check for f09739c has started.
2024-07-14 12:49:14 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-14 14:59:45 UTC Build successful.
🔴 2024-07-14 15:03:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11888 11281 0 91 336 180

🟢 2024-07-14 15:04:08 UTC ydbd size 5.2 GiB changed* by -5.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38a7ef2 merge: f09739c diff diff %
ydbd size 5 574 615 648 Bytes 5 574 610 264 Bytes -5.3 KiB -0.000%
ydbd stripped size 1 201 391 056 Bytes 1 201 390 352 Bytes -704 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 10:31:54 UTC Pre-commit check for 99e0898 has started.
2024-07-15 10:34:46 UTC Build+Tests linux-x86_64-release-clang14 is running...
🔴 2024-07-15 10:38:24 UTC Build failed. see the logs.

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:12:21 UTC Pre-commit check for 22ef9c2 has started.
2024-07-16 12:15:04 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-16 12:22:29 UTC Test run completed, no test results found for commit 5d2dd8b.
2024-07-16 12:23:46 UTC Check cancelled

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:28:36 UTC Pre-commit check for e508dd8 has started.
2024-07-16 12:31:22 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-16 12:36:30 UTC Build successful.

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:31:35 UTC Pre-commit check for e508dd8 has started.
2024-07-16 12:34:50 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-16 13:31:20 UTC Test run completed, no test results found for commit 0c2a6dc.
2024-07-16 13:31:28 UTC Check cancelled

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:49:52 UTC Pre-commit check for e508dd8 has started.
2024-07-16 12:53:13 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-16 13:31:19 UTC Test run completed, no test results found for commit 0c2a6dc.
2024-07-16 13:31:28 UTC Check cancelled

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 13:35:15 UTC Pre-commit check for c1a005a has started.
2024-07-16 13:37:59 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-16 13:44:19 UTC Build successful.

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 13:35:21 UTC Pre-commit check for c1a005a has started.
2024-07-16 13:38:03 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-16 15:46:12 UTC Build successful.
🔴 2024-07-16 15:50:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11929 11346 0 80 327 176

🟢 2024-07-16 15:50:58 UTC ydbd size 5.2 GiB changed* by +26.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a037131 merge: c1a005a diff diff %
ydbd size 5 549 082 616 Bytes 5 549 109 800 Bytes +26.5 KiB +0.000%
ydbd stripped size 1 194 978 736 Bytes 1 194 987 920 Bytes +9.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 13:35:33 UTC Pre-commit check for c1a005a has started.
2024-07-16 13:38:16 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-16 15:54:56 UTC Build successful.
🔴 2024-07-16 16:07:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72977 59520 0 5 13431 21

🟢 2024-07-16 16:08:17 UTC ydbd size 8.0 GiB changed* by +33.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a037131 merge: c1a005a diff diff %
ydbd size 8 642 916 472 Bytes 8 642 950 656 Bytes +33.4 KiB +0.000%
ydbd stripped size 470 538 624 Bytes 470 540 992 Bytes +2.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -1237,6 +1250,7 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TWideLastCombinerWra
, AllowSpilling(allowSpilling)
{}

// MARK: DoCAlculate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this mark?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, forgot to remove it 😢

@lll-phill-lll lll-phill-lll merged commit fda767c into ydb-platform:main Jul 17, 2024
8 of 12 checks passed
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 10, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 11, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants