Skip to content

Extend DisabledOnSchemeShard FF for column tables on dedicated bases #6498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Jul 10, 2024

YDB-2573

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 04:34:50 UTC Pre-commit check for cf636b4 has started.
2024-07-10 04:37:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 04:42:19 UTC Build successful.

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 04:35:01 UTC Pre-commit check for cf636b4 has started.
2024-07-10 04:37:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 05:15:17 UTC Build successful.
2024-07-10 05:15:38 UTC Tests are running...
🔴 2024-07-10 06:37:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14087 12719 0 40 1307 21

🟢 2024-07-10 06:38:19 UTC ydbd size 8.1 GiB changed* by -12.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ca2f330 merge: cf636b4 diff diff %
ydbd size 8 721 394 048 Bytes 8 721 381 744 Bytes -12.0 KiB -0.000%
ydbd stripped size 475 016 608 Bytes 475 015 904 Bytes -704 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 04:35:10 UTC Pre-commit check for cf636b4 has started.
2024-07-10 04:37:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 05:00:56 UTC Build successful.
2024-07-10 05:01:14 UTC Tests are running...
🔴 2024-07-10 07:04:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9808 9192 0 118 323 175

🟢 2024-07-10 07:05:04 UTC ydbd size 5.2 GiB changed* by -10.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ca2f330 merge: cf636b4 diff diff %
ydbd size 5 611 351 408 Bytes 5 611 340 848 Bytes -10.3 KiB -0.000%
ydbd stripped size 1 206 692 792 Bytes 1 206 691 256 Bytes -1.5 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny force-pushed the disable_olap_for_all branch from 9ada28d to dd507f4 Compare July 15, 2024 02:51
Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 02:54:19 UTC Pre-commit check for 684fea5 has started.
2024-07-15 02:57:05 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-15 04:36:44 UTC Build successful.
🔴 2024-07-15 04:41:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13867 12496 0 41 1308 22

🟢 2024-07-15 04:42:29 UTC ydbd size 8.1 GiB changed* by -5.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 18604c2 merge: 684fea5 diff diff %
ydbd size 8 692 259 240 Bytes 8 692 254 152 Bytes -5.0 KiB -0.000%
ydbd stripped size 473 735 024 Bytes 473 734 768 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 02:54:29 UTC Pre-commit check for 684fea5 has started.
2024-07-15 02:57:08 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-15 05:00:24 UTC Build successful.
🔴 2024-07-15 05:02:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9594 8982 0 114 324 174

🟢 2024-07-15 05:02:49 UTC ydbd size 5.2 GiB changed* by -2.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 18604c2 merge: 684fea5 diff diff %
ydbd size 5 574 744 840 Bytes 5 574 742 440 Bytes -2.3 KiB -0.000%
ydbd stripped size 1 201 422 608 Bytes 1 201 422 288 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 02:54:32 UTC Pre-commit check for 684fea5 has started.
2024-07-15 02:57:17 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-15 03:06:09 UTC Build successful.

Copy link

github-actions bot commented Jul 17, 2024

2024-07-17 17:02:18 UTC Pre-commit check for 1dcc97f has started.
2024-07-17 17:05:29 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-17 19:04:37 UTC Build successful.
🔴 2024-07-17 19:06:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9647 9067 0 83 320 177

🟢 2024-07-17 19:06:57 UTC ydbd size 5.2 GiB changed* by -2.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 90eea8d merge: 1dcc97f diff diff %
ydbd size 5 546 465 168 Bytes 5 546 462 720 Bytes -2.4 KiB -0.000%
ydbd stripped size 1 195 221 168 Bytes 1 195 220 784 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 17, 2024

2024-07-17 17:04:46 UTC Pre-commit check for 1dcc97f has started.
2024-07-17 17:07:27 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-17 17:15:31 UTC Build successful.

Copy link

github-actions bot commented Jul 17, 2024

2024-07-17 17:04:51 UTC Pre-commit check for 1dcc97f has started.
2024-07-17 17:07:36 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-17 18:37:30 UTC Build successful.
🔴 2024-07-17 18:39:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13933 12601 0 6 1310 16

🟢 2024-07-17 18:40:06 UTC ydbd size 8.0 GiB changed* by -4.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 90eea8d merge: 1dcc97f diff diff %
ydbd size 8 641 941 496 Bytes 8 641 936 448 Bytes -4.9 KiB -0.000%
ydbd stripped size 470 498 400 Bytes 470 498 080 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny force-pushed the disable_olap_for_all branch from 435c735 to f9bab12 Compare July 18, 2024 15:30
Copy link

github-actions bot commented Jul 18, 2024

2024-07-18 15:31:51 UTC Pre-commit check for 150f61c has started.
2024-07-18 15:35:00 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-18 17:02:50 UTC Build successful.
🔴 2024-07-18 17:04:42 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13931 12602 0 8 1307 14

🟢 2024-07-18 17:05:25 UTC ydbd size 8.0 GiB changed* by -4.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ebee36a merge: 150f61c diff diff %
ydbd size 8 642 786 480 Bytes 8 642 781 520 Bytes -4.8 KiB -0.000%
ydbd stripped size 470 543 136 Bytes 470 542 880 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 18, 2024

2024-07-18 15:33:57 UTC Pre-commit check for 150f61c has started.
2024-07-18 15:36:37 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-18 15:44:23 UTC Build successful.

Copy link

github-actions bot commented Jul 18, 2024

2024-07-18 15:34:46 UTC Pre-commit check for 150f61c has started.
2024-07-18 15:37:28 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-18 17:49:38 UTC Build successful.
🔴 2024-07-18 17:53:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9659 9067 0 91 330 171

🟢 2024-07-18 17:53:59 UTC ydbd size 5.2 GiB changed* by -2.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ebee36a merge: 150f61c diff diff %
ydbd size 5 547 148 464 Bytes 5 547 146 000 Bytes -2.4 KiB -0.000%
ydbd stripped size 1 195 359 792 Bytes 1 195 359 408 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny force-pushed the disable_olap_for_all branch from f9bab12 to c1c041a Compare July 20, 2024 04:41
Copy link

github-actions bot commented Jul 20, 2024

2024-07-20 04:45:28 UTC Pre-commit check for 3dae885 has started.
2024-07-20 04:48:17 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-20 04:56:58 UTC Build successful.

Copy link

github-actions bot commented Jul 20, 2024

2024-07-20 04:46:09 UTC Pre-commit check for 3dae885 has started.
2024-07-20 04:49:08 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-20 07:05:56 UTC Build successful.
🔴 2024-07-20 07:09:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9681 9077 0 103 328 173

🟢 2024-07-20 07:11:02 UTC ydbd size 5.2 GiB changed* by -2.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8c7a652 merge: 3dae885 diff diff %
ydbd size 5 555 469 520 Bytes 5 555 467 056 Bytes -2.4 KiB -0.000%
ydbd stripped size 1 196 913 104 Bytes 1 196 912 720 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 20, 2024

2024-07-20 04:47:44 UTC Pre-commit check for 3dae885 has started.
2024-07-20 04:50:27 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-20 06:24:41 UTC Build successful.
🔴 2024-07-20 06:26:27 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13957 12623 0 7 1313 14

🟢 2024-07-20 06:27:12 UTC ydbd size 8.1 GiB changed* by -4.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8c7a652 merge: 3dae885 diff diff %
ydbd size 8 656 004 720 Bytes 8 655 999 752 Bytes -4.9 KiB -0.000%
ydbd stripped size 471 104 736 Bytes 471 104 480 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Jul 21, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 21, 2024
Copy link

github-actions bot commented Jul 21, 2024

2024-07-21 05:10:00 UTC Pre-commit check for 8e40473 has started.
2024-07-21 05:12:45 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-21 05:21:19 UTC Build successful.

Copy link

github-actions bot commented Jul 21, 2024

2024-07-21 05:10:02 UTC Pre-commit check for 8e40473 has started.
2024-07-21 05:12:45 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-21 06:43:23 UTC Build successful.
🔴 2024-07-21 06:45:07 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13957 12628 0 6 1312 11

🟡 2024-07-21 06:45:50 UTC ydbd size 8.1 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1c15550 merge: 8e40473 diff diff %
ydbd size 8 656 109 112 Bytes 8 657 161 104 Bytes +1.0 MiB +0.012%
ydbd stripped size 471 115 872 Bytes 471 140 256 Bytes +23.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 21, 2024

2024-07-21 05:10:02 UTC Pre-commit check for 8e40473 has started.
2024-07-21 05:12:45 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-21 07:21:08 UTC Build successful.
🔴 2024-07-21 07:23:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9666 9061 0 95 333 177

🟢 2024-07-21 07:24:40 UTC ydbd size 5.2 GiB changed* by -2.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5e95651 merge: 8e40473 diff diff %
ydbd size 5 556 133 632 Bytes 5 556 131 168 Bytes -2.4 KiB -0.000%
ydbd stripped size 1 197 007 984 Bytes 1 197 007 600 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny force-pushed the disable_olap_for_all branch from c1c041a to d2869ad Compare July 22, 2024 04:20
Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 04:24:18 UTC Pre-commit check for 0a3ed0f has started.
2024-07-22 04:27:07 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-22 04:32:47 UTC Build successful.

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 04:24:23 UTC Pre-commit check for 0a3ed0f has started.
2024-07-22 04:27:07 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-22 06:33:07 UTC Build successful.
🔴 2024-07-22 06:36:19 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9678 9094 0 87 327 170

🟢 2024-07-22 06:37:16 UTC ydbd size 5.2 GiB changed* by -1.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5e95651 merge: 0a3ed0f diff diff %
ydbd size 5 556 133 632 Bytes 5 556 131 776 Bytes -1.8 KiB -0.000%
ydbd stripped size 1 197 007 984 Bytes 1 197 007 600 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2024

2024-07-22 04:26:51 UTC Pre-commit check for 0a3ed0f has started.
2024-07-22 04:29:41 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-22 06:02:13 UTC Build successful.
🔴 2024-07-22 06:03:16 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13958 12621 0 6 1316 15

🟡 2024-07-22 06:04:05 UTC ydbd size 8.1 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1c15550 merge: 0a3ed0f diff diff %
ydbd size 8 656 109 112 Bytes 8 657 161 480 Bytes +1.0 MiB +0.012%
ydbd stripped size 471 115 872 Bytes 471 140 256 Bytes +23.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

"OLAP schema operations are not supported");
return result;
}
if (AppData()->ColumnShardConfig.GetDisabledOnSchemeShard() && context.SS->OlapStores.empty()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо бы проверять одновременно и olap-stores, и column-tables?
То же самое в create_table.cpp

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это ослабит запрет. Мы же хотим запретить как можно больше, если клиент ещё не начал этим пользоваться

@zverevgeny zverevgeny marked this pull request as ready for review July 23, 2024 05:14
@zverevgeny zverevgeny merged commit 2ca7153 into ydb-platform:main Jul 23, 2024
9 of 13 checks passed
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants