Skip to content

Add created_by to Operations API #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Jul 9, 2024

Changelog entry

Add UserSID (Security ID) who created long-running operation (export, import).

Changelog category

  • New feature

Additional information

$ ydb export s3 --user root
┌───────────────────────────────────────────┬───────┬─────────┬───────────┬───────────┬────────┐
│ id                                        │ ready │ status  │ progress  │ endpoint  │ bucket │
├───────────────────────────────────────────┼───────┼─────────┼───────────┼───────────┼────────┤
│ ydb://export/6?id=844424953136969&kind=s3 │ false │ SUCCESS │ Preparing │ localhost │ 1      │
├╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴┤
│ StorageClass: NOT_SET                                                                        │
│ Items:                                                                                       │
│   - source: /Root/serverless/stock                                                           │
│     destination: 1                                                                           │
│ Description:                                                                                 │
│ Number of retries: 10                                                                        │
│ Created by: root                                                                             │
│ Create time: 2024-07-10T17:59:13Z                                                            │
└──────────────────────────────────────────────────────────────────────────────────────────────┘

$ ydb export s3
┌───────────────────────────────────────────┬───────┬─────────┬───────────┬───────────┬────────┐
│ id                                        │ ready │ status  │ progress  │ endpoint  │ bucket │
├───────────────────────────────────────────┼───────┼─────────┼───────────┼───────────┼────────┤
│ ydb://export/6?id=562949976271314&kind=s3 │ false │ SUCCESS │ Preparing │ localhost │ 1      │
├╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴╴╴╴┴╴╴╴╴╴╴╴╴┤
│ StorageClass: NOT_SET                                                                        │
│ Items:                                                                                       │
│   - source: /Root/serverless/stock                                                           │
│     destination: 1                                                                           │
│ Description:                                                                                 │
│ Number of retries: 10                                                                        │
│ Create time: 2024-07-09T12:05:51Z                                                            │
└──────────────────────────────────────────────────────────────────────────────────────────────┘

@pixcc pixcc requested a review from CyberROFL July 9, 2024 10:32
@pixcc pixcc linked an issue Jul 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 10:44:57 UTC Pre-commit check for 42fe4c7 has started.
2024-07-09 10:48:01 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 11:29:07 UTC Build successful.

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 10:59:36 UTC Pre-commit check for 42fe4c7 has started.
2024-07-09 11:03:26 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 11:58:03 UTC Build successful.
2024-07-09 11:58:15 UTC Tests are running...
🔴 2024-07-09 14:04:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15682 15060 0 99 343 180

🟢 2024-07-09 14:04:56 UTC ydbd size 5.2 GiB changed* by -27.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 42fe4c7 diff diff %
ydbd size 5 610 940 168 Bytes 5 610 912 424 Bytes -27.1 KiB -0.000%
ydbd stripped size 1 206 606 616 Bytes 1 206 610 776 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 12:33:21 UTC Pre-commit check for 42fe4c7 has started.
2024-07-09 12:37:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 13:43:02 UTC Build successful.
2024-07-09 13:43:13 UTC Tests are running...
🔴 2024-07-09 15:42:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76753 63301 0 4 13430 18

🟢 2024-07-09 15:42:40 UTC ydbd size 8.1 GiB changed* by -166.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 42fe4c7 diff diff %
ydbd size 8 720 569 560 Bytes 8 720 398 824 Bytes -166.7 KiB -0.002%
ydbd stripped size 474 992 800 Bytes 474 988 352 Bytes -4.3 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL previously approved these changes Jul 9, 2024
@pixcc pixcc requested a review from spuchin July 9, 2024 13:02
@pixcc pixcc changed the title Add user to Operations API Add created_by to Operations API Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 18:01:19 UTC Pre-commit check for 2238bdf has started.
2024-07-10 18:02:15 UTC Check cancelled

@pixcc pixcc force-pushed the export-import-user-sid branch from ce6fe1c to 5964bbb Compare July 10, 2024 18:01
Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 18:03:53 UTC Pre-commit check for d7698c9 has started.
2024-07-10 18:06:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 19:11:23 UTC Build successful.
2024-07-10 19:11:40 UTC Tests are running...
🔴 2024-07-10 21:17:41 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76674 63230 0 1 13428 15

🟢 2024-07-10 21:18:20 UTC ydbd size 8.1 GiB changed* by +49.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 11ed7b0 merge: d7698c9 diff diff %
ydbd size 8 713 866 832 Bytes 8 713 917 816 Bytes +49.8 KiB +0.001%
ydbd stripped size 475 276 240 Bytes 475 278 448 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 18:03:57 UTC Pre-commit check for d7698c9 has started.
2024-07-10 18:07:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 18:52:39 UTC Build successful.

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 18:04:00 UTC Pre-commit check for d7698c9 has started.
2024-07-10 18:07:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 18:58:20 UTC Build successful.
2024-07-10 18:58:33 UTC Tests are running...
🔴 2024-07-10 21:03:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15597 15008 0 79 331 179

🟢 2024-07-10 21:04:29 UTC ydbd size 5.2 GiB changed* by +64.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 11ed7b0 merge: d7698c9 diff diff %
ydbd size 5 604 712 688 Bytes 5 604 778 176 Bytes +64.0 KiB +0.001%
ydbd stripped size 1 206 060 272 Bytes 1 206 070 128 Bytes +9.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL previously approved these changes Jul 10, 2024
Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 14:58:18 UTC Pre-commit check for adb603c has started.
2024-07-12 15:01:33 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-12 17:41:44 UTC Build successful.
🔴 2024-07-12 17:53:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76375 62922 0 4 13430 19

🟡 2024-07-12 17:54:11 UTC ydbd size 8.1 GiB changed* by +615.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f74adc0 merge: adb603c diff diff %
ydbd size 8 718 795 112 Bytes 8 719 425 000 Bytes +615.1 KiB +0.007%
ydbd stripped size 475 668 336 Bytes 475 694 032 Bytes +25.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 15:04:50 UTC Pre-commit check for adb603c has started.
2024-07-12 15:08:30 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-12 15:51:19 UTC Build successful.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 15:14:47 UTC Pre-commit check for adb603c has started.
2024-07-12 15:18:31 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-12 17:55:45 UTC Build successful.
🔴 2024-07-12 17:58:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15305 14706 0 86 334 179

🟡 2024-07-12 17:59:10 UTC ydbd size 5.2 GiB changed* by +691.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d0aff76 merge: adb603c diff diff %
ydbd size 5 608 995 032 Bytes 5 609 702 968 Bytes +691.3 KiB +0.013%
ydbd stripped size 1 207 400 496 Bytes 1 207 497 008 Bytes +94.2 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc merged commit 5a2b13b into ydb-platform:main Jul 15, 2024
8 of 12 checks passed
marsaly79 pushed a commit to marsaly79/ydb that referenced this pull request Jul 15, 2024
pixcc added a commit to pixcc/ydb that referenced this pull request Sep 4, 2024
pixcc added a commit to pixcc/ydb that referenced this pull request Sep 4, 2024
pixcc added a commit to pixcc/ydb that referenced this pull request Sep 4, 2024
pixcc added a commit to pixcc/ydb that referenced this pull request Sep 4, 2024
pixcc added a commit to pixcc/ydb that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UserSID to export/import API
3 participants