Skip to content

always enable & allow spilling in channels #6462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

gridnevvvit
Copy link
Member

Changelog entry

change default value to enable spilling

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 10:24:32 UTC Pre-commit check for 146ef9c has started.
2024-07-09 10:27:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 11:01:52 UTC Build successful.

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 10:46:22 UTC Pre-commit check for 146ef9c has started.
2024-07-09 10:49:41 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 11:30:06 UTC Build successful.
2024-07-09 11:30:19 UTC Tests are running...
🔴 2024-07-09 13:28:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11235 10647 0 88 324 176

🟢 2024-07-09 13:29:07 UTC ydbd size 5.2 GiB changed* by -91.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 146ef9c diff diff %
ydbd size 5 610 940 168 Bytes 5 610 846 848 Bytes -91.1 KiB -0.002%
ydbd stripped size 1 206 606 616 Bytes 1 206 600 856 Bytes -5.6 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 12:08:15 UTC Pre-commit check for 146ef9c has started.
2024-07-09 12:11:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 13:07:07 UTC Build successful.
2024-07-09 13:07:19 UTC Tests are running...
🔴 2024-07-09 14:47:47 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39763 34517 0 7 5220 19

🟢 2024-07-09 14:48:29 UTC ydbd size 8.1 GiB changed* by -215.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 146ef9c diff diff %
ydbd size 8 720 569 560 Bytes 8 720 348 592 Bytes -215.8 KiB -0.003%
ydbd stripped size 474 992 800 Bytes 474 986 208 Bytes -6.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit force-pushed the always-enable-spilling branch from 8c8d6cf to f04b89c Compare July 11, 2024 05:49
Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 05:52:11 UTC Pre-commit check for f6ded76 has started.
2024-07-11 05:54:54 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 06:26:01 UTC Build successful.

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 05:52:22 UTC Pre-commit check for f6ded76 has started.
2024-07-11 05:55:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 06:37:22 UTC Build successful.
2024-07-11 06:37:36 UTC Tests are running...
🔴 2024-07-11 08:41:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11215 10625 0 85 327 178

🟢 2024-07-11 08:42:37 UTC ydbd size 5.2 GiB changed* by -128 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 63653ea merge: f6ded76 diff diff %
ydbd size 5 604 737 408 Bytes 5 604 737 280 Bytes -128 Bytes -0.000%
ydbd stripped size 1 206 064 592 Bytes 1 206 064 528 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 05:53:07 UTC Pre-commit check for f6ded76 has started.
2024-07-11 05:55:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 06:55:05 UTC Build successful.
2024-07-11 06:55:18 UTC Tests are running...
🔴 2024-07-11 08:42:49 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39747 34500 0 3 5219 25

🟢 2024-07-11 08:43:33 UTC ydbd size 8.1 GiB changed* by +512 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 63653ea merge: f6ded76 diff diff %
ydbd size 8 713 895 256 Bytes 8 713 895 768 Bytes +512 Bytes +0.000%
ydbd stripped size 475 278 224 Bytes 475 278 224 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit force-pushed the always-enable-spilling branch from f04b89c to 56c9d09 Compare July 11, 2024 09:47
Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 09:50:55 UTC Pre-commit check for e474364 has started.
2024-07-11 09:53:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 10:13:45 UTC Build successful.

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 09:51:14 UTC Pre-commit check for e474364 has started.
2024-07-11 09:54:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 10:44:26 UTC Build successful.
2024-07-11 10:44:43 UTC Tests are running...
🟢 2024-07-11 12:33:54 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39747 34502 0 0 5221 24

🟢 2024-07-11 12:34:41 UTC ydbd size 8.1 GiB changed* by +504 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 526f29d merge: e474364 diff diff %
ydbd size 8 713 870 144 Bytes 8 713 870 648 Bytes +504 Bytes +0.000%
ydbd stripped size 475 277 328 Bytes 475 277 328 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 09:51:13 UTC Pre-commit check for e474364 has started.
2024-07-11 09:54:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 10:24:43 UTC Build successful.
2024-07-11 10:24:57 UTC Tests are running...
🔴 2024-07-11 12:30:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11215 10635 0 80 321 179

🟢 2024-07-11 12:30:56 UTC ydbd size 5.2 GiB changed* by -144 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 526f29d merge: e474364 diff diff %
ydbd size 5 604 720 408 Bytes 5 604 720 264 Bytes -144 Bytes -0.000%
ydbd stripped size 1 206 063 696 Bytes 1 206 063 632 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 21bdc0e into ydb-platform:main Jul 11, 2024
10 of 12 checks passed
@gridnevvvit gridnevvvit deleted the always-enable-spilling branch July 11, 2024 16:52
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 6, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 6, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 6, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 10, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 11, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants