24-3: Fix bugs in coordinator state migration

[snaury]

Changelog entry

Fix bugs in coordinator state migration

Changelog category

• Bugfix

Additional information

It was discovered that coordinator state migration had several bugs that could ultimately allow coordinator to plan additional transactions to the previously planned step, violating invariants.

Fixes #6220.
Merges #6401.

[github-actions]

⚪ 2024-07-09 10:05:50 UTC Pre-commit check for f5ed0a3 has started.
⚪ 2024-07-09 10:08:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 10:23:10 UTC Build successful.

[github-actions]

⚪ 2024-07-09 10:09:04 UTC Pre-commit check for f5ed0a3 has started.
⚪ 2024-07-09 10:12:15 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 10:38:58 UTC Build successful.
⚪ 2024-07-09 10:39:09 UTC Tests are running...
🔴 2024-07-09 12:36:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
10076	9497	0	90	316	173

🟢 2024-07-09 12:37:09 UTC ydbd size 5.2 GiB changed* by +9.1 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: 44a1cd0	merge: f5ed0a3	diff	diff %
ydbd size	5 615 664 240 Bytes	5 615 673 560 Bytes	+9.1 KiB	+0.000%
ydbd stripped size	1 211 071 912 Bytes	1 211 074 728 Bytes	+2.8 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2024-07-09 10:39:59 UTC Pre-commit check for f5ed0a3 has started.
⚪ 2024-07-09 10:42:32 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 11:23:48 UTC Build successful.
⚪ 2024-07-09 11:24:09 UTC Tests are running...
🔴 2024-07-09 12:55:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
14430	13089	0	12	1308	21

🟢 2024-07-09 12:56:31 UTC ydbd size 8.1 GiB changed* by +8.6 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: 44a1cd0	merge: f5ed0a3	diff	diff %
ydbd size	8 725 589 248 Bytes	8 725 598 032 Bytes	+8.6 KiB	+0.000%
ydbd stripped size	477 140 648 Bytes	477 141 992 Bytes	+1.3 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}