better error handling in spilling actors #6454

lll-phill-lll · 2024-07-09T08:52:54Z

Changelog entry

Previously, errors from spilling caused a deadlock. Error handling has now been added

Changelog category

Bugfix

Additional information

...

github-actions · 2024-07-09T09:05:22Z

⚪ 2024-07-09 09:05:22 UTC Pre-commit check for 91b6875 has started.
⚫ 2024-07-09 09:06:23 UTC Check cancelled

github-actions · 2024-07-09T09:22:50Z

⚪ 2024-07-09 09:22:49 UTC Pre-commit check for 3d94e24 has started.
⚪ 2024-07-09 09:25:50 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 09:31:53 UTC Build successful.

github-actions · 2024-07-09T09:33:24Z

⚪ 2024-07-09 09:33:24 UTC Pre-commit check for 3d94e24 has started.
⚪ 2024-07-09 09:36:26 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 09:59:53 UTC Build successful.
⚪ 2024-07-09 10:00:03 UTC Tests are running...
🔴 2024-07-09 11:56:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9914	9241	0	142	349	182

🟢 2024-07-09 11:56:48 UTC ydbd size 5.2 GiB changed* by -132.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `0fa3052`	merge: `3d94e24`	diff	diff %
ydbd size	5 610 940 168 Bytes	5 610 804 304 Bytes	-132.7 KiB	-0.002%
ydbd stripped size	1 206 606 616 Bytes	1 206 595 640 Bytes	-10.7 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-09T09:41:47Z

⚪ 2024-07-09 09:41:47 UTC Pre-commit check for 3d94e24 has started.
⚪ 2024-07-09 09:44:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 10:22:59 UTC Build successful.
⚪ 2024-07-09 10:23:09 UTC Tests are running...
🔴 2024-07-09 12:06:20 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38435	33055	0	70	5258	52

🟢 2024-07-09 12:07:05 UTC ydbd size 8.1 GiB changed* by -245.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `0fa3052`	merge: `3d94e24`	diff	diff %
ydbd size	8 720 569 560 Bytes	8 720 318 000 Bytes	-245.7 KiB	-0.003%
ydbd stripped size	474 992 800 Bytes	474 983 840 Bytes	-8.8 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-10T09:28:16Z

⚪ 2024-07-10 09:28:16 UTC Pre-commit check for cbb1602 has started.
⚪ 2024-07-10 09:30:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 09:35:04 UTC Build successful.

github-actions · 2024-07-10T09:36:28Z

⚪ 2024-07-10 09:36:28 UTC Pre-commit check for cbb1602 has started.
⚪ 2024-07-10 09:39:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 10:02:12 UTC Build successful.
⚪ 2024-07-10 10:02:27 UTC Tests are running...
🔴 2024-07-10 12:03:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9912	9239	0	142	346	185

🟢 2024-07-10 12:04:05 UTC ydbd size 5.2 GiB changed* by -34.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `483e9ee`	merge: `cbb1602`	diff	diff %
ydbd size	5 611 370 560 Bytes	5 611 335 408 Bytes	-34.3 KiB	-0.001%
ydbd stripped size	1 206 696 760 Bytes	1 206 693 816 Bytes	-2.9 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-10T09:36:56Z

⚪ 2024-07-10 09:36:56 UTC Pre-commit check for cbb1602 has started.
⚪ 2024-07-10 09:40:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 10:18:01 UTC Build successful.
⚪ 2024-07-10 10:18:14 UTC Tests are running...
🔴 2024-07-10 12:17:17 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38435	33057	0	68	5256	54

🟢 2024-07-10 12:18:09 UTC ydbd size 8.1 GiB changed* by -20.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `483e9ee`	merge: `cbb1602`	diff	diff %
ydbd size	8 721 407 872 Bytes	8 721 386 624 Bytes	-20.8 KiB	-0.000%
ydbd stripped size	475 018 016 Bytes	475 016 672 Bytes	-1.3 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

This reverts commit 96f0511.

This reverts commit f193fd8.

github-actions · 2024-07-11T13:33:27Z

⚪ 2024-07-11 13:33:27 UTC Pre-commit check for 888f31d has started.
⚫ 2024-07-11 13:35:19 UTC Check cancelled

This reverts commit 8574af6.

github-actions · 2024-07-11T13:47:11Z

⚪ 2024-07-11 13:47:11 UTC Pre-commit check for 96356d0 has started.
⚪ 2024-07-11 13:49:40 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 13:54:15 UTC Build successful.

github-actions · 2024-07-11T14:02:31Z

⚪ 2024-07-11 17:25:04 UTC Pre-commit check for 96356d0 has started.
⚪ 2024-07-11 17:28:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 17:50:57 UTC Build successful.
⚪ 2024-07-11 17:51:15 UTC Tests are running...
🔴 2024-07-11 19:54:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9899	9315	0	79	325	180

🟢 2024-07-11 19:55:02 UTC ydbd size 5.2 GiB changed* by -34.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `21bdc0e`	merge: `96356d0`	diff	diff %
ydbd size	5 607 929 432 Bytes	5 607 894 344 Bytes	-34.3 KiB	-0.001%
ydbd stripped size	1 207 237 168 Bytes	1 207 234 288 Bytes	-2.8 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-11T14:18:31Z

⚪ 2024-07-11 17:23:39 UTC Pre-commit check for 96356d0 has started.
⚪ 2024-07-11 17:26:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 18:05:50 UTC Build successful.
⚪ 2024-07-11 18:06:03 UTC Tests are running...
🔴 2024-07-11 19:48:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38414	33172	0	2	5220	20

🟢 2024-07-11 19:48:47 UTC ydbd size 8.1 GiB changed* by -20.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `21bdc0e`	merge: `96356d0`	diff	diff %
ydbd size	8 717 047 464 Bytes	8 717 026 272 Bytes	-20.7 KiB	-0.000%
ydbd stripped size	475 511 184 Bytes	475 509 904 Bytes	-1.2 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

lll-phill-lll requested review from a team as code owners July 9, 2024 08:52

github-actions bot added the bugfix label Jul 9, 2024

lll-phill-lll added the not-for-changelog label Jul 9, 2024

lll-phill-lll requested a review from Darych July 9, 2024 09:11

Darych previously approved these changes Jul 9, 2024

View reviewed changes

lll-phill-lll force-pushed the catch-undelivered-events-and-fail-is-spilling-not-enabled branch from b5b70a2 to f193fd8 Compare July 10, 2024 09:24

lll-phill-lll added 8 commits July 11, 2024 16:30

better error handling in spilling actors

c752e3c

fixup

33518da

added same check to channel spilling

877eb72

fixup

0e98a5a

disable debug spilling

71877f8

added error callback

fcb602c

Revert "added error callback"

0a1eb51

This reverts commit 96f0511.

Revert "Revert "added error callback""

8574af6

This reverts commit f193fd8.

lll-phill-lll dismissed Darych’s stale review via 8574af6 July 11, 2024 13:30

lll-phill-lll force-pushed the catch-undelivered-events-and-fail-is-spilling-not-enabled branch from f193fd8 to 8574af6 Compare July 11, 2024 13:30

Revert "Revert "Revert "added error callback"""

772f0ba

This reverts commit 8574af6.

Darych approved these changes Jul 12, 2024

View reviewed changes

lll-phill-lll merged commit da925c3 into ydb-platform:main Jul 12, 2024
8 of 12 checks passed

This was referenced Jul 12, 2024

YQ-3345 fixed WM counters and unit test #6643

Merged

YQ-3152 fix error failed to execute callable ResWrite! #6752

Merged

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 6, 2024

better error handling in spilling actors (ydb-platform#6454)

0e755a6

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024

better error handling in spilling actors (ydb-platform#6454)

4bab205

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 10, 2024

better error handling in spilling actors (ydb-platform#6454)

d32f8a9

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 11, 2024

better error handling in spilling actors (ydb-platform#6454)

81320b2

lll-phill-lll added a commit that referenced this pull request Sep 12, 2024

better error handling in spilling actors (#6454)

b459a7f

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024

better error handling in spilling actors (ydb-platform#6454)

fa489ce

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024

better error handling in spilling actors (ydb-platform#6454)

78f83ce

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024

better error handling in spilling actors (ydb-platform#6454)

87363b1

lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024

better error handling in spilling actors (ydb-platform#6454)

5359270

lll-phill-lll mentioned this pull request Sep 18, 2024

Stable 24 3 8 analytics #9022

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

better error handling in spilling actors #6454

better error handling in spilling actors #6454

lll-phill-lll commented Jul 9, 2024

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

better error handling in spilling actors #6454

better error handling in spilling actors #6454

Conversation

lll-phill-lll commented Jul 9, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 10, 2024 • edited Loading

github-actions bot commented Jul 10, 2024 • edited Loading

github-actions bot commented Jul 10, 2024 • edited Loading

github-actions bot commented Jul 11, 2024 • edited Loading

github-actions bot commented Jul 11, 2024 • edited Loading

github-actions bot commented Jul 11, 2024 • edited Loading

github-actions bot commented Jul 11, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading