Fix bugs in coordinator state migration

[snaury]

Changelog entry

Fix bugs in coordinator state migration

Changelog category

• Bugfix

Additional information

It was discovered that coordinator state migration had several bugs that could ultimately allow coordinator to plan additional transactions to the previously planned step, violating invariants.

Fixes #6220.

[github-actions]

⚪ 2024-07-08 10:55:39 UTC Pre-commit check for 468f2c0 has started.
⚪ 2024-07-08 10:58:41 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 11:25:36 UTC Build successful.
⚪ 2024-07-08 11:25:48 UTC Tests are running...
🔴 2024-07-08 13:32:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
10087	9495	0	92	322	178

🟢 2024-07-08 13:33:05 UTC ydbd size 5.2 GiB changed* by +7.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: ab119a2	merge: 468f2c0	diff	diff %
ydbd size	5 614 359 056 Bytes	5 614 366 392 Bytes	+7.2 KiB	+0.000%
ydbd stripped size	1 210 032 824 Bytes	1 210 035 000 Bytes	+2.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2024-07-08 11:03:30 UTC Pre-commit check for 468f2c0 has started.
⚪ 2024-07-08 11:06:31 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 11:20:07 UTC Build successful.

[github-actions]

⚪ 2024-07-08 11:07:20 UTC Pre-commit check for 468f2c0 has started.
⚪ 2024-07-08 11:10:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 11:54:42 UTC Build successful.
⚪ 2024-07-08 11:54:56 UTC Tests are running...
🟢 2024-07-08 13:15:10 UTC Tests successful.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
14428	13111	0	0	1307	10

🟢 2024-07-08 13:15:52 UTC ydbd size 8.1 GiB changed* by +8.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: ab119a2	merge: 468f2c0	diff	diff %
ydbd size	8 721 967 904 Bytes	8 721 976 768 Bytes	+8.7 KiB	+0.000%
ydbd stripped size	476 639 288 Bytes	476 640 376 Bytes	+1.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}