[CBO] Count-Min estimation added" #5852

pashandor789 · 2024-06-21T18:58:05Z

Changelog entry

...

Additional information

...

github-actions · 2024-06-21T19:20:52Z

⚪ 2024-06-21 19:20:51 UTC Pre-commit check for 3221456 has started.
⚪ 2024-06-21 19:23:35 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-21 19:49:00 UTC Build successful.

github-actions · 2024-06-21T19:29:08Z

⚪ 2024-06-21 19:29:08 UTC Pre-commit check for 3221456 has started.
⚪ 2024-06-21 19:31:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-21 19:46:08 UTC Build successful.
⚪ 2024-06-21 19:46:22 UTC Tests are running...
🔴 2024-06-21 22:11:58 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
75778	62444	0	7	13314	13

🟡 2024-06-21 22:12:38 UTC ydbd size 8.3 GiB changed* by +349.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `1fb6b33`	merge: `3221456`	diff	diff %
ydbd size	8 958 431 920 Bytes	8 958 789 864 Bytes	+349.6 KiB	+0.004%
ydbd stripped size	488 329 448 Bytes	488 331 176 Bytes	+1.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-21T19:56:36Z

⚪ 2024-06-21 19:56:36 UTC Pre-commit check for 3221456 has started.
⚪ 2024-06-21 19:59:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-21 20:14:52 UTC Build successful.
⚪ 2024-06-21 20:15:05 UTC Tests are running...
🔴 2024-06-21 22:25:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15047	14420	0	105	353	169

🟡 2024-06-21 22:26:33 UTC ydbd size 5.5 GiB changed* by +286.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `1fb6b33`	merge: `3221456`	diff	diff %
ydbd size	5 853 181 680 Bytes	5 853 474 536 Bytes	+286.0 KiB	+0.005%
ydbd stripped size	1 255 391 304 Bytes	1 255 433 992 Bytes	+41.7 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-22T16:16:21Z

⚪ 2024-06-22 16:16:21 UTC Pre-commit check for 2c43a04 has started.
⚪ 2024-06-22 16:19:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-22 16:49:56 UTC Build successful.

github-actions · 2024-06-22T16:18:41Z

⚪ 2024-06-22 16:18:41 UTC Pre-commit check for 2c43a04 has started.
⚪ 2024-06-22 16:21:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-22 16:33:40 UTC Build successful.
⚪ 2024-06-22 16:33:58 UTC Tests are running...
🔴 2024-06-22 19:12:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
75945	62526	0	8	13394	17

🟡 2024-06-22 19:13:33 UTC ydbd size 8.3 GiB changed* by +349.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `8cc0e51`	merge: `2c43a04`	diff	diff %
ydbd size	8 958 642 328 Bytes	8 958 999 856 Bytes	+349.1 KiB	+0.004%
ydbd stripped size	488 345 896 Bytes	488 347 624 Bytes	+1.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-22T16:18:41Z

⚪ 2024-06-22 16:18:41 UTC Pre-commit check for 2c43a04 has started.
⚪ 2024-06-22 16:21:32 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-22 16:34:19 UTC Build successful.
⚪ 2024-06-22 16:34:32 UTC Tests are running...
🔴 2024-06-22 18:50:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15051	14444	0	94	344	169

🟡 2024-06-22 18:51:37 UTC ydbd size 5.5 GiB changed* by +286.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `8cc0e51`	merge: `2c43a04`	diff	diff %
ydbd size	5 853 374 536 Bytes	5 853 667 360 Bytes	+286.0 KiB	+0.005%
ydbd stripped size	1 255 453 064 Bytes	1 255 495 752 Bytes	+41.7 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-24T14:16:24Z

⚪ 2024-06-24 14:16:24 UTC Pre-commit check for 8999766 has started.
⚪ 2024-06-24 14:19:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-24 14:35:49 UTC Build successful.
⚪ 2024-06-24 14:36:00 UTC Tests are running...
🔴 2024-06-24 16:48:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15062	14432	0	108	349	173

🟡 2024-06-24 16:49:21 UTC ydbd size 5.5 GiB changed* by +286.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `5e4ed6c`	merge: `8999766`	diff	diff %
ydbd size	5 857 018 864 Bytes	5 857 311 704 Bytes	+286.0 KiB	+0.005%
ydbd stripped size	1 255 877 224 Bytes	1 255 919 912 Bytes	+41.7 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-24T14:16:54Z

⚪ 2024-06-24 14:16:54 UTC Pre-commit check for 8999766 has started.
⚪ 2024-06-24 14:19:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-24 14:34:34 UTC Build successful.
⚪ 2024-06-24 14:34:47 UTC Tests are running...
🔴 2024-06-24 16:58:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
75949	62554	0	7	13377	11

🟡 2024-06-24 16:59:38 UTC ydbd size 8.3 GiB changed* by +353.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `5e4ed6c`	merge: `8999766`	diff	diff %
ydbd size	8 964 796 736 Bytes	8 965 158 416 Bytes	+353.2 KiB	+0.004%
ydbd stripped size	488 533 640 Bytes	488 539 528 Bytes	+5.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-24T14:26:40Z

⚪ 2024-06-24 14:26:40 UTC Pre-commit check for 8999766 has started.
⚪ 2024-06-24 14:29:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-24 14:53:17 UTC Build successful.

rvu1024 · 2024-06-26T11:18:40Z

ydb/library/yql/core/yql_statistics.h

@@ -1,5 +1,7 @@
 #pragma once

+#include <ydb/core/util/count_min_sketch.h>


Я против этой зависимости. Ее еще и в пирдирах нет

uzhastik · 2024-06-26T11:27:03Z

ydb/core/ydb_convert/ya.make

 PEERDIR(
    ydb/core/base
    ydb/core/engine
+    ydb/core/kqp/provider


зависимость выглядит плохой

rvu1024 · 2024-06-26T11:39:19Z

@pashandor789 откати пожалуйста коммит

This reverts commit 7357091.

Pavel Ivanov and others added 14 commits April 20, 2024 01:36

[DPHyp] non'returnable std::bitset<128> bug fix

04cab3c

Merge branch 'main' of github.com:ydb-platform/ydb into main

2e64a2c

Merge branch 'main' of github.com:ydb-platform/ydb into main

79fab27

Merge branch 'main' of github.com:ydb-platform/ydb into main

08a7d4b

Merge branch 'main' of github.com:ydb-platform/ydb into main

adfc043

Merge branch 'main' of github.com:ydb-platform/ydb into main

17c39c2

Merge branch 'main' of github.com:ydb-platform/ydb into main

7e8d483

Merge branch 'main' of github.com:ydb-platform/ydb into main

17a15df

Merge branch 'main' of github.com:ydb-platform/ydb into main

a70a710

Merge branch 'main' of github.com:ydb-platform/ydb into main

93b1593

Merge branch 'main' of github.com:ydb-platform/ydb into main

cfc634a

Merge branch 'main' of github.com:ydb-platform/ydb into main

4980601

Merge branch 'main' of github.com:ydb-platform/ydb into main

d9bffc8

[CBO] Count-Min estimation added

910daa6

pashandor789 requested review from a team as code owners June 21, 2024 18:58

github-actions bot added the new-feature label Jun 21, 2024

CBO] Count-Min estimation added

66eed5d

[CBO] Count-Min estimation added

fd65f31

pavelvelikhov previously approved these changes Jun 24, 2024

View reviewed changes

pashandor789 added 4 commits June 24, 2024 13:13

Merge branch 'main' of github.com:ydb-platform/ydb into main

6c22174

[CBO] Count-Min estimation added

0c53ff7

CBO] Count-Min estimation added

23acd3c

[CBO] Count-Min estimation added

cb4a320

pashandor789 added 2 commits June 24, 2024 14:12

[CBO] Count-Min estimation added

4576ece

[CBO] Count-Min estimation added

d3ac373

pashandor789 dismissed pavelvelikhov’s stale review via d3ac373 June 24, 2024 14:13

resetius approved these changes Jun 24, 2024

View reviewed changes

pashandor789 merged commit 7357091 into ydb-platform:main Jun 24, 2024

GrigoriyPA mentioned this pull request Jun 25, 2024

YQ switched fq s3 tests to large #5943

Merged

rvu1024 reviewed Jun 26, 2024

View reviewed changes

uzhastik reviewed Jun 26, 2024

View reviewed changes

pashandor789 added a commit that referenced this pull request Jun 26, 2024

Revert "[CBO] Count-Min estimation added" (#5852)"

956f7ad

This reverts commit 7357091.

pashandor789 mentioned this pull request Jun 26, 2024

Revert "[CBO] Count-Min estimation added"" #5968

Merged

niksaveliev mentioned this pull request Jul 1, 2024

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

Merged

		@@ -1,5 +1,7 @@
		#pragma once

		#include <ydb/core/util/count_min_sketch.h>

[CBO] Count-Min estimation added" #5852

[CBO] Count-Min estimation added" #5852

Uh oh!

Conversation

pashandor789 commented Jun 21, 2024

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rvu1024 Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uzhastik Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

rvu1024 commented Jun 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 22, 2024 •

edited

Loading

github-actions bot commented Jun 22, 2024 •

edited

Loading

github-actions bot commented Jun 22, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024 •

edited

Loading

rvu1024 Jun 26, 2024 •

edited

Loading