Skip to content

Keep track of dynamic proxies too and broadcast messages to them #5826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jun 21, 2024

Changelog entry

Keep track of dynamic proxies too and broadcast messages to them

Changelog category

  • Bugfix

Additional information

This allows correct stopping of all proxies, including ones attached to dynamic nodes or to static nodes that were added online.

@alexvru alexvru force-pushed the interconnect/broadcast-to-dynamic-proxies-too branch from 5697487 to aece235 Compare June 21, 2024 10:36
Copy link

github-actions bot commented Jun 21, 2024

2024-06-21 11:06:02 UTC Pre-commit check for 3b3b4a4 has started.
2024-06-21 11:09:27 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-21 11:38:55 UTC Build successful.
2024-06-21 11:39:05 UTC Tests are running...
🔴 2024-06-21 13:50:51 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14055 13450 0 95 343 167

🟢 2024-06-21 13:51:38 UTC ydbd size 5.5 GiB changed* by +91.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d854dee merge: 3b3b4a4 diff diff %
ydbd size 5 854 399 256 Bytes 5 854 492 808 Bytes +91.4 KiB +0.002%
ydbd stripped size 1 255 487 912 Bytes 1 255 501 736 Bytes +13.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 21, 2024

2024-06-21 11:19:06 UTC Pre-commit check for 3b3b4a4 has started.
2024-06-21 11:21:59 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-21 11:57:52 UTC Build successful.

Copy link

github-actions bot commented Jun 21, 2024

2024-06-21 11:22:04 UTC Pre-commit check for 3b3b4a4 has started.
2024-06-21 11:24:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-21 11:55:25 UTC Build successful.
2024-06-21 11:55:36 UTC Tests are running...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants