[dq] Peephole integration + some transform helpers (YQL-17386) #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-release-asan: some tests FAILED for commit 0d54b2e.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 0d54b2e.
|
vitstn
approved these changes
Dec 20, 2023
|
|
||
| void AfterTypeAnnotation(TTransformationPipeline* pipeline) const final { | ||
| std::for_each(UniqIntegrations_.cbegin(), UniqIntegrations_.cend(), [&](const auto dqInt) { | ||
| for (auto& stage: dqInt->GetPeepholeTransforms(true, ProviderParams_)) { |
Collaborator
There was a problem hiding this comment.
pass pipeline to dqInt directly
This was referenced Dec 21, 2023
Merged
This was referenced Dec 28, 2023
This was referenced Dec 29, 2023
Merged
This was referenced Jan 17, 2024
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.