Skip to content

Add deadlines for each stage of patching #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2024
Merged

Add deadlines for each stage of patching #5677

merged 4 commits into from
Jul 27, 2024

Conversation

@kruall
Copy link
Collaborator

@kruall kruall commented Jun 18, 2024

Changelog entry

Implement a deadline for patching request stages to facilitate a rapid fallback process.

Changelog category

  • Bugfix

Additional information

...

@kruall kruall added the area/blobstorage BlobStorage issues label Jun 18, 2024
@kruall kruall self-assigned this Jun 18, 2024
@github-actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 13:14:57 UTC Pre-commit check for df230fc has started.
⚪ 2024-06-18 13:17:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-18 13:20:04 UTC Build successful.
⚪ 2024-06-18 13:20:16 UTC Tests are running...
🔴 2024-06-18 15:06:41 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9822 9750 0 42 20 10

@github-actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 13:15:00 UTC Pre-commit check for df230fc has started.
⚪ 2024-06-18 13:17:31 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-18 13:20:55 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 13:15:03 UTC Pre-commit check for df230fc has started.
⚪ 2024-06-18 13:17:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-18 13:21:09 UTC Build successful.
⚪ 2024-06-18 13:21:22 UTC Tests are running...
🔴 2024-06-18 14:42:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14061 12723 0 51 1277 10

alexvru
alexvru previously approved these changes Jun 18, 2024
View reviewed changes
@kruall kruall force-pushed the vpatch/fix_timeouts branch from b28c2ae to 8784284 Compare July 26, 2024 09:33
@kruall kruall force-pushed the vpatch/fix_timeouts branch from 8784284 to 5489596 Compare July 26, 2024 11:20
@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 11:22:12 UTC Pre-commit check for 457bfb0 has started.
⚪ 2024-07-26 11:25:27 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 12:24:20 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 11:24:29 UTC Pre-commit check for 457bfb0 has started.
⚪ 2024-07-26 11:27:29 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 12:04:57 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 11:29:16 UTC Pre-commit check for 457bfb0 has started.
⚪ 2024-07-26 11:32:47 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-26 12:24:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 12:38:41 UTC Pre-commit check for d9b0e26 has started.
⚪ 2024-07-26 12:42:10 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 12:44:24 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 12:40:17 UTC Pre-commit check for d9b0e26 has started.
⚪ 2024-07-26 12:43:52 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-07-26 12:44:20 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 12:48:02 UTC Pre-commit check for 842575e has started.
⚪ 2024-07-26 12:51:08 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 12:56:29 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 12:51:00 UTC Pre-commit check for 842575e has started.
⚪ 2024-07-26 12:54:16 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 14:04:03 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 12:51:28 UTC Pre-commit check for 842575e has started.
⚪ 2024-07-26 12:54:35 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-26 14:04:04 UTC Check cancelled

alexvru
alexvru previously approved these changes Jul 26, 2024
View reviewed changes
@kruall kruall force-pushed the vpatch/fix_timeouts branch from f55b878 to d9172af Compare July 26, 2024 14:03
@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 14:07:45 UTC Pre-commit check for 567909f has started.
⚪ 2024-07-26 14:10:36 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 15:54:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15229 13883 0 3 1326 17

⚪ 2024-07-26 15:56:43 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 16:05:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 7 0 2 1 10

⚪ 2024-07-26 16:06:23 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-26 16:14:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 3 0 2 0 9

🟢 2024-07-26 16:16:05 UTC Build successful.
🟢 2024-07-26 16:16:47 UTC ydbd size 8.1 GiB changed* by -2.9 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f773909 merge: 567909f diff diff %
ydbd size 8 668 579 224 Bytes 8 665 547 544 Bytes -2.9 MiB -0.035%
ydbd stripped size 471 561 344 Bytes 471 474 944 Bytes -84.4 KiB -0.018%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 14:08:18 UTC Pre-commit check for 567909f has started.
⚪ 2024-07-26 14:11:11 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 16:30:16 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10931 10348 0 81 331 171

🟢 2024-07-26 16:31:27 UTC Build successful.
🟢 2024-07-26 16:32:16 UTC ydbd size 5.2 GiB changed* by -1.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f773909 merge: 567909f diff diff %
ydbd size 5 565 447 976 Bytes 5 564 014 576 Bytes -1.4 MiB -0.026%
ydbd stripped size 1 198 385 072 Bytes 1 198 103 696 Bytes -274.8 KiB -0.023%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexvru
alexvru previously approved these changes Jul 26, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 14:10:28 UTC Pre-commit check for 567909f has started.
⚪ 2024-07-26 14:13:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 14:42:09 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 18:36:35 UTC Pre-commit check for 212fa83 has started.
⚪ 2024-07-26 18:39:35 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 19:14:03 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 18:36:51 UTC Pre-commit check for 212fa83 has started.
⚪ 2024-07-26 18:39:41 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 21:05:58 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10923 10340 0 84 326 173

🟢 2024-07-26 21:07:01 UTC Build successful.
🟢 2024-07-26 21:07:56 UTC ydbd size 5.2 GiB changed* by -1.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4f9aa39 merge: 212fa83 diff diff %
ydbd size 5 565 519 272 Bytes 5 564 064 032 Bytes -1.4 MiB -0.026%
ydbd stripped size 1 198 392 784 Bytes 1 198 102 352 Bytes -283.6 KiB -0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 18:37:21 UTC Pre-commit check for 212fa83 has started.
⚪ 2024-07-26 18:40:17 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 20:35:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15229 13889 0 1 1325 14

⚪ 2024-07-26 20:36:40 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-26 20:45:05 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 5 0 0 0 9

🟢 2024-07-26 20:46:20 UTC Build successful.
🟢 2024-07-26 20:46:58 UTC ydbd size 8.1 GiB changed* by -3.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6a2d1fe merge: 212fa83 diff diff %
ydbd size 8 669 280 552 Bytes 8 665 682 384 Bytes -3.4 MiB -0.042%
ydbd stripped size 471 587 328 Bytes 471 462 144 Bytes -122.2 KiB -0.027%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall merged commit 7e044ef into ydb-platform:main Jul 27, 2024
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 30, 2024
Merged
kruall added a commit to kruall/ydb that referenced this pull request Jul 31, 2024
@kruall
Add deadlines for each stage of patching (ydb-platform#5677)
bc9fbda
kruall added a commit to kruall/ydb that referenced this pull request Jul 31, 2024
@kruall
Add deadlines for each stage of patching (ydb-platform#5677)
3462ceb
kruall added a commit to kruall/ydb that referenced this pull request Jul 31, 2024
@kruall
Add deadlines for each stage of patching (ydb-platform#5677)
d075cf1
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request Aug 12, 2024
@kruall @MrLolthe1st
Add deadlines for each stage of patching (ydb-platform#5677)
b04e967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexvru alexvru alexvru approved these changes

Assignees

@kruall kruall

Labels

area/blobstorage BlobStorage issues bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kruall @alexvru