Skip to content

allow alter config in replication #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2024
Merged

allow alter config in replication #4850

merged 5 commits into from
Jun 4, 2024

Conversation

VPolka
Copy link
Collaborator

@VPolka VPolka commented May 24, 2024

add alter params for async replication

Changelog category

  • Improvement

Additional information

...

@VPolka VPolka requested a review from a team as a code owner May 24, 2024 16:21
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 16:41:43 UTC Pre-commit check for d4787d7 has started.
⚪ 2024-05-24 16:44:05 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 16:47:11 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 16:48:11 UTC Pre-commit check for d4787d7 has started.
⚪ 2024-05-24 16:50:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 16:53:38 UTC Build successful.
⚪ 2024-05-24 16:53:51 UTC Tests are running...
🔴 2024-05-24 18:46:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72463 59752 0 2 12702 7

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 16:55:58 UTC Pre-commit check for d4787d7 has started.
⚪ 2024-05-24 16:58:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 17:01:51 UTC Build successful.
⚪ 2024-05-24 17:02:03 UTC Tests are running...
🔴 2024-05-24 19:00:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13384 13264 0 45 55 20

CyberROFL
CyberROFL reviewed May 27, 2024
View reviewed changes
@CyberROFL
Copy link
Member

Обрати внимание, что упал тест SqlParsingOnly.AlterAsyncReplicationUnsupportedSettings.

@VPolka VPolka linked an issue May 28, 2024 that may be closed by this pull request
[[multiregional YDB capabilities]]: allow change replication parameters #4721
Closed
@VPolka VPolka force-pushed the allow-changing-replication-params branch from d236fea to fae2213 Compare May 31, 2024 16:13
@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

⚪ 2024-05-31 16:19:27 UTC Pre-commit check for bdcc613 has started.
⚪ 2024-05-31 16:22:08 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-31 16:57:27 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

⚪ 2024-05-31 16:19:38 UTC Pre-commit check for bdcc613 has started.
⚪ 2024-05-31 16:22:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-31 17:01:02 UTC Build successful.
⚪ 2024-05-31 17:01:17 UTC Tests are running...
🔴 2024-05-31 18:48:30 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14516 14394 0 48 66 8

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

⚪ 2024-05-31 16:33:42 UTC Pre-commit check for bdcc613 has started.
⚪ 2024-05-31 16:36:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-31 17:18:39 UTC Build successful.
⚪ 2024-05-31 17:18:48 UTC Tests are running...
🔴 2024-05-31 19:12:03 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73752 60981 0 14 12744 13

CyberROFL
CyberROFL requested changes Jun 3, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

⚪ 2024-06-03 17:03:58 UTC Pre-commit check for b2ee7bb has started.
⚪ 2024-06-03 17:06:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-03 17:25:00 UTC Build successful.
⚪ 2024-06-03 17:25:14 UTC Tests are running...
🔴 2024-06-03 18:09:44 UTC Test run completed, no test results found for commit 59ce0ae. Please check build logs.
⚫ 2024-06-03 18:09:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

⚪ 2024-06-03 17:03:58 UTC Pre-commit check for b2ee7bb has started.
⚪ 2024-06-03 17:06:44 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-03 17:24:38 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

⚪ 2024-06-03 17:04:57 UTC Pre-commit check for b2ee7bb has started.
⚪ 2024-06-03 17:07:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-03 17:27:27 UTC Build successful.
⚪ 2024-06-03 17:27:43 UTC Tests are running...
🔴 2024-06-03 18:09:53 UTC Test run completed, no test results found for commit 59ce0ae. Please check build logs.
⚫ 2024-06-03 18:10:19 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

⚪ 2024-06-03 18:12:43 UTC Pre-commit check for 63759b1 has started.
⚪ 2024-06-03 18:15:38 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-03 18:18:42 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

⚪ 2024-06-03 18:12:55 UTC Pre-commit check for 63759b1 has started.
⚪ 2024-06-03 18:15:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-03 18:18:30 UTC Build successful.
⚪ 2024-06-03 18:18:44 UTC Tests are running...
🔴 2024-06-03 20:26:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14743 14624 0 46 63 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

⚪ 2024-06-03 18:14:00 UTC Pre-commit check for 63759b1 has started.
⚪ 2024-06-03 18:16:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-03 18:19:39 UTC Build successful.
⚪ 2024-06-03 18:19:54 UTC Tests are running...
🔴 2024-06-03 20:19:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74005 61244 0 4 12753 4

@VPolka VPolka merged commit 47fb45a into ydb-platform:main Jun 4, 2024
8 of 12 checks passed
This was referenced Jun 6, 2024
Closed
Closed
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 7, 2024
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 13, 2024
Merged
This was referenced Jun 14, 2024
Merged
Merged
This was referenced Jun 15, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 18, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Merged
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nepal nepal nepal approved these changes

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[[multiregional YDB capabilities]]: allow change replication parameters
3 participants
@VPolka @CyberROFL @nepal