Skip to content

Fixed help for --null-value in import file command and refactored csv parser error handling #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 27, 2024
Merged

Fixed help for --null-value in import file command and refactored csv parser error handling #3936

merged 8 commits into from
Aug 27, 2024

Conversation

@Gazizonoki
Copy link
Collaborator

@Gazizonoki Gazizonoki commented Apr 19, 2024

Changelog entry

Fixed default for --null-value in ydb import file csv/tsv commands and improved error text

Changelog category

  • Bugfix

Additional information

...

@github-actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

⚪ 2024-04-19 13:59:52 UTC Pre-commit check for 088f55d has started.
⚪ 2024-04-19 13:59:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-19 14:01:10 UTC Build successful.
⚪ 2024-04-19 14:02:50 UTC Tests are running...
🔴 2024-04-19 14:32:43 UTC Test run completed, no test results found for commit 3b6657c. Please check build logs.
⚫ 2024-04-19 14:32:46 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

⚪ 2024-04-19 14:00:38 UTC Pre-commit check for 088f55d has started.
⚪ 2024-04-19 14:00:41 UTC Build linux-x86_64-release-clang14 is running...

@Gazizonoki Gazizonoki requested a review from pnv1 April 19, 2024 14:01
@github-actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

⚪ 2024-04-19 14:02:23 UTC Pre-commit check for 088f55d has started.
⚪ 2024-04-19 14:02:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-19 14:03:54 UTC Build successful.

pnv1
pnv1 previously approved these changes Apr 19, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

⚪ 2024-04-19 14:33:36 UTC Pre-commit check for 17a4d83 has started.
⚪ 2024-04-19 14:33:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-19 14:35:00 UTC Build successful.
⚪ 2024-04-19 14:36:35 UTC Tests are running...
🔴 2024-04-19 15:45:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12909 10998 0 20 1876 15

@github-actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

⚪ 2024-04-19 14:34:03 UTC Pre-commit check for 17a4d83 has started.
⚪ 2024-04-19 14:34:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-19 14:35:47 UTC Build successful.
⚪ 2024-04-19 14:37:21 UTC Tests are running...
🔴 2024-04-19 16:11:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8970 8826 0 39 88 17

@github-actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

⚪ 2024-04-19 14:36:12 UTC Pre-commit check for 17a4d83 has started.
⚪ 2024-04-19 14:36:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-19 14:37:51 UTC Build successful.

@Gazizonoki Gazizonoki force-pushed the import-file-change-default branch from 9aa6401 to 9b0879c Compare April 23, 2024 19:30
@github-actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 19:31:18 UTC Pre-commit check for ea79a35 has started.
⚪ 2024-04-23 19:31:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-23 19:32:40 UTC Build successful.
⚪ 2024-04-23 19:34:11 UTC Tests are running...
🔴 2024-04-23 20:43:47 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12933 11014 0 35 1860 24

@github-actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 19:32:10 UTC Pre-commit check for ea79a35 has started.
⚪ 2024-04-23 19:32:12 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-23 19:33:26 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

⚪ 2024-04-23 19:33:34 UTC Pre-commit check for ea79a35 has started.
⚪ 2024-04-23 19:33:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-23 19:35:11 UTC Build successful.
⚪ 2024-04-23 19:36:58 UTC Tests are running...
🔴 2024-04-23 21:15:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8988 8844 0 43 86 15

@github-actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

⚪ 2024-04-24 02:08:53 UTC Pre-commit check for 117dadf has started.
⚪ 2024-04-24 02:08:57 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-04-24 02:10:35 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

⚪ 2024-04-24 02:09:05 UTC Pre-commit check for 117dadf has started.
⚪ 2024-04-24 02:09:08 UTC Build linux-x86_64-release-asan is running...
🔴 2024-04-24 02:10:49 UTC Build failed. see the build logs.
🔴 2024-04-24 02:12:21 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

⚪ 2024-04-24 02:09:11 UTC Pre-commit check for 117dadf has started.
⚪ 2024-04-24 02:09:14 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-04-24 02:10:54 UTC Build failed. see the build logs.
🔴 2024-04-24 02:12:26 UTC Tests run skipped.

@Gazizonoki Gazizonoki force-pushed the import-file-change-default branch from b486f41 to 1511453 Compare April 25, 2024 08:06
@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 08:10:04 UTC Pre-commit check for 9e03715 has started.
⚪ 2024-04-25 08:10:06 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-04-25 08:21:20 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 08:10:16 UTC Pre-commit check for 9e03715 has started.
⚪ 2024-04-25 08:10:18 UTC Build linux-x86_64-release-asan is running...
🔴 2024-04-25 08:16:06 UTC Build failed. see the build logs.
🔴 2024-04-25 08:17:34 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 08:10:25 UTC Pre-commit check for 9e03715 has started.
⚪ 2024-04-25 08:10:27 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-04-25 08:15:58 UTC Build failed. see the build logs.
🔴 2024-04-25 08:17:30 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:15:05 UTC Pre-commit check for 1390e6e has started.
⚪ 2024-04-25 11:15:08 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-25 11:16:30 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:15:06 UTC Pre-commit check for 1390e6e has started.
⚪ 2024-04-25 11:15:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-25 11:16:36 UTC Build successful.
⚪ 2024-04-25 11:18:21 UTC Tests are running...
🔴 2024-04-25 12:04:02 UTC Test run completed, no test results found for commit f41d2bc. Please check build logs.
⚫ 2024-04-25 12:04:07 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:15:14 UTC Pre-commit check for 1390e6e has started.
⚪ 2024-04-25 11:15:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-25 11:16:37 UTC Build successful.
⚪ 2024-04-25 11:18:21 UTC Tests are running...
🔴 2024-04-25 12:03:53 UTC Test run completed, no test results found for commit f41d2bc. Please check build logs.
⚫ 2024-04-25 12:03:56 UTC Check cancelled

pnv1
pnv1 reviewed Apr 25, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 12:08:01 UTC Pre-commit check for 52a0be8 has started.
⚪ 2024-04-25 12:08:04 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-25 12:11:09 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 12:08:06 UTC Pre-commit check for 52a0be8 has started.
⚪ 2024-04-25 12:08:08 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-25 12:09:31 UTC Build successful.
⚪ 2024-04-25 12:11:14 UTC Tests are running...
🔴 2024-04-25 13:55:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9006 8820 0 48 115 23

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 12:09:34 UTC Pre-commit check for 52a0be8 has started.
⚪ 2024-04-25 12:09:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-25 12:10:41 UTC Build successful.
⚪ 2024-04-25 12:12:11 UTC Tests are running...
🔴 2024-04-25 13:22:28 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12956 11056 0 11 1861 28

pnv1
pnv1 previously approved these changes Apr 25, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 01:31:50 UTC Pre-commit check for b0e761c has started.
⚪ 2024-08-27 01:34:35 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-27 01:43:34 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 01:32:01 UTC Pre-commit check for b0e761c has started.
⚪ 2024-08-27 01:34:50 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-27 02:29:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14405 13019 0 7 1360 19

⚪ 2024-08-27 02:31:02 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-27 02:41:04 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 (only retried tests) 24 0 0 0 11

🟢 2024-08-27 02:41:12 UTC Build successful.
🟢 2024-08-27 02:41:49 UTC ydbd size 8.2 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d9ff14c merge: b0e761c diff diff %
ydbd size 8 796 903 120 Bytes 8 796 903 088 Bytes -32 Bytes -0.000%
ydbd stripped size 479 778 312 Bytes 479 778 312 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 15:13:56 UTC Pre-commit check for 68f1700 has started.
⚪ 2024-08-27 15:16:38 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-27 15:41:16 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 15:14:04 UTC Pre-commit check for 68f1700 has started.
⚪ 2024-08-27 15:16:44 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-27 15:21:55 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 15:14:16 UTC Pre-commit check for 68f1700 has started.
⚪ 2024-08-27 15:17:02 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-27 15:41:17 UTC Check cancelled

@Gazizonoki Gazizonoki changed the title Fixed default for --null-value in import file command Fixed help for --null-value in import file command and refactored csv parser error handling Aug 27, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 27, 2024
@Gazizonoki Gazizonoki requested a review from pnv1 August 27, 2024 15:17
pnv1
pnv1 previously approved these changes Aug 27, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 15:42:48 UTC Pre-commit check for 0cf7f56 has started.
⚪ 2024-08-27 15:45:29 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-27 17:14:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9983 9911 0 22 25 25

🟢 2024-08-27 17:15:05 UTC Build successful.
🟢 2024-08-27 17:15:35 UTC ydbd size 5.5 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 352f804 merge: 0cf7f56 diff diff %
ydbd size 5 928 702 608 Bytes 5 928 702 512 Bytes -96 Bytes -0.000%
ydbd stripped size 1 489 038 672 Bytes 1 489 038 608 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 15:43:13 UTC Pre-commit check for 0cf7f56 has started.
⚪ 2024-08-27 15:45:50 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-27 16:39:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14395 12949 0 80 1350 16

⚪ 2024-08-27 16:40:58 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-27 16:51:05 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 86 0 0 0 11

🟢 2024-08-27 16:51:12 UTC Build successful.
🟢 2024-08-27 16:51:48 UTC ydbd size 8.2 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 352f804 merge: 0cf7f56 diff diff %
ydbd size 8 799 879 784 Bytes 8 799 879 752 Bytes -32 Bytes -0.000%
ydbd stripped size 479 835 592 Bytes 479 835 592 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 15:43:19 UTC Pre-commit check for 0cf7f56 has started.
⚪ 2024-08-27 15:46:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-27 15:51:44 UTC Build successful.

@Gazizonoki Gazizonoki enabled auto-merge (squash) August 27, 2024 16:25
@Gazizonoki Gazizonoki merged commit f8f5387 into ydb-platform:main Aug 27, 2024
@Gazizonoki Gazizonoki deleted the import-file-change-default branch August 27, 2024 17:23
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@Gazizonoki @pnv1 @rekby
Fixed help for --null-value in import file command and refactored csv…
1d4c025 
… parser error handling (ydb-platform#3936)

Co-authored-by: Nikolay Perfilov <pnv1@yandex-team.ru>
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@Gazizonoki @pnv1 @stanislav-shchetinin
Fixed help for --null-value in import file command and refactored csv…
1b8efac 
… parser error handling (ydb-platform#3936)

Co-authored-by: Nikolay Perfilov <pnv1@yandex-team.ru>
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
This was referenced Sep 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pnv1 pnv1 pnv1 approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gazizonoki @pnv1