Skip to content

Use SlotName as host label in metrics #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2024
Merged

Use SlotName as host label in metrics #2654

merged 3 commits into from
Mar 28, 2024

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Mar 12, 2024 •
edited
Loading

Changelog entry

Use slot_name that is returned from node broker as host label in metrics

Changelog category

  • Not for changelog (changelog entry is not required)

@pixcc pixcc force-pushed the use-slotid-as-host-label branch from 8099abc to 8b418a4 Compare March 12, 2024 11:23
@pixcc pixcc requested review from Enjection and CyberROFL March 12, 2024 11:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

⚪ 2024-03-12 11:31:26 UTC Pre-commit check for 1f95de8 has started.
⚪ 2024-03-12 11:31:27 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-12 12:04:28 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

⚪ 2024-03-12 12:05:26 UTC Pre-commit check for 1f95de8 has started.
⚪ 2024-03-12 12:05:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-12 12:41:13 UTC Build successful.
⚪ 2024-03-12 12:41:24 UTC Tests are running...
🔴 2024-03-12 14:31:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68225 57274 0 1 10925 25

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

⚪ 2024-03-12 12:08:53 UTC Pre-commit check for 1f95de8 has started.
⚪ 2024-03-12 12:08:55 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-12 12:43:13 UTC Build successful.
⚪ 2024-03-12 12:43:25 UTC Tests are running...
🔴 2024-03-12 14:45:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15036 14471 0 67 467 31

CyberROFL
CyberROFL reviewed Mar 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

⚪ 2024-03-13 12:10:23 UTC Pre-commit check for 6085d18 has started.
⚪ 2024-03-13 12:10:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-13 12:46:00 UTC Build successful.
⚪ 2024-03-13 12:46:10 UTC Tests are running...
🔴 2024-03-13 14:56:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15031 14462 0 68 481 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

⚪ 2024-03-13 12:10:36 UTC Pre-commit check for 6085d18 has started.
⚪ 2024-03-13 12:10:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-13 12:44:25 UTC Build successful.
⚪ 2024-03-13 12:44:38 UTC Tests are running...
🟢 2024-03-13 14:34:05 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68335 57384 0 0 10925 26

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

⚪ 2024-03-13 12:11:53 UTC Pre-commit check for 6085d18 has started.
⚪ 2024-03-13 12:11:56 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-13 12:45:17 UTC Build successful.

@CyberROFL CyberROFL linked an issue Mar 13, 2024 that may be closed by this pull request
Stable host for metrics #2711
Closed
CyberROFL
CyberROFL reviewed Mar 13, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

⚪ 2024-03-13 15:02:08 UTC Pre-commit check for 3402e32 has started.
⚪ 2024-03-13 15:02:11 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-13 15:14:57 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

⚪ 2024-03-13 15:02:10 UTC Pre-commit check for 3402e32 has started.
⚪ 2024-03-13 15:02:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-13 15:15:45 UTC Build successful.
⚪ 2024-03-13 15:16:01 UTC Tests are running...
🔴 2024-03-13 17:25:36 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15042 14471 0 69 475 27

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

⚪ 2024-03-13 15:02:13 UTC Pre-commit check for 3402e32 has started.
⚪ 2024-03-13 15:02:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-13 15:16:20 UTC Build successful.
⚪ 2024-03-13 15:16:35 UTC Tests are running...
🔴 2024-03-13 17:07:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68336 57383 0 2 10925 26

@pixcc pixcc changed the title Use SlotId as host label in metrics Use SlotName as host label in metrics Mar 19, 2024
@pixcc pixcc requested a review from spuchin March 19, 2024 10:48
@pixcc pixcc merged commit 59b0201 into ydb-platform:main Mar 28, 2024
This was referenced Mar 29, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 2, 2024
Merged
@serbel324 serbel324 mentioned this pull request Apr 2, 2024
Merged
This was referenced Apr 4, 2024
Merged
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 4, 2024
Open
This was referenced Apr 6, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 10, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 11, 2024
Merged
This was referenced Apr 16, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request Apr 25, 2024
Merged
pixcc added a commit to pixcc/ydb that referenced this pull request Jun 20, 2024
@pixcc
Use SlotName as host label in metrics (ydb-platform#2654)
c1d2ae0
pixcc added a commit to pixcc/ydb that referenced this pull request Jun 20, 2024
@pixcc
Use SlotName as host label in metrics (ydb-platform#2654)
5279989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@Enjection Enjection Awaiting requested review from Enjection

@spuchin spuchin Awaiting requested review from spuchin

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stable host for metrics
2 participants
@pixcc @CyberROFL