Added proper request finishing in grpc request proxy #2568

domwst · 2024-03-07T18:09:56Z

Added proper request finishing in grpc request proxy

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

github-actions · 2024-03-07T18:12:45Z

⚪ 2024-03-07 18:12:45 UTC Pre-commit check for 5ab515c has started.
⚪ 2024-03-07 18:12:47 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-07 18:23:43 UTC Build successful.

github-actions · 2024-03-07T18:13:21Z

⚪ 2024-03-07 18:13:20 UTC Pre-commit check for 5ab515c has started.
⚪ 2024-03-07 18:13:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-07 18:25:14 UTC Build successful.
⚪ 2024-03-07 18:25:27 UTC Tests are running...
🔴 2024-03-07 20:23:03 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15004	14426	0	71	480	27

github-actions · 2024-03-07T18:13:22Z

⚪ 2024-03-07 18:13:22 UTC Pre-commit check for 5ab515c has started.
⚪ 2024-03-07 18:13:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-07 18:24:55 UTC Build successful.
⚪ 2024-03-07 18:25:12 UTC Tests are running...
🔴 2024-03-07 19:55:34 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68283	57335	0	4	10922	22

github-actions · 2024-03-11T10:41:11Z

⚪ 2024-03-11 10:41:11 UTC Pre-commit check for aa3f009 has started.
⚪ 2024-03-11 10:41:12 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-11 10:53:34 UTC Build successful.

github-actions · 2024-03-11T10:43:40Z

⚪ 2024-03-11 10:43:39 UTC Pre-commit check for aa3f009 has started.
⚪ 2024-03-11 10:43:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-11 10:55:48 UTC Build successful.
⚪ 2024-03-11 10:56:03 UTC Tests are running...
🔴 2024-03-11 12:48:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15010	14442	0	65	477	26

github-actions · 2024-03-11T10:55:40Z

⚪ 2024-03-11 10:55:40 UTC Pre-commit check for aa3f009 has started.
⚪ 2024-03-11 10:55:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-11 11:08:35 UTC Build successful.
⚪ 2024-03-11 11:08:44 UTC Tests are running...
🔴 2024-03-11 12:44:36 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68292	57338	0	10	10922	22

github-actions · 2024-03-11T15:59:26Z

⚪ 2024-03-11 15:59:26 UTC Pre-commit check for 69c088d has started.
⚪ 2024-03-11 15:59:27 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-11 16:07:42 UTC Check cancelled

domwst · 2024-03-11T16:02:55Z

ydb/library/actors/wilson/wilson_span.cpp

+            if (Y_UNLIKELY(*this)) {
+                TStringStream err;
+                err << "TSpan instance incorrectly overwritten at:\n";
+                FormatBackTrace(&err);


Added stacktrace here

github-actions · 2024-03-11T17:43:15Z

⚪ 2024-03-11 17:43:14 UTC Pre-commit check for 07ad248 has started.
⚪ 2024-03-11 17:43:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-11 18:08:23 UTC Build successful.
⚪ 2024-03-11 18:08:32 UTC Tests are running...
🔴 2024-03-11 19:49:39 UTC Test run completed, no test results found for commit 5215125. Please check build logs.
⚫ 2024-03-11 19:49:43 UTC Check cancelled

github-actions · 2024-03-11T18:09:36Z

⚪ 2024-03-11 18:09:36 UTC Pre-commit check for 07ad248 has started.
⚪ 2024-03-11 18:09:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-11 18:40:37 UTC Build successful.
⚪ 2024-03-11 18:40:49 UTC Tests are running...
🔴 2024-03-11 19:49:39 UTC Test run completed, no test results found for commit 5215125. Please check build logs.
⚫ 2024-03-11 19:49:42 UTC Check cancelled

github-actions · 2024-03-11T18:13:28Z

⚪ 2024-03-11 18:13:28 UTC Pre-commit check for 07ad248 has started.
⚪ 2024-03-11 18:13:29 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-11 18:42:17 UTC Build successful.

github-actions · 2024-03-11T19:50:22Z

⚪ 2024-03-11 19:50:22 UTC Pre-commit check for 7c603cb has started.
⚪ 2024-03-11 19:50:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-11 20:18:18 UTC Build successful.
⚪ 2024-03-11 20:18:27 UTC Tests are running...
🔴 2024-03-11 22:21:37 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15023	14436	0	76	482	29

github-actions · 2024-03-11T19:51:02Z

⚪ 2024-03-11 19:51:01 UTC Pre-commit check for 7c603cb has started.
⚪ 2024-03-11 19:51:03 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-11 20:16:24 UTC Build successful.

github-actions · 2024-03-11T19:52:02Z

⚪ 2024-03-11 19:52:02 UTC Pre-commit check for 7c603cb has started.
⚪ 2024-03-11 19:52:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-11 20:18:02 UTC Build successful.
⚪ 2024-03-11 20:18:14 UTC Tests are running...
🔴 2024-03-11 21:47:56 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68221	57259	0	8	10926	28

ydb/core/grpc_services/base/base.h

github-actions · 2024-03-12T13:12:48Z

⚪ 2024-03-12 13:12:48 UTC Pre-commit check for 1991e51 has started.
⚪ 2024-03-12 13:12:49 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-12 13:41:32 UTC Build successful.

github-actions · 2024-03-12T13:17:24Z

⚪ 2024-03-12 13:17:24 UTC Pre-commit check for 1991e51 has started.
⚪ 2024-03-12 13:17:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-12 13:49:09 UTC Build successful.
⚪ 2024-03-12 13:49:19 UTC Tests are running...
🔴 2024-03-12 15:23:13 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68234	57277	0	1	10930	26

github-actions · 2024-03-12T13:33:55Z

⚪ 2024-03-12 13:33:55 UTC Pre-commit check for 1991e51 has started.
⚪ 2024-03-12 13:33:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-12 14:08:00 UTC Build successful.
⚪ 2024-03-12 14:08:08 UTC Tests are running...
🔴 2024-03-12 16:11:53 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15045	14441	0	80	493	31

github-actions bot added the not-for-changelog label Mar 7, 2024

domwst commented Mar 11, 2024

View reviewed changes

Added proper request finishing in grpc request proxy

a0f933e

domwst force-pushed the proper-span-finishing-grpc-request-proxy branch from 5215125 to a0f933e Compare March 11, 2024 19:49

dcherednik reviewed Mar 12, 2024

View reviewed changes

ydb/core/grpc_services/base/base.h Outdated Show resolved Hide resolved

Renamed LegacyFinishSpan -> FinishSpan

f4caf05

dcherednik approved these changes Mar 12, 2024

View reviewed changes

domwst merged commit 78093f9 into ydb-platform:main Mar 12, 2024

domwst added a commit to domwst/ydb that referenced this pull request Mar 12, 2024

Added proper request finishing in grpc request proxy (ydb-platform#2568)

00bc4be

domwst added a commit to domwst/ydb that referenced this pull request Mar 12, 2024

Added proper request finishing in grpc request proxy (ydb-platform#2568)

1423447

domwst linked an issue Mar 13, 2024 that may be closed by this pull request

Fix incorrectly finished/incorrectly overwritten spans in grpc request proxy #2707

Open

serbel324 mentioned this pull request Mar 13, 2024

Initialize all records to prevent borrowing nullptr's #2723

Merged

domwst added a commit to domwst/ydb that referenced this pull request Mar 19, 2024

Added proper request finishing in grpc request proxy (ydb-platform#2568)

10a0dc7

GrigoriyPA mentioned this pull request Mar 19, 2024

Fixed error due to empty token #2966

Merged

This was referenced Mar 20, 2024

Test alter temp table #3011

Merged

Support sequences backup with current value #3023

Closed

Support sequences backup with current value #3089

Merged

YDBDOCS-632: Documentation of temporary tables #3137

Merged

GrigoriyPA mentioned this pull request Mar 26, 2024

YQ-2738 add integration tests for YT in KQP #3150

Merged

shnikd mentioned this pull request Mar 26, 2024

Test temp indexes #3163

Merged

This was referenced Mar 29, 2024

Unmute kafka tests #3285

Merged

Fix kafka counters and RU #3348

Merged

domwst added a commit to domwst/ydb that referenced this pull request Apr 3, 2024

Added proper request finishing in grpc request proxy (ydb-platform#2568)

4349dd3

shnikd mentioned this pull request Apr 4, 2024

Support create sequence in pg parser #3465

Merged

SammyVimes pushed a commit that referenced this pull request Apr 4, 2024

Added proper request finishing in grpc request proxy (#2568)

b7a19ad

This was referenced Apr 6, 2024

Fix kafka read session verify #3522

Merged

Fix kafka read session partitions releases #3528

Merged

shnikd mentioned this pull request Apr 11, 2024

Support create sequence #3662

Merged

serbel324 mentioned this pull request Jun 11, 2024

Merge tracing fixes to 24-1 #5458

Merged

serbel324 pushed a commit to serbel324/ydb that referenced this pull request Jun 11, 2024

Added proper request finishing in grpc request proxy (ydb-platform#2568)

db740d2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added proper request finishing in grpc request proxy #2568

Added proper request finishing in grpc request proxy #2568

domwst commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

domwst Mar 11, 2024

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 12, 2024 •

edited

Loading

github-actions bot commented Mar 12, 2024 •

edited

Loading

github-actions bot commented Mar 12, 2024 •

edited

Loading

Added proper request finishing in grpc request proxy #2568

Added proper request finishing in grpc request proxy #2568

Conversation

domwst commented Mar 7, 2024 • edited Loading