You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CREATE VIEW statement parses (and validates) the select statement saved in the view. It should be parsed in a context isolated from the statements executed before the CREATE VIEW statement (we haven't decided yet on the exact scope of the context of the view's select statement, see KIKIMR-20656). It is pretty obvious that one should be able to execute the following statement in one go ("one go" = one press of a "run" button in YDB UI):
-- create view NecessaryInnerView with (security_invoker = true) as select 1;-- create view ContextTestingView with (security_invoker = true) as select * from `/local/NecessaryInnerView`; -- where `/local/...` is your cluster namedropview ContextTestingView;
createviewContextTestingView with (security_invoker = true) asselect*from`/local/NecessaryInnerView`;
However, executing both drop view and create view in one go currently produces and error:
DropObject is not yet implemented for intent determination transformer
which indicates that the context of the inner query:
select*from`/local/NecessaryInnerView`
is polluted by the previous:
dropview ContextTestingView;
statement.
This problem is fixed by using an empty parsing context for parsing view's inner select statement during handling of CREATE VIEW statement.
⚪ 2024-03-07 06:52:34 UTC Pre-commit check for 7905596 has started.
⚪ 2024-03-07 06:52:36 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-07 06:53:54 UTC Build successful.
⚪ 2024-03-07 06:54:07 UTC Tests are running...
🔴 2024-03-07 08:03:22 UTC Some tests failed, follow the links below.
⚪ 2024-03-07 06:51:54 UTC Pre-commit check for 7905596 has started.
⚪ 2024-03-07 06:51:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-07 06:53:05 UTC Build successful.
⚪ 2024-03-07 06:53:18 UTC Tests are running...
🔴 2024-03-07 06:56:26 UTC Some tests failed, follow the links below.
⚪ 2024-03-07 13:26:14 UTC Pre-commit check for 87c0970 has started.
⚪ 2024-03-07 13:26:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-07 13:27:23 UTC Build successful.
⚪ 2024-03-07 13:27:35 UTC Tests are running...
⚪ 2024-03-07 13:36:46 UTC Pre-commit check for 87c0970 has started.
⚪ 2024-03-07 13:36:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-07 13:38:34 UTC Build successful.
⚪ 2024-03-07 13:38:49 UTC Tests are running...
🔴 2024-03-07 15:15:08 UTC Some tests failed, follow the links below.
Couldn't get proper links to the test results of the linux-x86_64-relwithdebinfo build in testmo, so I decided to drop this pull request and open a new one.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIKIMR-20891
CREATE VIEW statement parses (and validates) the select statement saved in the view. It should be parsed in a context isolated from the statements executed before the CREATE VIEW statement (we haven't decided yet on the exact scope of the context of the view's select statement, see KIKIMR-20656). It is pretty obvious that one should be able to execute the following statement in one go ("one go" = one press of a "run" button in YDB UI):
However, executing both drop view and create view in one go currently produces and error:
which indicates that the context of the inner query:
is polluted by the previous:
statement.
This problem is fixed by using an empty parsing context for parsing view's inner select statement during handling of CREATE VIEW statement.