Skip to content

Disable plain chunks in 24-4 explicitly to prevent data corruption #20965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Disable plain chunks in 24-4 explicitly to prevent data corruption #20965

merged 1 commit into from
Jul 11, 2025

Conversation

va-kuznecov
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

SammyVimes
SammyVimes approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SammyVimes
SammyVimes reviewed Jul 10, 2025
View reviewed changes
ydb/core/blobstorage/pdisk/blobstorage_pdisk_config.h
Comment on lines +398 to +400
if (cfg->HasPlainDataChunks()) {
PlainDataChunks = cfg->GetPlainDataChunks();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to show in the PDisk UI that this feature is set in the config

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2025 •
edited
Loading

⚪ 2025-07-10 17:12:45 UTC Pre-commit check for e5fe580 has started.
⚪ 2025-07-10 17:16:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-07-10 18:19:32 UTC Build successful.
⚪ 2025-07-10 18:19:49 UTC Tests are running...
🔴 2025-07-10 23:12:05 UTC Test run completed, no test results found for commit e8dad24. Please check test log.
🟢 2025-07-10 23:12:41 UTC ydbd size 8.3 GiB changed* by +35.0 KiB, which is < 100.0 KiB vs stream-nb-24-4: OK

ydbd size dash stream-nb-24-4: be7fe5b merge: e5fe580 diff diff %
ydbd size 8 911 060 888 Bytes 8 911 096 736 Bytes +35.0 KiB +0.000%
ydbd stripped size 485 719 272 Bytes 485 721 640 Bytes +2.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-07-10 23:12:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2025 •
edited
Loading

⚪ 2025-07-10 17:14:07 UTC Pre-commit check for e5fe580 has started.
⚪ 2025-07-10 17:17:44 UTC Build linux-x86_64-release-asan is running...
🟢 2025-07-10 18:10:47 UTC Build successful.
⚪ 2025-07-10 18:11:06 UTC Tests are running...
🔴 2025-07-10 20:30:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11899 11777 0 46 30 46

🟢 2025-07-10 20:30:47 UTC ydbd size 5.6 GiB changed* by +53.0 KiB, which is < 100.0 KiB vs stream-nb-24-4: OK

ydbd size dash stream-nb-24-4: be7fe5b merge: e5fe580 diff diff %
ydbd size 6 040 920 616 Bytes 6 040 974 912 Bytes +53.0 KiB +0.001%
ydbd stripped size 1 510 993 728 Bytes 1 511 006 976 Bytes +12.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@va-kuznecov va-kuznecov merged commit 7a91dce into ydb-platform:stream-nb-24-4 Jul 11, 2025
6 of 10 checks passed
@va-kuznecov va-kuznecov deleted the dev_24_4/plain_chunks_stub branch July 18, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyVimes SammyVimes SammyVimes approved these changes

@dcherednik dcherednik dcherednik approved these changes

@mvgorbunov mvgorbunov Awaiting requested review from mvgorbunov mvgorbunov is a code owner

@alexv-smirnov alexv-smirnov Awaiting requested review from alexv-smirnov alexv-smirnov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@va-kuznecov @dcherednik @SammyVimes