YQL-17439: block implementation of From/IntervalFrom/To Datetime UDF functions #1755

fedor-miron · 2024-02-09T01:40:29Z

Added optimized block implementation of FromSeconds, FromMilliseconds, FromMicroseconds, IntervalFromDays, IntervalFromHours, IntervalFromMinutes, IntervalFromSeconds, IntervalFromMilliseconds, IntervalFromMicroseconds, ToDays, ToHours, ToMinutes.

github-actions · 2024-02-09T01:43:44Z

⚪ 2024-02-09 01:43:43 UTC Pre-commit check for 1eea081 has started.
⚪ 2024-02-09 01:43:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 01:46:39 UTC Build successful.
⚪ 2024-02-09 01:46:52 UTC Tests are running...
🔴 2024-02-09 01:56:04 UTC Test run completed, no test results found for commit d6d09e4. Please check build logs.
⚫ 2024-02-09 01:56:09 UTC Check cancelled

github-actions · 2024-02-09T01:44:05Z

⚪ 2024-02-09 01:44:04 UTC Pre-commit check for 1eea081 has started.
⚪ 2024-02-09 01:44:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 01:46:39 UTC Build successful.
⚪ 2024-02-09 01:46:51 UTC Tests are running...
🔴 2024-02-09 01:55:55 UTC Test run completed, no test results found for commit d6d09e4. Please check build logs.
⚫ 2024-02-09 01:55:57 UTC Check cancelled

github-actions · 2024-02-09T01:59:37Z

⚪ 2024-02-09 01:59:36 UTC Pre-commit check for 4b9b1ad has started.
⚪ 2024-02-09 01:59:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 02:01:25 UTC Build successful.
⚪ 2024-02-09 02:01:40 UTC Tests are running...
🔴 2024-02-09 03:49:49 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67408	56470	0	14	10892	32

github-actions · 2024-02-09T01:59:41Z

⚪ 2024-02-09 01:59:41 UTC Pre-commit check for 4b9b1ad has started.
⚪ 2024-02-09 01:59:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 02:01:26 UTC Build successful.
⚪ 2024-02-09 02:01:41 UTC Tests are running...
🔴 2024-02-09 03:41:27 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14738	14544	0	21	134	39

vitstn · 2024-02-09T16:32:44Z

ydb/library/yql/udfs/common/datetime2/datetime_udf.cpp

+            bool isAllNull = inArray->GetNullCount() == length;
+            if (!isAllNull) {
+                for (i64 i = 0; i < length; ++i) {
+                    outValues[i] = Core(inValues[i]);


please return std::pair from Core, see https://godbolt.org/z/coYsffa5T

vitstn · 2024-02-09T17:35:04Z

ydb/library/yql/udfs/common/datetime2/datetime_udf.cpp

@@ -862,8 +869,47 @@ NUdf::TUnboxedValuePod DoAddYears(const NUdf::TUnboxedValuePod& date, i64 years,
    };

    // From*
+
+    template<typename TInput, typename TOutput, TOutput Core(TInput), bool Filter(TInput)>
+    struct TUnaryFixedSizeKernelWithFilter {


please add suffix Unsafe and ensure that TInput/TOutput are std::is_arithmetic

github-actions · 2024-02-11T21:40:46Z

⚪ 2024-02-11 21:40:46 UTC Pre-commit check for ca088f2 has started.
⚪ 2024-02-11 21:40:47 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-11 21:43:38 UTC Build successful.
⚪ 2024-02-11 21:43:47 UTC Tests are running...
🔴 2024-02-11 23:35:08 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67419	56474	0	17	10892	36

github-actions · 2024-02-11T21:40:46Z

⚪ 2024-02-11 21:40:46 UTC Pre-commit check for ca088f2 has started.
⚪ 2024-02-11 21:40:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-11 21:43:15 UTC Build successful.
⚪ 2024-02-11 21:43:29 UTC Tests are running...
🔴 2024-02-11 23:29:08 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14743	14537	0	23	149	34

github-actions · 2024-02-12T14:04:48Z

⚪ 2024-02-12 14:04:48 UTC Pre-commit check for c7cf747 has started.
⚪ 2024-02-12 14:04:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-12 14:08:13 UTC Build successful.
⚪ 2024-02-12 14:08:26 UTC Tests are running...
🔴 2024-02-12 15:59:04 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67429	56366	0	17	10970	76

github-actions · 2024-02-12T14:04:55Z

⚪ 2024-02-12 14:04:55 UTC Pre-commit check for c7cf747 has started.
⚪ 2024-02-12 14:04:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 14:07:17 UTC Build successful.
⚪ 2024-02-12 14:07:29 UTC Tests are running...
🔴 2024-02-12 15:54:30 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14753	14511	0	18	177	47

github-actions · 2024-02-12T23:07:10Z

⚪ 2024-02-12 23:07:09 UTC Pre-commit check for 0bf510a has started.
⚪ 2024-02-12 23:07:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 23:09:33 UTC Build successful.
⚪ 2024-02-12 23:09:44 UTC Tests are running...
🔴 2024-02-12 23:15:40 UTC Test run completed, no test results found for commit 3d53296. Please check build logs.
⚫ 2024-02-12 23:15:44 UTC Check cancelled

github-actions · 2024-02-12T23:07:20Z

⚪ 2024-02-12 23:07:20 UTC Pre-commit check for 0bf510a has started.
⚪ 2024-02-12 23:07:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-12 23:09:55 UTC Build successful.
⚪ 2024-02-12 23:10:03 UTC Tests are running...
🔴 2024-02-12 23:15:39 UTC Test run completed, no test results found for commit 3d53296. Please check build logs.
⚫ 2024-02-12 23:15:41 UTC Check cancelled

github-actions · 2024-02-12T23:16:19Z

⚪ 2024-02-12 23:16:19 UTC Pre-commit check for 07977b2 has started.
⚪ 2024-02-12 23:16:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 23:17:29 UTC Build successful.
⚪ 2024-02-12 23:17:40 UTC Tests are running...
🔴 2024-02-13 01:02:27 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14756	14526	0	20	154	56

github-actions · 2024-02-12T23:16:27Z

⚪ 2024-02-12 23:16:26 UTC Pre-commit check for 07977b2 has started.
⚪ 2024-02-12 23:16:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-12 23:17:41 UTC Build successful.
⚪ 2024-02-12 23:17:50 UTC Tests are running...
🔴 2024-02-13 01:05:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67444	56441	0	16	10956	31

github-actions · 2024-02-13T09:18:52Z

⚪ 2024-02-13 09:18:51 UTC Pre-commit check for 182c28c has started.
⚪ 2024-02-13 09:18:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-13 09:21:06 UTC Build successful.
⚪ 2024-02-13 09:21:16 UTC Tests are running...
🔴 2024-02-13 10:59:18 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14759	14574	0	20	131	34

github-actions · 2024-02-13T09:18:53Z

⚪ 2024-02-13 09:18:53 UTC Pre-commit check for 182c28c has started.
⚪ 2024-02-13 09:18:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-13 09:21:47 UTC Build successful.
⚪ 2024-02-13 09:21:57 UTC Tests are running...

…functions (ydb-platform#1755)

initial

d6d09e4

fedor-miron requested a review from a team as a code owner February 9, 2024 01:40

fix test

4ad88bc

fedor-miron assigned vitstn Feb 9, 2024

vitstn reviewed Feb 9, 2024

View reviewed changes

refactor kernel and add multirow test

fd62cc3

fix test

6fd74d6

fix test

3d53296

fix test

6c2dcb6

fix test

503cedb

vitstn approved these changes Feb 13, 2024

View reviewed changes

fedor-miron merged commit c279616 into ydb-platform:main Feb 13, 2024

This was referenced Feb 14, 2024

fixed pg_get_userbyid function #1936

Merged

support of AnyNonArray type, fixes for array_agg #1958

Merged

pavelvelikhov mentioned this pull request Feb 15, 2024

Fixed a problem with plans in PG ut #1974

Merged

niksaveliev mentioned this pull request Feb 16, 2024

Fix kafka with enabled proxy #2017

Merged

vitstn mentioned this pull request Feb 16, 2024

mock of savepoints #2026

Merged

GrigoriyPA mentioned this pull request Feb 26, 2024

YQ-2898 fix query failed with unknown uncommitted upload issue #2240

Merged

fedor-miron added a commit to fedor-miron/ydb that referenced this pull request Mar 20, 2024

YQL-17439: block implementation of From/IntervalFrom/To Datetime UDF …

7115f15

…functions (ydb-platform#1755)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YQL-17439: block implementation of From/IntervalFrom/To Datetime UDF functions #1755

YQL-17439: block implementation of From/IntervalFrom/To Datetime UDF functions #1755

fedor-miron commented Feb 9, 2024

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

vitstn Feb 9, 2024 •

edited

Loading

vitstn Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 11, 2024 •

edited

Loading

github-actions bot commented Feb 11, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024 •

edited

Loading

YQL-17439: block implementation of From/IntervalFrom/To Datetime UDF functions #1755

YQL-17439: block implementation of From/IntervalFrom/To Datetime UDF functions #1755

Conversation

fedor-miron commented Feb 9, 2024

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

vitstn Feb 9, 2024 • edited Loading

Choose a reason for hiding this comment

vitstn Feb 9, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Feb 11, 2024 • edited Loading

github-actions bot commented Feb 11, 2024 • edited Loading

github-actions bot commented Feb 12, 2024 • edited Loading

github-actions bot commented Feb 12, 2024 • edited Loading

github-actions bot commented Feb 12, 2024 • edited Loading

github-actions bot commented Feb 12, 2024 • edited Loading

github-actions bot commented Feb 12, 2024 • edited Loading

github-actions bot commented Feb 12, 2024 • edited Loading

github-actions bot commented Feb 13, 2024 • edited Loading

github-actions bot commented Feb 13, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

vitstn Feb 9, 2024 •

edited

Loading

vitstn Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 11, 2024 •

edited

Loading

github-actions bot commented Feb 11, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024 •

edited

Loading