Skip to content

support SHOW CREATE VIEW #16668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Apr 2, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Issues:

Support SHOW CREATE VIEW YQL statement.

@jepett0 jepett0 requested review from a team as code owners April 2, 2025 12:46
Copy link

github-actions bot commented Apr 2, 2025

🟢 2025-04-02 12:47:54 UTC The validation of the Pull Request description is successful.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

github-actions bot commented Apr 2, 2025

2025-04-02 12:54:41 UTC Pre-commit check linux-x86_64-release-asan for 0f8e472 has started.
2025-04-02 12:55:09 UTC Artifacts will be uploaded here
2025-04-02 12:58:40 UTC ya make is running...
🟡 2025-04-02 14:11:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12688 12558 0 62 34 34

2025-04-02 14:12:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-02 14:29:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 100 0 32 11 30

2025-04-02 14:29:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-02 14:42:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 31 0 31 6 30

🟢 2025-04-02 14:42:20 UTC Build successful.
🟡 2025-04-02 14:42:50 UTC ydbd size 3.8 GiB changed* by +194.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4d6d062 merge: 0f8e472 diff diff %
ydbd size 4 123 974 632 Bytes 4 124 173 392 Bytes +194.1 KiB +0.005%
ydbd stripped size 1 424 976 488 Bytes 1 424 986 024 Bytes +9.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 2, 2025

2025-04-02 12:56:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0f8e472 has started.
2025-04-02 12:57:13 UTC Artifacts will be uploaded here
2025-04-02 13:00:14 UTC ya make is running...
🟡 2025-04-02 14:07:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27118 24458 0 7 2543 110

2025-04-02 14:09:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-02 14:19:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 69 0 0 0 99

🟢 2025-04-02 14:19:53 UTC Build successful.
🟡 2025-04-02 14:20:14 UTC ydbd size 2.2 GiB changed* by +108.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4d6d062 merge: 0f8e472 diff diff %
ydbd size 2 350 370 736 Bytes 2 350 481 864 Bytes +108.5 KiB +0.005%
ydbd stripped size 491 570 208 Bytes 491 572 448 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@pnv1 pnv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI part LGTM

@jepett0 jepett0 linked an issue Apr 2, 2025 that may be closed by this pull request
1 task
@jepett0 jepett0 enabled auto-merge (squash) April 2, 2025 14:29
@jepett0 jepett0 merged commit 65ab57f into ydb-platform:main Apr 2, 2025
14 checks passed

#include "formatters_common.h"

#include <ydb/core/protos/flat_scheme_op.pb.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут можно обойтись forward declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view: show create
4 participants