Show create table (Column-oriented tables) #16509

shnikd · 2025-03-31T15:29:36Z

Changelog category

Not for changelog (changelog entry is not required)

Description for reviewers

Support show create for column-oriented tables.

github-actions · 2025-03-31T15:32:00Z

⚪ 2025-03-31 15:31:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9312990 has started.
⚪ 2025-03-31 15:32:14 UTC Artifacts will be uploaded here
⚪ 2025-03-31 15:35:00 UTC ya make is running...
🟡 2025-03-31 16:32:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19691	18340	0	2	1242	107

⚪ 2025-03-31 16:34:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-31 16:40:21 UTC ydbd size 2.2 GiB changed* by +33.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ff8b534`	merge: `9312990`	diff	diff %
ydbd size	2 349 178 488 Bytes	2 349 212 328 Bytes	+33.0 KiB	+0.001%
ydbd stripped size	491 112 256 Bytes	491 118 784 Bytes	+6.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2025-03-31 16:40:23 UTC Check cancelled

github-actions · 2025-03-31T15:32:14Z

🟢 2025-03-31 16:42:20 UTC The validation of the Pull Request description is successful.

github-actions · 2025-03-31T15:33:58Z

⚪ 2025-03-31 15:33:58 UTC Pre-commit check linux-x86_64-release-asan for 9312990 has started.
⚪ 2025-03-31 15:34:13 UTC Artifacts will be uploaded here
⚪ 2025-03-31 15:37:02 UTC ya make is running...
⚫ 2025-03-31 16:40:11 UTC Check cancelled

github-actions · 2025-03-31T16:41:45Z

⚪ 2025-03-31 16:41:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for ab8b66f has started.
⚪ 2025-03-31 16:41:59 UTC Artifacts will be uploaded here
⚪ 2025-03-31 16:44:42 UTC ya make is running...
🟡 2025-03-31 17:46:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19691	18334	0	6	1241	110

⚪ 2025-03-31 17:48:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-31 17:59:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
164 (only retried tests)	58	0	1	0	105

⚪ 2025-03-31 18:00:05 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-31 18:11:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
146 (only retried tests)	44	0	0	0	102

🟢 2025-03-31 18:11:45 UTC Build successful.
🟡 2025-03-31 18:12:05 UTC ydbd size 2.2 GiB changed* by +100.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `a701bdb`	merge: `ab8b66f`	diff	diff %
ydbd size	2 349 155 720 Bytes	2 349 258 392 Bytes	+100.3 KiB	+0.004%
ydbd stripped size	491 107 904 Bytes	491 131 520 Bytes	+23.1 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-31T16:44:11Z

⚪ 2025-03-31 16:44:11 UTC Pre-commit check linux-x86_64-release-asan for ab8b66f has started.
⚪ 2025-03-31 16:44:25 UTC Artifacts will be uploaded here
⚪ 2025-03-31 16:47:06 UTC ya make is running...
🟡 2025-03-31 17:57:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12236	12125	0	58	17	36

⚪ 2025-03-31 17:58:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-31 18:10:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
154 (only retried tests)	84	0	33	7	30

⚪ 2025-03-31 18:10:50 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-31 18:29:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
101 (only retried tests)	40	0	33	1	27

🟢 2025-03-31 18:29:13 UTC Build successful.
🟡 2025-03-31 18:29:52 UTC ydbd size 3.8 GiB changed* by +129.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ab10135`	merge: `ab8b66f`	diff	diff %
ydbd size	4 122 141 248 Bytes	4 122 273 616 Bytes	+129.3 KiB	+0.003%
ydbd stripped size	1 424 512 200 Bytes	1 424 563 144 Bytes	+49.8 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

dorooleg · 2025-03-31T17:23:40Z

ydb/core/sys_view/show_create/create_table_formatter.cpp

+        } else {
+            Stream << "false";
+        }
+    } else if (scalar.HasUint8()) {


А точно нету готовых ToString scalar?

Мне кажется нет, во всяком случае не находил, кажется что этот протобуф только для дефолтов используется

dorooleg · 2025-03-31T17:24:17Z

ydb/core/sys_view/show_create/create_table_formatter.cpp

+    } else if (scalar.HasTimestamp()) {
+        ui64 value = scalar.GetTimestamp().GetValue();
+        switch (scalar.GetTimestamp().GetUnit()) {
+            case 0:


Может тут arrow unit заиспользовать?

Поправил

dorooleg · 2025-03-31T17:26:29Z

ydb/core/sys_view/show_create/create_table_formatter.cpp

+            break;
+        }
+        case NKikimrSchemeOp::TColumnTableSharding::kRandomSharding:
+            ythrow TFormatFail(Ydb::StatusIds::UNSUPPORTED, "Random sharding is not supported yet.");


Боюсь что когда его добавят RandomSharding, то точно сломаю SHOW CREATE TABLE. Может тест добавить на этот случай чтобы пошли чинить его после реализации?

dorooleg · 2025-03-31T17:30:39Z

ydb/core/sys_view/show_create/create_table_formatter.cpp

@@ -884,5 +885,311 @@ bool TCreateTableFormatter::Format(const Ydb::Table::TtlSettings& ttlSettings, T
    return true;
 }

+TCreateTableFormatter::TResult TCreateTableFormatter::Format(const TString& tablePath, const TColumnTableDescription& tableDesc, bool temporary) {


У YQL уже есть форматер, возможно ли его применить?

Уже применяется)

github-actions · 2025-04-01T13:54:51Z

⚪ 2025-04-01 13:54:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for fe42c0e has started.
⚪ 2025-04-01 13:55:05 UTC Artifacts will be uploaded here
⚪ 2025-04-01 13:57:57 UTC ya make is running...
🟡 2025-04-01 15:05:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19703	18333	0	11	1246	113

⚪ 2025-04-01 15:07:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 15:17:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
172 (only retried tests)	69	0	2	0	101

⚪ 2025-04-01 15:17:48 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-01 15:28:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
141 (only retried tests)	40	0	0	0	101

🟢 2025-04-01 15:28:29 UTC Build successful.
🟢 2025-04-01 15:28:51 UTC ydbd size 2.2 GiB changed* by +62.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `bc0a601`	merge: `fe42c0e`	diff	diff %
ydbd size	2 350 149 320 Bytes	2 350 213 672 Bytes	+62.8 KiB	+0.003%
ydbd stripped size	491 575 264 Bytes	491 588 000 Bytes	+12.4 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-01T13:55:03Z

⚪ 2025-04-01 13:55:02 UTC Pre-commit check linux-x86_64-release-asan for fe42c0e has started.
⚪ 2025-04-01 13:55:17 UTC Artifacts will be uploaded here
⚪ 2025-04-01 13:58:17 UTC ya make is running...
🟡 2025-04-01 15:22:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12245	12080	0	101	30	34

⚪ 2025-04-01 15:23:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 15:36:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
219 (only retried tests)	137	0	40	9	33

⚪ 2025-04-01 15:36:16 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-01 15:48:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
113 (only retried tests)	40	0	34	7	32

🟢 2025-04-01 15:48:14 UTC Build successful.
🟡 2025-04-01 15:48:43 UTC ydbd size 3.8 GiB changed* by +129.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `bc0a601`	merge: `fe42c0e`	diff	diff %
ydbd size	4 123 631 216 Bytes	4 123 763 584 Bytes	+129.3 KiB	+0.003%
ydbd stripped size	1 425 035 688 Bytes	1 425 086 632 Bytes	+49.8 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

shnikd added 2 commits March 31, 2025 18:28

Initial commit

b67772c

Fixes

cd664c7

Fixes

80c9e7e

github-actions bot added not-for-changelog and removed not-for-changelog labels Mar 31, 2025

dorooleg reviewed Mar 31, 2025

View reviewed changes

Fixes

93a8f8b

shnikd requested a review from dorooleg April 1, 2025 13:54

dorooleg approved these changes Apr 1, 2025

View reviewed changes

shnikd enabled auto-merge (squash) April 1, 2025 13:55

shnikd merged commit 81a0068 into ydb-platform:main Apr 1, 2025
14 checks passed

shnikd mentioned this pull request Jun 2, 2025

Docs: describe show create #19170

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show create table (Column-oriented tables) #16509

Show create table (Column-oriented tables) #16509

Uh oh!

shnikd commented Mar 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

dorooleg Mar 31, 2025

Uh oh!

shnikd Mar 31, 2025

Uh oh!

dorooleg Mar 31, 2025 •

edited

Loading

Uh oh!

shnikd Apr 1, 2025

Uh oh!

dorooleg Mar 31, 2025 •

edited by shnikd

Loading

Uh oh!

dorooleg Mar 31, 2025

Uh oh!

shnikd Apr 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Show create table (Column-oriented tables) #16509

Show create table (Column-oriented tables) #16509

Uh oh!

Conversation

shnikd commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category

Description for reviewers

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dorooleg Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

shnikd Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

dorooleg Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shnikd Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

dorooleg Mar 31, 2025 • edited by shnikd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dorooleg Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

shnikd Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shnikd commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading

dorooleg Mar 31, 2025 •

edited

Loading

dorooleg Mar 31, 2025 •

edited by shnikd

Loading

shnikd Apr 1, 2025 •

edited

Loading

github-actions bot commented Apr 1, 2025 •

edited

Loading

github-actions bot commented Apr 1, 2025 •

edited

Loading