Skip to content

provide database in schemecache request #15941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

alexnick88
Copy link
Collaborator

@alexnick88 alexnick88 commented Mar 19, 2025

Provide database name in schemecache request.
Without database name schemecache could answer with PathUnknown instead of Unavailable in some cases.
This leads to bug, described in KIKIMR-22718.

  • Bugfix

@alexnick88 alexnick88 requested a review from a team as a code owner March 19, 2025 10:53
Copy link

github-actions bot commented Mar 19, 2025

2025-03-19 10:54:41 UTC Pre-commit check for 20ca988 has started.
2025-03-19 10:57:25 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-19 11:22:06 UTC Build successful.
2025-03-19 11:22:23 UTC Tests are running...
🔴 2025-03-19 13:35:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10312 10202 0 39 28 43

🟢 2025-03-19 13:36:07 UTC ydbd size 5.6 GiB changed* by +50.8 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 9480de8 merge: 20ca988 diff diff %
ydbd size 6 027 486 016 Bytes 6 027 538 048 Bytes +50.8 KiB +0.001%
ydbd stripped size 1 508 409 984 Bytes 1 508 417 536 Bytes +7.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 19, 2025

2025-03-19 10:55:54 UTC Pre-commit check for 20ca988 has started.
2025-03-19 10:58:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-19 11:40:32 UTC Build successful.
2025-03-19 11:40:50 UTC Tests are running...
🔴 2025-03-19 13:09:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14564 13199 0 21 1300 44

🟢 2025-03-19 13:10:39 UTC ydbd size 8.3 GiB changed* by +27.9 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 9480de8 merge: 20ca988 diff diff %
ydbd size 8 898 141 624 Bytes 8 898 170 192 Bytes +27.9 KiB +0.000%
ydbd stripped size 485 012 200 Bytes 485 013 992 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexnick88 alexnick88 enabled auto-merge (squash) March 19, 2025 10:57
@alexnick88 alexnick88 merged commit a1884b0 into ydb-platform:stable-24-4 Mar 19, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants