Skip to content

Fix Console version handling #15679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Mar 13, 2025

Changelog entry

Fix Console version handling

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This fix allows correct migration between 25-1 and 24-4 stables.

Copy link

🟢 2025-03-13 08:04:35 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 13, 2025

2025-03-13 08:07:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3082303 has started.
2025-03-13 08:07:49 UTC Artifacts will be uploaded here
2025-03-13 08:10:46 UTC ya make is running...
🟡 2025-03-13 08:59:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19479 18128 0 4 1236 111

2025-03-13 09:01:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-13 09:14:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 67 0 0 0 106

🟢 2025-03-13 09:14:24 UTC Build successful.
🟢 2025-03-13 09:14:44 UTC ydbd size 2.1 GiB changed* by +19.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 635bacb merge: 3082303 diff diff %
ydbd size 2 297 419 840 Bytes 2 297 439 976 Bytes +19.7 KiB +0.001%
ydbd stripped size 480 945 088 Bytes 480 949 888 Bytes +4.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 13, 2025

2025-03-13 08:07:57 UTC Pre-commit check linux-x86_64-release-asan for 3082303 has started.
2025-03-13 08:08:12 UTC Artifacts will be uploaded here
2025-03-13 08:11:05 UTC ya make is running...
🟡 2025-03-13 09:14:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12000 11907 0 43 17 33

2025-03-13 09:15:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-13 09:29:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 108 0 1 6 30

2025-03-13 09:29:20 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-13 09:40:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 30 0 0 6 26

🟢 2025-03-13 09:40:41 UTC Build successful.
🟢 2025-03-13 09:41:08 UTC ydbd size 3.8 GiB changed* by +43.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 635bacb merge: 3082303 diff diff %
ydbd size 4 044 191 888 Bytes 4 044 236 592 Bytes +43.7 KiB +0.001%
ydbd stripped size 1 399 422 024 Bytes 1 399 437 192 Bytes +14.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexvru alexvru merged commit 6238290 into ydb-platform:main Mar 13, 2025
14 checks passed
@alexvru alexvru deleted the console/fix-version-racing branch March 13, 2025 13:49
alexvru added a commit to alexvru/ydb that referenced this pull request Mar 14, 2025
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
Enjection pushed a commit to Enjection/ydb that referenced this pull request Mar 26, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants