Skip to content

Make correct BSC <-> distconf interoperation protocol when enabling/disabling distconf #15616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Mar 12, 2025

Changelog entry

Make correct BSC <-> distconf interoperation protocol when enabling/disabling distconf

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

BSC <-> distconf interaction protocol now can handle switches between distconf/BSC correctly.

Copy link

🟢 2025-03-12 09:02:09 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 09:04:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 476a3b6 has started.
2025-03-12 09:05:10 UTC Artifacts will be uploaded here
2025-03-12 09:08:28 UTC ya make is running...
2025-03-12 09:29:20 UTC Check cancelled

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 09:05:46 UTC Pre-commit check linux-x86_64-release-asan for 476a3b6 has started.
2025-03-12 09:06:02 UTC Artifacts will be uploaded here
2025-03-12 09:09:15 UTC ya make is running...
2025-03-12 09:29:20 UTC Check cancelled

@alexvru alexvru force-pushed the distconf/correct-enabling-sequence branch from 52c4ddd to ddaf43b Compare March 12, 2025 09:28
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 09:30:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 85144d4 has started.
2025-03-12 09:30:56 UTC Artifacts will be uploaded here
2025-03-12 09:34:09 UTC ya make is running...
🟡 2025-03-12 10:51:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28267 25679 0 6 2466 116

2025-03-12 10:54:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-12 11:06:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 54 0 1 0 105

2025-03-12 11:07:08 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-12 11:19:07 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 44 0 1 0 101

🟢 2025-03-12 11:19:15 UTC Build successful.
🟡 2025-03-12 11:19:36 UTC ydbd size 2.1 GiB changed* by +1.8 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 3acfcb7 merge: 85144d4 diff diff %
ydbd size 2 296 302 536 Bytes 2 298 179 592 Bytes +1.8 MiB +0.082%
ydbd stripped size 480 741 184 Bytes 480 952 672 Bytes +206.5 KiB +0.044%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 09:32:16 UTC Pre-commit check linux-x86_64-release-asan for 85144d4 has started.
2025-03-12 09:32:31 UTC Artifacts will be uploaded here
2025-03-12 09:35:45 UTC ya make is running...
🟡 2025-03-12 11:01:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13846 13638 0 153 20 35

2025-03-12 11:02:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-12 11:16:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
304 (only retried tests) 203 0 68 2 31

2025-03-12 11:16:27 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-12 11:29:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 (only retried tests) 106 0 42 0 32

🟢 2025-03-12 11:29:33 UTC Build successful.
🔴 2025-03-12 11:30:04 UTC ydbd size 3.7 GiB changed* by +2.9 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 3acfcb7 merge: 85144d4 diff diff %
ydbd size 3 999 338 840 Bytes 4 002 414 136 Bytes +2.9 MiB +0.077%
ydbd stripped size 1 389 759 176 Bytes 1 390 357 320 Bytes +584.1 KiB +0.043%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

kruall
kruall previously approved these changes Mar 12, 2025
@alexvru alexvru enabled auto-merge (squash) March 12, 2025 11:59
@alexvru alexvru force-pushed the distconf/correct-enabling-sequence branch from ddaf43b to e820610 Compare March 12, 2025 12:44
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 12:48:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for c3b56fb has started.
2025-03-12 12:49:04 UTC Artifacts will be uploaded here
2025-03-12 12:52:18 UTC ya make is running...
🟡 2025-03-12 14:23:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28394 25793 0 2 2483 116

2025-03-12 14:26:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-12 14:40:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 72 0 0 0 106

🟢 2025-03-12 14:40:25 UTC Build successful.
🟡 2025-03-12 14:40:50 UTC ydbd size 2.1 GiB changed* by +403.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: eda007c merge: c3b56fb diff diff %
ydbd size 2 297 951 776 Bytes 2 298 365 112 Bytes +403.6 KiB +0.018%
ydbd stripped size 480 968 512 Bytes 481 015 776 Bytes +46.2 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 12:48:57 UTC Pre-commit check linux-x86_64-release-asan for c3b56fb has started.
2025-03-12 12:49:15 UTC Artifacts will be uploaded here
2025-03-12 12:52:31 UTC ya make is running...
🟡 2025-03-12 14:37:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13967 13871 0 39 19 38

2025-03-12 14:39:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-12 14:52:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 105 0 1 5 34

2025-03-12 14:52:44 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-12 15:04:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 38 0 0 0 32

🟢 2025-03-12 15:04:33 UTC Build successful.
🟡 2025-03-12 15:05:03 UTC ydbd size 3.8 GiB changed* by +616.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ecf0ad1 merge: c3b56fb diff diff %
ydbd size 4 044 620 984 Bytes 4 045 251 768 Bytes +616.0 KiB +0.016%
ydbd stripped size 1 399 433 544 Bytes 1 399 547 944 Bytes +111.7 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit d995864 into ydb-platform:main Mar 12, 2025
12 checks passed
@alexvru alexvru deleted the distconf/correct-enabling-sequence branch March 12, 2025 15:29
alexvru added a commit to alexvru/ydb that referenced this pull request Mar 14, 2025
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
Enjection pushed a commit to Enjection/ydb that referenced this pull request Mar 26, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants