Skip to content

Initializing the configuration of the partition (#15557) #15576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Mar 11, 2025

Changelog entry

At startup, the background partition used the configuration of the main partition.

#15559

Changelog category

  • Bugfix

Description for reviewers

  • The key for the config now uses the InternalPartitionId.
  • When creating the config for the background partition, the Consumers field is cleared.
  • Added checking the size of Consumers after initialization.

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner March 11, 2025 11:27
Copy link

github-actions bot commented Mar 11, 2025

2025-03-12 04:42:21 UTC Pre-commit check for e4f0ab4 has started.
2025-03-12 04:45:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-12 05:24:26 UTC Build successful.
2025-03-12 05:24:43 UTC Tests are running...
🔴 2025-03-12 06:53:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14792 13433 0 23 1300 36

🟢 2025-03-12 06:54:16 UTC ydbd size 8.3 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: a7c972c merge: e4f0ab4 diff diff %
ydbd size 8 898 122 152 Bytes 8 898 125 744 Bytes +3.5 KiB +0.000%
ydbd stripped size 485 004 200 Bytes 485 004 328 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 11, 2025

2025-03-12 04:39:16 UTC Pre-commit check for e4f0ab4 has started.
2025-03-12 04:42:00 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-12 05:05:57 UTC Build successful.
2025-03-12 05:06:13 UTC Tests are running...
🔴 2025-03-12 07:20:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10361 10255 0 37 25 44

🟢 2025-03-12 07:21:21 UTC ydbd size 5.6 GiB changed* by -4.8 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: a7c972c merge: e4f0ab4 diff diff %
ydbd size 6 027 448 776 Bytes 6 027 443 912 Bytes -4.8 KiB -0.000%
ydbd stripped size 1 508 411 200 Bytes 1 508 410 432 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) March 11, 2025 11:37
@Alek5andr-Kotov Alek5andr-Kotov merged commit cc226a3 into ydb-platform:stable-24-4 Mar 12, 2025
8 of 14 checks passed
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants