Skip to content

Add per-tx inflight counter to tablets and fix follower per-tx counters #15575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

snaury
Copy link
Member

@snaury snaury commented Mar 11, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Add per-tx inflight to tablet counters. Additionally it looks like followers historically didn't update per-tx counters when they should have, and there may have been a bug with per-tx counters on follower promotion.

Fixes #15567.

@snaury snaury self-assigned this Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

2025-03-11 11:01:45 UTC Pre-commit check linux-x86_64-release-asan for 8eacd84 has started.
2025-03-11 11:01:49 UTC Artifacts will be uploaded here
2025-03-11 11:05:10 UTC ya make is running...
🟡 2025-03-11 12:56:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13827 13603 0 178 12 34

2025-03-11 12:58:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-11 13:14:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
317 (only retried tests) 179 0 100 7 31

2025-03-11 13:14:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-11 13:32:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 110 0 68 6 32

🟢 2025-03-11 13:33:04 UTC Build successful.
🟢 2025-03-11 13:33:38 UTC ydbd size 3.7 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4880f2d merge: 8eacd84 diff diff %
ydbd size 3 998 881 392 Bytes 3 998 883 288 Bytes +1.9 KiB +0.000%
ydbd stripped size 1 389 593 896 Bytes 1 389 596 264 Bytes +2.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 11, 2025

🟢 2025-03-11 14:27:51 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 11, 2025

2025-03-11 11:04:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8eacd84 has started.
2025-03-11 11:05:06 UTC Artifacts will be uploaded here
2025-03-11 11:08:23 UTC ya make is running...
🟡 2025-03-11 12:38:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28243 25659 0 2 2466 116

2025-03-11 12:41:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-11 12:53:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 54 0 0 0 108

🟢 2025-03-11 12:53:44 UTC Build successful.
🟢 2025-03-11 12:54:07 UTC ydbd size 2.1 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4880f2d merge: 8eacd84 diff diff %
ydbd size 2 296 125 704 Bytes 2 296 128 088 Bytes +2.3 KiB +0.000%
ydbd stripped size 480 730 208 Bytes 480 731 040 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury requested a review from lex007in March 11, 2025 12:27
@snaury snaury marked this pull request as ready for review March 11, 2025 12:27
@snaury snaury merged commit e6c8de4 into ydb-platform:main Mar 11, 2025
15 of 16 checks passed
@snaury snaury deleted the feature-15567-per-tx-inflight branch March 11, 2025 14:25
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tablets: per-transaction inflight counter
2 participants