Skip to content

fix coverity issues: evaluation order violations #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2024
Merged

fix coverity issues: evaluation order violations #1556

merged 4 commits into from
Feb 5, 2024

Conversation

@uzhastik
Copy link
Collaborator

@uzhastik uzhastik commented Feb 2, 2024

Changelog entry

...

Changelog category

  • Improvement

Additional information

...

@uzhastik uzhastik requested a review from a team as a code owner February 2, 2024 14:45
@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 14:48:48 UTC Pre-commit check for fcbc628 has started.
⚪ 2024-02-02 14:48:50 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-02 14:50:54 UTC Build failed. see the build logs.
⚪ 2024-02-02 14:51:06 UTC Tests are running...
🔴 2024-02-02 14:59:15 UTC Test run completed, no test results found for commit c751223. Please check build logs.
⚫ 2024-02-02 14:59:18 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 14:49:09 UTC Pre-commit check for fcbc628 has started.
⚪ 2024-02-02 14:49:11 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-02 14:51:06 UTC Build failed. see the build logs.
⚪ 2024-02-02 14:51:18 UTC Tests are running...
🔴 2024-02-02 14:59:10 UTC Test run completed, no test results found for commit c751223. Please check build logs.
⚫ 2024-02-02 14:59:12 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 15:01:02 UTC Pre-commit check for bb8bea9 has started.
⚪ 2024-02-02 15:01:05 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-02 15:02:52 UTC Build failed. see the build logs.
⚪ 2024-02-02 15:03:07 UTC Tests are running...
🔴 2024-02-02 15:20:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5488 5112 0 364 1 11

@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 15:01:24 UTC Pre-commit check for bb8bea9 has started.
⚪ 2024-02-02 15:01:26 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-02 15:03:15 UTC Build failed. see the build logs.
⚪ 2024-02-02 15:03:30 UTC Tests are running...
🔴 2024-02-02 15:18:02 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5359 5031 0 308 7 13

@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 15:24:42 UTC Pre-commit check for 7685aff has started.
⚪ 2024-02-02 15:24:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-02 15:28:04 UTC Build successful.
⚪ 2024-02-02 15:28:14 UTC Tests are running...
🔴 2024-02-02 17:05:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58860 49565 0 4 9265 26

@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 15:24:43 UTC Pre-commit check for 7685aff has started.
⚪ 2024-02-02 15:24:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-02 15:28:11 UTC Build successful.
⚪ 2024-02-02 15:28:20 UTC Tests are running...
🔴 2024-02-02 17:06:10 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14531 14388 0 32 63 48

resetius
resetius approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@resetius resetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@uzhastik uzhastik merged commit b5a8005 into ydb-platform:main Feb 5, 2024
@shnikd shnikd mentioned this pull request Feb 5, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
@vitstn vitstn mentioned this pull request Feb 6, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 5, 2024
@uzhastik @EgorkaZ
fix coverity issues: evaluation order violations (ydb-platform#1556)
8c51114 
* fix coverity issues

* fix build

* fix build

* fix build again
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 8, 2024
@uzhastik @EgorkaZ
fix coverity issues: evaluation order violations (ydb-platform#1556)
dd11a80 
* fix coverity issues

* fix build

* fix build

* fix build again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@resetius resetius resetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uzhastik @resetius