Skip to content

Reuse S3 locators to prevent false trash accumulation #15390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Mar 6, 2025

Changelog entry

Reuse S3 locators to prevent false trash accumulation

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

S3 locators are now reused, as they are not immutable unlike blobs, but they need explicit collection.

Copy link

github-actions bot commented Mar 6, 2025

🟢 2025-03-06 07:32:29 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 07:34:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b6e1d7 has started.
2025-03-06 07:34:55 UTC Artifacts will be uploaded here
2025-03-06 07:37:37 UTC ya make is running...
🟡 2025-03-06 08:26:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19459 18114 0 6 1220 119

2025-03-06 08:28:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 08:40:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 75 0 0 0 106

🟢 2025-03-06 08:41:04 UTC Build successful.
🟢 2025-03-06 08:41:23 UTC ydbd size 2.1 GiB changed* by +2.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89fbf3d merge: 8b6e1d7 diff diff %
ydbd size 2 293 100 864 Bytes 2 293 103 056 Bytes +2.1 KiB +0.000%
ydbd stripped size 480 444 992 Bytes 480 445 440 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 07:35:48 UTC Pre-commit check linux-x86_64-release-asan for 8b6e1d7 has started.
2025-03-06 07:36:03 UTC Artifacts will be uploaded here
2025-03-06 07:38:53 UTC ya make is running...
🟡 2025-03-06 08:47:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11995 11630 0 275 50 40

2025-03-06 08:48:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 09:08:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
545 (only retried tests) 278 0 193 42 32

2025-03-06 09:08:50 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-06 09:25:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
409 (only retried tests) 164 0 181 34 30

🟢 2025-03-06 09:26:00 UTC Build successful.
🟢 2025-03-06 09:26:39 UTC ydbd size 3.7 GiB changed* by +16.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89fbf3d merge: 8b6e1d7 diff diff %
ydbd size 3 993 538 432 Bytes 3 993 555 576 Bytes +16.7 KiB +0.000%
ydbd stripped size 1 388 716 392 Bytes 1 388 721 448 Bytes +4.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) March 6, 2025 09:49
@alexvru alexvru merged commit 78f10f9 into ydb-platform:main Mar 6, 2025
14 checks passed
@alexvru alexvru deleted the blob_depot/s3/reuse-locators branch March 6, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants