Skip to content

Changed alias handling in CBO #15311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

pavelvelikhov
Copy link
Collaborator

@pavelvelikhov pavelvelikhov commented Mar 4, 2025

Changelog entry

The alias name was incorrectly determined for YT CBO usage
An alias may contain a '.' character, but we were mishandling this case
#15317

Changelog category

  • Bugfix

Description for reviewers

...

@pavelvelikhov pavelvelikhov requested review from a team as code owners March 4, 2025 13:51
@github-actions github-actions bot added the bugfix label Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

🟢 2025-03-04 17:30:04 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 13:54:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for f2c6c1a has started.
2025-03-04 13:54:39 UTC Artifacts will be uploaded here
2025-03-04 13:57:37 UTC ya make is running...
🟡 2025-03-04 14:58:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26240 23627 0 9 2465 139

2025-03-04 15:01:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 15:15:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
222 (only retried tests) 92 0 1 0 129

2025-03-04 15:15:22 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-04 15:29:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 67 0 0 0 127

🟢 2025-03-04 15:29:15 UTC Build successful.
🟢 2025-03-04 15:29:39 UTC ydbd size 2.1 GiB changed* by +224 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: ad0b833 merge: f2c6c1a diff diff %
ydbd size 2 289 690 984 Bytes 2 289 691 208 Bytes +224 Bytes +0.000%
ydbd stripped size 479 831 392 Bytes 479 831 456 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 13:55:50 UTC Pre-commit check linux-x86_64-release-asan for f2c6c1a has started.
2025-03-04 13:56:05 UTC Artifacts will be uploaded here
2025-03-04 13:58:58 UTC ya make is running...
🟡 2025-03-04 15:10:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11862 11661 0 145 21 35

2025-03-04 15:12:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 15:29:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
268 (only retried tests) 228 0 7 3 30

2025-03-04 15:29:12 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-04 15:43:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 36 0 0 2 28

🟢 2025-03-04 15:43:29 UTC Build successful.
🟡 2025-03-04 15:44:00 UTC ydbd size 3.7 GiB changed* by +893.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4f16aff merge: f2c6c1a diff diff %
ydbd size 3 989 751 808 Bytes 3 990 667 112 Bytes +893.9 KiB +0.023%
ydbd stripped size 1 388 809 064 Bytes 1 389 070 888 Bytes +255.7 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Mar 4, 2025
@pavelvelikhov pavelvelikhov linked an issue Mar 4, 2025 that may be closed by this pull request
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 4, 2025
@pavelvelikhov pavelvelikhov merged commit 04af800 into ydb-platform:main Mar 4, 2025
18 of 20 checks passed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Co-authored-by: Pavel Velikhov <pavelvelikhov@localhost.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unknown column exception
2 participants