Skip to content

Fix ld preload for breakpad #15305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Mar 4, 2025

Return breakpad support with LD_PRELOAD

Technically this PR reverts
480b6dd
acab634

Copy link

github-actions bot commented Mar 4, 2025

🟢 2025-03-04 15:14:18 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 13:28:25 UTC Pre-commit check linux-x86_64-release-asan for b90c46a has started.
2025-03-04 13:28:40 UTC Artifacts will be uploaded here
2025-03-04 13:31:04 UTC ya make is running...
🟢 2025-03-04 13:31:10 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-03-04 13:31:21 UTC Build successful.

Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 13:28:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for b90c46a has started.
2025-03-04 13:28:52 UTC Artifacts will be uploaded here
2025-03-04 13:31:22 UTC ya make is running...
🟢 2025-03-04 13:32:50 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 2 0 0 0 0

🟢 2025-03-04 13:32:57 UTC Build successful.
🟢 2025-03-04 13:33:06 UTC ydbd size 2.1 GiB changed* by +26.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 57dc7ac merge: b90c46a diff diff %
ydbd size 2 289 174 928 Bytes 2 289 201 896 Bytes +26.3 KiB +0.001%
ydbd stripped size 479 753 792 Bytes 479 753 280 Bytes -512 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk changed the title Fix ld preload Fix ld preload for breakpad Mar 4, 2025
@naspirato naspirato self-requested a review March 4, 2025 15:47
@maximyurchuk maximyurchuk marked this pull request as ready for review March 4, 2025 15:48
@maximyurchuk maximyurchuk merged commit 827cd39 into ydb-platform:main Mar 4, 2025
18 of 20 checks passed
maximyurchuk added a commit to maximyurchuk/ydb that referenced this pull request Mar 4, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants