-
Notifications
You must be signed in to change notification settings - Fork 694
#9056 Format module commands/interactive #15212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9056 Format module commands/interactive #15212
Conversation
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Hi! Thank you for contributing! |
🟢 |
@@ -12,189 +12,191 @@ | |||
#include <ydb/public/lib/ydb_cli/commands/ydb_sql.h> | |||
|
|||
namespace NYdb { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace NYdb::NConsoleClient {
And there will be no need to move the whole file
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Cerr << error.what(); | ||
} | ||
} | ||
|
||
std::cout << std::endl << "Bye" << std::endl; | ||
std::cout << std::endl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how yatool
format it) Returned back.
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Changelog entry
Format module commands/interactive using
ya style
.Changelog category
Description for reviewers
ya style *
at the module commands/interactive.