Skip to content

#9056 Format module commands/interactive #15212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

vityaman
Copy link
Contributor

Changelog entry

Format module commands/interactive using ya style.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

  • Ran ya style * at the module commands/interactive.

Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman vityaman requested a review from a team as a code owner February 28, 2025 14:17
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

Copy link

🟢 2025-02-28 14:19:07 UTC The validation of the Pull Request description is successful.

@@ -12,189 +12,191 @@
#include <ydb/public/lib/ydb_cli/commands/ydb_sql.h>

namespace NYdb {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace NYdb::NConsoleClient {
And there will be no need to move the whole file

Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Cerr << error.what();
}
}

std::cout << std::endl << "Bye" << std::endl;
std::cout << std::endl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it really needed?

Copy link
Contributor Author

@vityaman vityaman Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how yatool format it) Returned back.

Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@pnv1 pnv1 added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 3, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

2025-03-03 12:46:29 UTC Pre-commit check linux-x86_64-release-asan for e6e9e47 has started.
2025-03-03 12:46:57 UTC Artifacts will be uploaded here
2025-03-03 12:49:40 UTC ya make is running...
🟢 2025-03-03 13:02:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
634 622 0 0 6 6

🟢 2025-03-03 13:02:30 UTC Build successful.
🟢 2025-03-03 13:02:43 UTC ydbd size 3.7 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6afe3c8 merge: e6e9e47 diff diff %
ydbd size 3 988 492 304 Bytes 3 988 496 768 Bytes +4.4 KiB +0.000%
ydbd stripped size 1 388 505 480 Bytes 1 388 507 272 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 3, 2025

2025-03-03 12:48:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for e6e9e47 has started.
2025-03-03 12:48:44 UTC Artifacts will be uploaded here
2025-03-03 12:51:07 UTC ya make is running...
🟢 2025-03-03 13:04:05 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1053 1044 0 0 2 7

🟢 2025-03-03 13:04:18 UTC Build successful.
🟢 2025-03-03 13:04:29 UTC ydbd size 2.1 GiB changed* by +768 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1f60fc8 merge: e6e9e47 diff diff %
ydbd size 2 288 460 760 Bytes 2 288 461 528 Bytes +768 Bytes +0.000%
ydbd stripped size 479 649 216 Bytes 479 649 408 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pnv1 pnv1 enabled auto-merge (squash) March 3, 2025 13:03
@pnv1 pnv1 merged commit b3e0a1f into ydb-platform:main Mar 3, 2025
15 checks passed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants