Skip to content

At the start of a partition, the order of messages may change. (#15160) #15194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

Move changes from #15160

The partition actor puts messages in the queue until it enters the StateIdle state. Then he sends himself these messages again. There may be a situation when new messages will be processed before the accumulated ones.

#15070

Changelog category

  • Bugfix

Description for reviewers

Message processing rule:

  • in the StateInit state, messages are queued up in the PendingEvents queue.
  • in the StateIdle state, messages are processed immediately if the queue is empty and queued otherwise.

After switching from StateInit to StateIdle, all messages in the queue are processed.

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner February 28, 2025 11:56
Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 11:59:17 UTC Pre-commit check for 724507a has started.
2025-02-28 12:01:53 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2025-02-28 12:06:06 UTC Build failed. see the build logs.
🔴 2025-02-28 12:06:07 UTC Tests run skipped.

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 11:59:22 UTC Pre-commit check for 724507a has started.
2025-02-28 12:02:06 UTC Build linux-x86_64-release-asan is running...
🔴 2025-02-28 12:07:44 UTC Build failed. see the build logs.
🔴 2025-02-28 12:07:45 UTC Tests run skipped.

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 12:22:33 UTC Pre-commit check for 6f73099 has started.
2025-02-28 12:25:16 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-28 12:51:09 UTC Build successful.
2025-02-28 12:51:30 UTC Tests are running...
🔴 2025-02-28 15:06:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11607 11500 0 41 25 41

🟡 2025-02-28 15:06:48 UTC ydbd size 5.6 GiB changed* by +553.7 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: f291460 merge: 6f73099 diff diff %
ydbd size 6 026 430 064 Bytes 6 026 997 048 Bytes +553.7 KiB +0.009%
ydbd stripped size 1 508 246 272 Bytes 1 508 304 480 Bytes +56.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 12:26:48 UTC Pre-commit check for 6f73099 has started.
2025-02-28 12:29:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-28 13:13:43 UTC Build successful.
2025-02-28 13:13:58 UTC Tests are running...
🔴 2025-02-28 14:44:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16046 14687 0 20 1300 39

🟡 2025-02-28 14:45:33 UTC ydbd size 8.3 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: f291460 merge: 6f73099 diff diff %
ydbd size 8 896 432 144 Bytes 8 897 583 888 Bytes +1.1 MiB +0.013%
ydbd stripped size 484 973 736 Bytes 484 988 776 Bytes +14.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 0a25dc5 into ydb-platform:stable-24-4 Feb 28, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants