Skip to content

If optional is empty, get proper JSON value #15168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

qyryq
Copy link
Collaborator

@qyryq qyryq commented Feb 28, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Fix for SQS-806

Copy link

🟢 2025-02-28 08:10:40 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 08:10:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for c5c685e has started.
2025-02-28 08:11:02 UTC Artifacts will be uploaded here
2025-02-28 08:13:59 UTC ya make is running...
🟡 2025-02-28 09:07:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18911 17558 0 7 1215 131

2025-02-28 09:09:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 09:22:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 79 0 0 0 126

🟢 2025-02-28 09:22:28 UTC Build successful.
🟢 2025-02-28 09:22:50 UTC ydbd size 2.1 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ce94a36 merge: c5c685e diff diff %
ydbd size 2 286 816 688 Bytes 2 286 816 640 Bytes -48 Bytes -0.000%
ydbd stripped size 479 452 800 Bytes 479 452 864 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 08:13:22 UTC Pre-commit check linux-x86_64-release-asan for c5c685e has started.
2025-02-28 08:13:38 UTC Artifacts will be uploaded here
2025-02-28 08:16:33 UTC ya make is running...
🟡 2025-02-28 09:23:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11646 11472 0 114 25 35

2025-02-28 09:25:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 09:46:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
244 (only retried tests) 203 0 9 0 32

2025-02-28 09:46:15 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 09:57:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 45 0 0 0 29

🟢 2025-02-28 09:57:18 UTC Build successful.
🟢 2025-02-28 09:57:49 UTC ydbd size 3.7 GiB changed* by +448 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: ce94a36 merge: c5c685e diff diff %
ydbd size 3 985 651 168 Bytes 3 985 651 616 Bytes +448 Bytes +0.000%
ydbd stripped size 1 387 843 176 Bytes 1 387 843 176 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Feb 28, 2025
Copy link

github-actions bot commented Mar 3, 2025

2025-03-03 06:48:34 UTC Pre-commit check linux-x86_64-release-asan for 34dbc13 has started.
2025-03-03 06:48:48 UTC Artifacts will be uploaded here
2025-03-03 06:51:31 UTC ya make is running...
🟡 2025-03-03 08:00:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11605 11459 0 85 24 37

2025-03-03 08:01:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 08:16:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 165 0 4 5 34

2025-03-03 08:16:34 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 08:28:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 34 0 0 6 31

🟢 2025-03-03 08:28:55 UTC Build successful.
🟢 2025-03-03 08:29:21 UTC ydbd size 3.7 GiB changed* by +384 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0bd8f9 merge: 34dbc13 diff diff %
ydbd size 3 988 298 944 Bytes 3 988 299 328 Bytes +384 Bytes +0.000%
ydbd stripped size 1 388 482 184 Bytes 1 388 482 120 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 3, 2025

2025-03-03 06:48:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 34dbc13 has started.
2025-03-03 06:48:49 UTC Artifacts will be uploaded here
2025-03-03 06:51:32 UTC ya make is running...
🟡 2025-03-03 07:37:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18873 17518 0 3 1217 135

2025-03-03 07:38:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 07:50:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
206 (only retried tests) 79 0 0 0 127

🟢 2025-03-03 07:50:12 UTC Build successful.
🟢 2025-03-03 07:50:29 UTC ydbd size 2.1 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b0bd8f9 merge: 34dbc13 diff diff %
ydbd size 2 288 336 672 Bytes 2 288 336 624 Bytes -48 Bytes -0.000%
ydbd stripped size 479 642 688 Bytes 479 642 752 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 3, 2025

2025-03-03 15:12:08 UTC Pre-commit check linux-x86_64-release-asan for 81c83ad has started.
2025-03-03 15:12:24 UTC Artifacts will be uploaded here
2025-03-03 15:15:07 UTC ya make is running...
🟡 2025-03-03 16:20:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11612 11434 0 120 21 37

2025-03-03 16:22:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 16:36:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
235 (only retried tests) 193 0 12 1 29

2025-03-03 16:36:59 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 16:48:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72 (only retried tests) 44 0 0 0 28

🟢 2025-03-03 16:48:55 UTC Build successful.
🟢 2025-03-03 16:49:23 UTC ydbd size 3.7 GiB changed* by +448 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 55bb8ab merge: 81c83ad diff diff %
ydbd size 3 989 365 008 Bytes 3 989 365 456 Bytes +448 Bytes +0.000%
ydbd stripped size 1 388 709 288 Bytes 1 388 709 288 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 3, 2025

2025-03-03 15:12:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 81c83ad has started.
2025-03-03 15:12:29 UTC Artifacts will be uploaded here
2025-03-03 15:15:26 UTC ya make is running...
🟡 2025-03-03 16:03:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18880 17524 0 2 1217 137

2025-03-03 16:05:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 16:18:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 83 0 0 0 126

🟢 2025-03-03 16:18:31 UTC Build successful.
🟢 2025-03-03 16:18:50 UTC ydbd size 2.1 GiB changed* by +68.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c30a288 merge: 81c83ad diff diff %
ydbd size 2 288 892 584 Bytes 2 288 962 168 Bytes +68.0 KiB +0.003%
ydbd stripped size 479 706 112 Bytes 479 716 288 Bytes +9.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@qyryq qyryq merged commit 312918a into ydb-platform:main Mar 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants