Skip to content

Add UNAUTHORIZED status to dq #15138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2025
Merged

Add UNAUTHORIZED status to dq #15138

merged 3 commits into from
Mar 1, 2025

Conversation

kunga
Copy link
Member

@kunga kunga commented Feb 27, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

In order to correctly pass unauthorised status from Sys View scan we need it to be handled in Dq

https://github.com/kunga/ydb/blob/750a898378619f7cd0cbede30cd9c1c4db54b850/ydb/core/kqp/compute_actor/kqp_pure_compute_actor.cpp#L286

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

🟢 2025-02-27 12:46:50 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

⚪ 2025-02-27 12:43:20 UTC Pre-commit check linux-x86_64-release-asan for 30ab23b has started.
⚪ 2025-02-27 12:43:35 UTC Artifacts will be uploaded here
⚪ 2025-02-27 12:46:47 UTC ya make is running...
🟡 2025-02-27 14:29:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13867 13728 0 80 26 33

⚪ 2025-02-27 14:31:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-27 14:45:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 144 0 7 0 30

⚪ 2025-02-27 14:45:23 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-27 14:57:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 37 0 2 0 28

🟢 2025-02-27 14:57:24 UTC Build successful.
🟢 2025-02-27 14:58:01 UTC ydbd size 3.7 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3875124 merge: 30ab23b diff diff %
ydbd size 3 985 410 960 Bytes 3 985 410 912 Bytes -48 Bytes -0.000%
ydbd stripped size 1 387 765 512 Bytes 1 387 765 448 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

⚪ 2025-02-27 12:44:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 30ab23b has started.
⚪ 2025-02-27 12:45:14 UTC Artifacts will be uploaded here
⚪ 2025-02-27 12:48:56 UTC ya make is running...
🟢 2025-02-27 14:15:33 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28272 25658 0 0 2474 140

🟢 2025-02-27 14:18:07 UTC Build successful.
🟢 2025-02-27 14:18:22 UTC ydbd size 2.1 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3875124 merge: 30ab23b diff diff %
ydbd size 2 286 685 128 Bytes 2 286 685 176 Bytes +48 Bytes +0.000%
ydbd stripped size 479 417 824 Bytes 479 417 824 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga self-assigned this Feb 27, 2025
@kunga kunga marked this pull request as ready for review February 28, 2025 08:54
@kunga kunga requested review from a team as code owners February 28, 2025 08:54
@kunga kunga requested a review from ijon February 28, 2025 08:55
@kunga kunga force-pushed the sysview-fix-unathorized branch from 750a898 to faddba9 Compare February 28, 2025 09:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 09:45:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for ab2149c has started.
⚪ 2025-02-28 09:45:40 UTC Artifacts will be uploaded here
⚪ 2025-02-28 09:48:48 UTC ya make is running...
🟡 2025-02-28 11:12:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28302 25689 0 2 2475 136

⚪ 2025-02-28 11:15:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 11:32:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 91 0 0 0 125

🟢 2025-02-28 11:32:39 UTC Build successful.
🟢 2025-02-28 11:32:57 UTC ydbd size 2.1 GiB changed* by +32 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c9aaad0 merge: ab2149c diff diff %
ydbd size 2 287 416 488 Bytes 2 287 416 520 Bytes +32 Bytes +0.000%
ydbd stripped size 479 527 968 Bytes 479 527 968 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 09:45:37 UTC Pre-commit check linux-x86_64-release-asan for ab2149c has started.
⚪ 2025-02-28 09:45:52 UTC Artifacts will be uploaded here
⚪ 2025-02-28 09:49:11 UTC ya make is running...
🟡 2025-02-28 11:42:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13890 13705 0 112 37 36

⚪ 2025-02-28 11:44:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 11:59:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
262 (only retried tests) 214 0 13 3 32

⚪ 2025-02-28 11:59:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 12:11:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
82 (only retried tests) 51 0 0 0 31

🟢 2025-02-28 12:11:41 UTC Build successful.
🟢 2025-02-28 12:12:13 UTC ydbd size 3.7 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c9aaad0 merge: ab2149c diff diff %
ydbd size 3 986 714 288 Bytes 3 986 714 240 Bytes -48 Bytes -0.000%
ydbd stripped size 1 388 109 640 Bytes 1 388 109 576 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

ijon
ijon previously approved these changes Feb 28, 2025
View reviewed changes
@ijon ijon linked an issue Feb 28, 2025 that may be closed by this pull request
Only cluster admin can access auth system views inside database #14234
Closed
@ijon ijon mentioned this pull request Feb 28, 2025
Merged
spuchin
spuchin previously approved these changes Feb 28, 2025
View reviewed changes
vitstn
vitstn reviewed Feb 28, 2025
View reviewed changes
@kunga kunga dismissed stale reviews from spuchin and ijon via 8a8b77d February 28, 2025 14:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 14:37:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 38b949a has started.
⚪ 2025-02-28 14:37:22 UTC Artifacts will be uploaded here
⚪ 2025-02-28 14:40:32 UTC ya make is running...
🟡 2025-02-28 16:08:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28269 25662 0 1 2466 140

⚪ 2025-02-28 16:10:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 16:22:43 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 87 0 0 0 125

🟢 2025-02-28 16:22:53 UTC Build successful.
🟢 2025-02-28 16:23:14 UTC ydbd size 2.1 GiB changed* by +176 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 29480bd merge: 38b949a diff diff %
ydbd size 2 287 542 840 Bytes 2 287 543 016 Bytes +176 Bytes +0.000%
ydbd stripped size 479 560 096 Bytes 479 560 160 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 14:37:19 UTC Pre-commit check linux-x86_64-release-asan for 38b949a has started.
⚪ 2025-02-28 14:37:34 UTC Artifacts will be uploaded here
⚪ 2025-02-28 14:40:43 UTC ya make is running...
🟡 2025-02-28 16:24:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13855 13653 0 146 18 38

⚪ 2025-02-28 16:25:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 16:39:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
259 (only retried tests) 220 0 5 3 31

⚪ 2025-02-28 16:39:44 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 16:51:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 35 0 0 1 31

🟢 2025-02-28 16:51:56 UTC Build successful.
🟢 2025-02-28 16:52:30 UTC ydbd size 3.7 GiB changed* by +112 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 29480bd merge: 38b949a diff diff %
ydbd size 3 986 929 288 Bytes 3 986 929 400 Bytes +112 Bytes +0.000%
ydbd stripped size 1 388 172 104 Bytes 1 388 172 104 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga requested review from ijon and spuchin February 28, 2025 14:39
@kunga kunga merged commit a697f06 into ydb-platform:main Mar 1, 2025
12 checks passed
ijon pushed a commit to ijon/ydb that referenced this pull request Mar 3, 2025
@kunga @ijon
Add UNAUTHORIZED status to dq (ydb-platform#15138)
bea8a4e
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@kunga
Add UNAUTHORIZED status to dq (ydb-platform#15138)
0dc024a
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@kunga kunga mentioned this pull request Mar 11, 2025
Closed
19 tasks
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@kunga @blinkov
Add UNAUTHORIZED status to dq (#15138)
b170782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

@spuchin spuchin spuchin approved these changes

@vitstn vitstn vitstn approved these changes

Assignees

@kunga kunga

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only cluster admin can access auth system views inside database
4 participants
@kunga @ijon @spuchin @vitstn