-
Notifications
You must be signed in to change notification settings - Fork 694
scan compilation has been fixed #15097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 Only one category can be selected at a time. |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а можешь более точечно сделать обработку исключения и noexcept на функцию повесить?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а можешь более точечно сделать обработку исключения и noexcept на функцию повесить?
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Поправил. Единственное конечно yql любит исключения выкидывать, например в yq пришли к тому что прямо на уровне диспатчинга handle просто все исключения стали отлавливать: https://a.yandex-team.ru/arcadia/contrib/ydb/core/fq/libs/actors/run_actor.cpp?rev=r16004537#L411-418 В целом это конкретное исключение закрывает мою боль, переделал. Если другие выскочат, то уже можно подумать про ... |
Олег, я имел в виду не тип исключения, а область из которой исключение может вылететь. тип - тоже, хорошо, но это не обязательно, и опасно - поскольку никто не расширит список перехватываемых типов при добавлении внутри функции нового кода. noexcept позволит это заметить, но хотелось бы до этого не доводить. тем более, что разные исключения мы будем одинаково обрабатывать. сейчас у тебя try/catch на всю секцию кода стоит, хотя исключение бросается только одной функцией. если функция отдает Conclusion, то она должна быть noexcept (к сожалению, на уровне компиляции это не контролируется). то есть, тебе нужно поставить try/catch так, чтобы это правило, просто, выполнилось. |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
KernelsRegistry.Parse(programProto.GetKernels()); | ||
} | ||
if (programProto.HasKernels()) { | ||
if (!KernelsRegistry.Parse(programProto.GetKernels())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
если эта функция бросает exception, то оберни только ее в try catch, пожалуйста
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Changelog category
Description for reviewers
...