Skip to content

scan compilation has been fixed #15097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2025
Merged

Conversation

dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Feb 26, 2025

Changelog entry

  1. Из Complete транзакции не должны вылетать исключения. Так-как TSeat в Complete noexcept. Поэтому выброс исключения из Complete приводит к terminate.
  2. Исключение может появлять на компиляции запроса, пример такой ошибки это отсутствие udf модуля:
(NKikimr::NMiniKQL::TTerminateException) Terminate was called, reason(105): <main>:8:28: Failed to find UDF function Json2.CompilePath, reason: Error: Module Json2 is not registered.

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@dorooleg dorooleg requested a review from a team as a code owner February 26, 2025 22:47
@dorooleg dorooleg linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 26, 2025

🔴 2025-02-27 10:48:21 UTC The validation of the Pull Request description has failed. Please update the description.

Only one category can be selected at a time.

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 22:50:52 UTC Pre-commit check linux-x86_64-release-asan for 156912c has started.
2025-02-26 22:51:06 UTC Artifacts will be uploaded here
2025-02-26 22:53:53 UTC ya make is running...
🟡 2025-02-26 23:57:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11589 11413 0 121 23 32

2025-02-26 23:58:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-27 00:13:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
239 (only retried tests) 203 0 9 0 27

2025-02-27 00:13:14 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-27 00:24:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 39 0 2 0 27

🟢 2025-02-27 00:24:09 UTC Build successful.
🟢 2025-02-27 00:24:39 UTC ydbd size 3.7 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3f91ea9 merge: 156912c diff diff %
ydbd size 3 982 568 752 Bytes 3 982 570 672 Bytes +1.9 KiB +0.000%
ydbd stripped size 1 387 152 008 Bytes 1 387 152 648 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 22:53:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 156912c has started.
2025-02-26 22:53:41 UTC Artifacts will be uploaded here
2025-02-26 22:56:34 UTC ya make is running...
🟡 2025-02-26 23:45:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18849 17497 0 6 1214 132

2025-02-26 23:46:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 23:57:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 78 0 0 0 125

🟢 2025-02-26 23:57:44 UTC Build successful.
🟢 2025-02-26 23:58:04 UTC ydbd size 2.1 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3f91ea9 merge: 156912c diff diff %
ydbd size 2 284 939 552 Bytes 2 284 940 640 Bytes +1.1 KiB +0.000%
ydbd stripped size 479 225 376 Bytes 479 225 632 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg added bug Something isn't working and removed new-feature labels Feb 28, 2025
Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 06:40:58 UTC Pre-commit check linux-x86_64-release-asan for 487fcd6 has started.
2025-02-28 06:41:30 UTC Artifacts will be uploaded here
2025-02-28 06:44:54 UTC ya make is running...
🟡 2025-02-28 07:58:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11592 11433 0 105 21 33

2025-02-28 07:59:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 08:13:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 186 0 3 0 29

2025-02-28 08:13:46 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 08:18:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 33 0 0 0 27

🟢 2025-02-28 08:19:00 UTC Build successful.
🟢 2025-02-28 08:19:37 UTC ydbd size 3.7 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ce94a36 merge: 487fcd6 diff diff %
ydbd size 3 985 651 168 Bytes 3 985 653 088 Bytes +1.9 KiB +0.000%
ydbd stripped size 1 387 843 176 Bytes 1 387 843 816 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 06:40:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 487fcd6 has started.
2025-02-28 06:41:13 UTC Artifacts will be uploaded here
2025-02-28 06:44:03 UTC ya make is running...
🟡 2025-02-28 07:44:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18857 17486 0 11 1227 133

2025-02-28 07:46:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 07:59:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
225 (only retried tests) 96 0 1 0 128

2025-02-28 07:59:52 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-28 08:12:31 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 64 0 1 0 127

🟢 2025-02-28 08:12:38 UTC Build successful.
🟢 2025-02-28 08:13:00 UTC ydbd size 2.1 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ce94a36 merge: 487fcd6 diff diff %
ydbd size 2 286 816 688 Bytes 2 286 817 776 Bytes +1.1 KiB +0.000%
ydbd stripped size 479 452 800 Bytes 479 453 056 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а можешь более точечно сделать обработку исключения и noexcept на функцию повесить?

Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а можешь более точечно сделать обработку исключения и noexcept на функцию повесить?

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 09:25:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for a5175ae has started.
2025-02-28 09:25:29 UTC Artifacts will be uploaded here
2025-02-28 09:28:26 UTC ya make is running...
🟡 2025-02-28 10:16:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18860 17508 0 2 1216 134

2025-02-28 10:18:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 10:32:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
202 (only retried tests) 74 0 1 0 127

2025-02-28 10:32:22 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-28 10:49:32 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 63 0 1 0 126

🟢 2025-02-28 10:49:46 UTC Build successful.
🟢 2025-02-28 10:50:08 UTC ydbd size 2.1 GiB changed* by +5.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6ab1b9 merge: a5175ae diff diff %
ydbd size 2 287 416 488 Bytes 2 287 422 104 Bytes +5.5 KiB +0.000%
ydbd stripped size 479 527 968 Bytes 479 532 384 Bytes +4.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 09:26:50 UTC Pre-commit check linux-x86_64-release-asan for a5175ae has started.
2025-02-28 09:27:07 UTC Artifacts will be uploaded here
2025-02-28 09:30:01 UTC ya make is running...
🟡 2025-02-28 10:39:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11594 11408 0 113 35 38

2025-02-28 10:40:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 10:56:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
251 (only retried tests) 209 0 11 0 31

2025-02-28 10:56:36 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 11:07:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72 (only retried tests) 44 0 0 0 28

🟢 2025-02-28 11:07:42 UTC Build successful.
🟢 2025-02-28 11:08:13 UTC ydbd size 3.7 GiB changed* by +2.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6ab1b9 merge: a5175ae diff diff %
ydbd size 3 986 714 288 Bytes 3 986 716 840 Bytes +2.5 KiB +0.000%
ydbd stripped size 1 388 109 640 Bytes 1 388 110 408 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg
Copy link
Collaborator Author

dorooleg commented Feb 28, 2025

а можешь более точечно сделать обработку исключения и noexcept на функцию повесить?

Поправил. Единственное конечно yql любит исключения выкидывать, например в yq пришли к тому что прямо на уровне диспатчинга handle просто все исключения стали отлавливать: https://a.yandex-team.ru/arcadia/contrib/ydb/core/fq/libs/actors/run_actor.cpp?rev=r16004537#L411-418 В целом это конкретное исключение закрывает мою боль, переделал. Если другие выскочат, то уже можно подумать про ...

@ivanmorozov333
Copy link
Collaborator

Олег, я имел в виду не тип исключения, а область из которой исключение может вылететь. тип - тоже, хорошо, но это не обязательно, и опасно - поскольку никто не расширит список перехватываемых типов при добавлении внутри функции нового кода. noexcept позволит это заметить, но хотелось бы до этого не доводить. тем более, что разные исключения мы будем одинаково обрабатывать. сейчас у тебя try/catch на всю секцию кода стоит, хотя исключение бросается только одной функцией. если функция отдает Conclusion, то она должна быть noexcept (к сожалению, на уровне компиляции это не контролируется). то есть, тебе нужно поставить try/catch так, чтобы это правило, просто, выполнилось.

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 13:20:21 UTC Pre-commit check linux-x86_64-release-asan for 3ff1227 has started.
2025-03-07 13:20:35 UTC Artifacts will be uploaded here
2025-03-07 13:21:58 UTC Check cancelled

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 13:26:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for f6371ca has started.
2025-03-07 13:27:10 UTC Artifacts will be uploaded here
2025-03-07 13:30:26 UTC ya make is running...
🟡 2025-03-07 14:36:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26524 23942 0 2 2465 115

2025-03-07 14:38:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 14:50:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 55 0 1 0 106

2025-03-07 14:51:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 15:11:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
150 (only retried tests) 45 0 0 0 105

🟢 2025-03-07 15:11:21 UTC Build successful.
🟢 2025-03-07 15:11:42 UTC ydbd size 2.1 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e4821cc merge: f6371ca diff diff %
ydbd size 2 294 621 968 Bytes 2 294 626 192 Bytes +4.1 KiB +0.000%
ydbd stripped size 480 593 312 Bytes 480 593 824 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 13:28:17 UTC Pre-commit check linux-x86_64-release-asan for f6371ca has started.
2025-03-07 13:28:31 UTC Artifacts will be uploaded here
2025-03-07 13:31:20 UTC ya make is running...
🟡 2025-03-07 14:45:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12165 11985 0 126 17 37

2025-03-07 14:46:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 15:00:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
232 (only retried tests) 191 0 4 7 30

2025-03-07 15:00:27 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 15:12:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 34 0 0 7 28

🟢 2025-03-07 15:13:03 UTC Build successful.
🟢 2025-03-07 15:13:31 UTC ydbd size 3.7 GiB changed* by +7.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e4821cc merge: f6371ca diff diff %
ydbd size 3 996 097 640 Bytes 3 996 105 280 Bytes +7.5 KiB +0.000%
ydbd stripped size 1 389 147 400 Bytes 1 389 149 000 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

KernelsRegistry.Parse(programProto.GetKernels());
}
if (programProto.HasKernels()) {
if (!KernelsRegistry.Parse(programProto.GetKernels())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

если эта функция бросает exception, то оберни только ее в try catch, пожалуйста

Copy link

github-actions bot commented Mar 8, 2025

2025-03-08 09:06:34 UTC Pre-commit check linux-x86_64-release-asan for f27aa4d has started.
2025-03-08 09:06:48 UTC Artifacts will be uploaded here
2025-03-08 09:09:41 UTC ya make is running...
🟡 2025-03-08 10:29:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12169 11933 0 176 25 35

2025-03-08 10:30:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-08 10:46:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
296 (only retried tests) 258 0 6 0 32

2025-03-08 10:46:35 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-08 10:58:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 40 0 0 0 29

🟢 2025-03-08 10:58:41 UTC Build successful.
🟡 2025-03-08 10:59:10 UTC ydbd size 3.7 GiB changed* by +348.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c7ef100 merge: f27aa4d diff diff %
ydbd size 3 996 187 888 Bytes 3 996 544 904 Bytes +348.6 KiB +0.009%
ydbd stripped size 1 389 175 240 Bytes 1 389 195 112 Bytes +19.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 8, 2025

2025-03-08 09:07:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for f27aa4d has started.
2025-03-08 09:07:19 UTC Artifacts will be uploaded here
2025-03-08 09:10:06 UTC ya make is running...
🟡 2025-03-08 10:15:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26547 23966 0 4 2466 111

2025-03-08 10:17:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-08 10:29:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
156 (only retried tests) 49 0 1 0 106

2025-03-08 10:29:53 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-08 10:41:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
149 (only retried tests) 44 0 0 0 105

🟢 2025-03-08 10:42:04 UTC Build successful.
🟡 2025-03-08 10:42:24 UTC ydbd size 2.1 GiB changed* by +172.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c7ef100 merge: f27aa4d diff diff %
ydbd size 2 294 683 704 Bytes 2 294 860 176 Bytes +172.3 KiB +0.008%
ydbd stripped size 480 604 736 Bytes 480 611 392 Bytes +6.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg enabled auto-merge (squash) March 8, 2025 09:52
@dorooleg dorooleg merged commit cc84759 into ydb-platform:main Mar 8, 2025
12 checks passed
@dorooleg dorooleg deleted the compliation_fix branch March 8, 2025 10:59
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Падение в Execute TTxScan
2 participants