Get topic data handler #15038
Get topic data handler #15038
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| Die(ActorContext()); | ||
| return; | ||
| } | ||
| setData(jsonRecord, std::move(codec->Decompress(dataChunk.GetData()))); |
There was a problem hiding this comment.
Trim long records here too
There was a problem hiding this comment.
They are trimmed in setData func already
| if (response.HasCmdReadResult()) { | ||
| const auto& readResult = response.GetCmdReadResult(); | ||
| if (readResult.GetReadingFinished()) { | ||
| ReplyAndPassAwayIfAlive(GetHTTPBADREQUEST("text/plain", "Bad Partition id")); |
There was a problem hiding this comment.
Why this response status?
There was a problem hiding this comment.
Desided to keep BAD_REQUEST as has code 400 and we can provide error details in response (while we can't with NOT_FOUND response in current implementation).
FloatingCrowbar
force-pushed
the
topic_handler
branch
from
f0e9cd7 to
04eb160
Compare
|
⚪ |
|
⚪ |
FloatingCrowbar
force-pushed
the
topic_handler
branch
2 times, most recently
from
df059b3 to
80b3c03
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟡
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
FloatingCrowbar
dismissed stale reviews from niksaveliev and StekPerepolnen
via
03df290
FloatingCrowbar
force-pushed
the
topic_handler
branch
from
487900d to
03df290
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
This reverts commit 85ef15c.
Changelog entry
Get topic data handler for UI.
Changelog category
Description for reviewers
...