Skip to content

Set to use antlr4 #15005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

Set to use antlr4 #15005

merged 2 commits into from
Feb 26, 2025

Conversation

buhtr
Copy link
Collaborator

@buhtr buhtr commented Feb 25, 2025 •
edited
Loading

Changelog entry

Start to use antlr4 by default.

Changelog category

  • Improvement

Description for reviewers

The compile_service.cpp and the run_actor.cpp has been changed to use antlr4.

@buhtr buhtr requested a review from a team as a code owner February 25, 2025 13:00
@github-actions GitHub Actions
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🟢 2025-02-25 13:04:08 UTC The validation of the Pull Request description is successful.

@yumkam yumkam added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 25, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 13:13:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9419cca has started.
⚪ 2025-02-25 13:13:49 UTC Artifacts will be uploaded here
⚪ 2025-02-25 13:16:36 UTC ya make is running...
🟡 2025-02-25 14:15:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25606 23006 0 4 2461 135

⚪ 2025-02-25 14:17:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 14:35:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 72 0 1 3 127

⚪ 2025-02-25 14:35:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 14:57:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 66 0 0 0 125

🟢 2025-02-25 14:57:44 UTC Build successful.
🟢 2025-02-25 14:58:05 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9029d02 merge: 9419cca diff diff %
ydbd size 2 243 209 832 Bytes 2 243 209 832 Bytes 0 Bytes 0.000%
ydbd stripped size 474 901 528 Bytes 474 901 528 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 13:15:09 UTC Pre-commit check linux-x86_64-release-asan for 9419cca has started.
⚪ 2025-02-25 13:15:22 UTC Artifacts will be uploaded here
⚪ 2025-02-25 13:18:08 UTC ya make is running...
🟡 2025-02-25 14:15:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11482 11397 0 24 28 33

⚪ 2025-02-25 14:16:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 14:29:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 83 0 0 9 31

🟢 2025-02-25 14:29:23 UTC Build successful.
🟢 2025-02-25 14:29:51 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9029d02 merge: 9419cca diff diff %
ydbd size 3 900 116 896 Bytes 3 900 116 800 Bytes -96 Bytes -0.000%
ydbd stripped size 1 365 335 376 Bytes 1 365 335 312 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 26, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 08:32:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa6b485 has started.
⚪ 2025-02-26 08:32:29 UTC Artifacts will be uploaded here
⚪ 2025-02-26 08:35:34 UTC ya make is running...
🟡 2025-02-26 09:50:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25607 23008 0 2 2460 137

⚪ 2025-02-26 09:53:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 10:06:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
201 (only retried tests) 71 0 0 1 129

🟢 2025-02-26 10:06:23 UTC Build successful.
🟢 2025-02-26 10:06:45 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a378163 merge: fa6b485 diff diff %
ydbd size 2 263 579 104 Bytes 2 263 579 104 Bytes 0 Bytes 0.000%
ydbd stripped size 477 117 880 Bytes 477 117 880 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 08:33:57 UTC Pre-commit check linux-x86_64-release-asan for fa6b485 has started.
⚪ 2025-02-26 08:34:11 UTC Artifacts will be uploaded here
⚪ 2025-02-26 08:37:07 UTC ya make is running...
🟡 2025-02-26 09:36:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11483 11415 0 22 14 32

⚪ 2025-02-26 09:37:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 09:50:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 66 0 0 5 30

🟢 2025-02-26 09:50:36 UTC Build successful.
🟢 2025-02-26 09:51:01 UTC ydbd size 3.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a378163 merge: fa6b485 diff diff %
ydbd size 3 942 835 520 Bytes 3 942 835 424 Bytes -96 Bytes -0.000%
ydbd stripped size 1 374 042 544 Bytes 1 374 042 480 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam merged commit c5a7f78 into ydb-platform:main Feb 26, 2025
15 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@buhtr
Set to use antlr4 (ydb-platform#15005)
54231e6 
Co-authored-by: Igor Sliusarenko <s2m1@localhost.localdomain>
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@buhtr @blinkov
Set to use antlr4 (#15005)
b964c40 
Co-authored-by: Igor Sliusarenko <s2m1@localhost.localdomain>
vitalyisaev2 pushed a commit to vitalyisaev2/ydb that referenced this pull request Aug 18, 2025
@buhtr @vitalyisaev2
Set to use antlr4 (ydb-platform#15005)
370dca1 
Co-authored-by: Igor Sliusarenko <s2m1@localhost.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

Assignees
No one assigned
Labels
external improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buhtr @uzhastik @yumkam