Skip to content

[KIKIMR-22738] (=) split ydb/core/control circular dependencies with ydb/core/base #14972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

lberserq
Copy link
Contributor

@lberserq lberserq commented Feb 24, 2025

Changelog entry

Split dependencies between ydb/core/control and ydb/core/base. It's a prerequsite for KIKIMR-18466
...

Changelog category

  • Improvement

Description for reviewers

  • Split dependencies between ydb/core/control and ydb/core/base TControlBoard<=>TAppData
  • Add proxy header ydb/core/control/immediate_control_board_impl.h for acadia files compatibility
    ...

@lberserq lberserq requested review from a team as code owners February 24, 2025 18:07
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

Copy link

github-actions bot commented Feb 24, 2025

🟢 2025-02-24 18:22:26 UTC The validation of the Pull Request description is successful.

@the-ancient-1 the-ancient-1 enabled auto-merge (squash) February 28, 2025 17:47
@the-ancient-1 the-ancient-1 added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 28, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 28, 2025
Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 17:54:04 UTC Pre-commit check linux-x86_64-release-asan for 0cf0678 has started.
2025-02-28 17:54:20 UTC Artifacts will be uploaded here
2025-02-28 17:57:31 UTC ya make is running...
🟡 2025-02-28 19:38:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13624 13475 0 81 29 39

2025-02-28 19:39:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 19:53:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 165 0 7 1 31

2025-02-28 19:53:34 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 20:05:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 38 0 0 0 29

🟢 2025-02-28 20:05:25 UTC Build successful.
🟢 2025-02-28 20:05:54 UTC ydbd size 3.7 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: bf4f55b merge: 0cf0678 diff diff %
ydbd size 3 986 933 872 Bytes 3 986 933 808 Bytes -64 Bytes -0.000%
ydbd stripped size 1 388 172 936 Bytes 1 388 172 872 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 28, 2025

2025-03-01 15:43:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0cf0678 has started.
2025-03-01 15:43:44 UTC Artifacts will be uploaded here
2025-03-01 15:46:50 UTC ya make is running...
🟡 2025-03-01 17:12:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28007 25402 0 2 2466 137

2025-03-01 17:15:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-01 17:26:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 83 0 1 0 126

2025-03-01 17:26:52 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-01 17:37:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 66 0 0 0 124

🟢 2025-03-01 17:37:41 UTC Build successful.
🟢 2025-03-01 17:38:01 UTC ydbd size 2.1 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: 0cf0678 diff diff %
ydbd size 2 287 545 688 Bytes 2 287 545 736 Bytes +48 Bytes +0.000%
ydbd stripped size 479 560 352 Bytes 479 560 352 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

auto-merge was automatically disabled March 1, 2025 17:38

Invalid email address

@the-ancient-1 the-ancient-1 merged commit 22b98a2 into ydb-platform:main Mar 1, 2025
19 of 21 checks passed
lberserq added a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
…platform#14972), KIKIMR-22738

Co-authored-by: Kamil Khamitov <kkhamitov@yandex-team.ru>
blinkov pushed a commit that referenced this pull request Mar 21, 2025
…), KIKIMR-22738

Co-authored-by: Kamil Khamitov <kkhamitov@yandex-team.ru>
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Mar 24, 2025
…platform#14972), KIKIMR-22738

Co-authored-by: Kamil Khamitov <kkhamitov@yandex-team.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants