Skip to content

Implement dual-config mode for distconf #14825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Feb 20, 2025

Changelog entry

Implement dual-config mode for distconf

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Dual-config mode is now fully supported through distconf/BSC and in NW on startup too.

@alexvru alexvru requested a review from a team as a code owner February 20, 2025 08:26
@alexvru alexvru requested a review from vporyadke February 20, 2025 08:26
@alexvru alexvru marked this pull request as draft February 20, 2025 08:26
Copy link

🟢 2025-02-20 08:27:49 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 08:30:26 UTC Pre-commit check linux-x86_64-release-asan for f693dfb has started.
2025-02-20 08:46:20 UTC Artifacts will be uploaded here
2025-02-20 08:49:28 UTC ya make is running...
🟡 2025-02-20 10:22:17 UTC ydbd size 3.6 GiB changed* by +132.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b52dd35 merge: f693dfb diff diff %
ydbd size 3 895 494 680 Bytes 3 895 630 016 Bytes +132.2 KiB +0.003%
ydbd stripped size 1 364 017 440 Bytes 1 364 052 800 Bytes +34.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-20 10:22:19 UTC Check cancelled

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 08:31:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for f693dfb has started.
2025-02-20 08:31:42 UTC Artifacts will be uploaded here
2025-02-20 08:35:03 UTC ya make is running...
🟡 2025-02-20 10:12:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28038 25424 0 1 2468 145

2025-02-20 10:15:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 10:22:04 UTC ydbd size 2.1 GiB changed* by +80.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b52dd35 merge: f693dfb diff diff %
ydbd size 2 239 406 280 Bytes 2 239 488 776 Bytes +80.6 KiB +0.004%
ydbd stripped size 474 530 296 Bytes 474 545 016 Bytes +14.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-20 10:22:06 UTC Check cancelled

@alexvru alexvru force-pushed the distconf/dual-config-mode-impl branch from a7914d5 to a367abd Compare February 20, 2025 10:21
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 10:24:19 UTC Pre-commit check linux-x86_64-release-asan for a9e4bad has started.
2025-02-20 10:24:28 UTC Artifacts will be uploaded here
2025-02-20 10:27:47 UTC ya make is running...
🟡 2025-02-20 11:32:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13800 13709 0 42 12 37

2025-02-20 11:33:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 11:58:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
137 (only retried tests) 99 0 0 3 35

🟢 2025-02-20 11:58:47 UTC Build successful.
🟡 2025-02-20 11:59:15 UTC ydbd size 3.6 GiB changed* by +169.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4d7998d merge: a9e4bad diff diff %
ydbd size 3 895 490 664 Bytes 3 895 664 528 Bytes +169.8 KiB +0.004%
ydbd stripped size 1 364 013 408 Bytes 1 364 063 936 Bytes +49.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 10:26:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9e4bad has started.
2025-02-20 10:26:46 UTC Artifacts will be uploaded here
2025-02-20 10:30:00 UTC ya make is running...
🟡 2025-02-20 11:34:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28038 25431 0 6 2460 141

2025-02-20 11:37:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 11:56:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 78 0 0 2 127

🟢 2025-02-20 11:56:20 UTC Build successful.
🟢 2025-02-20 11:56:42 UTC ydbd size 2.1 GiB changed* by +96.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d7998d merge: a9e4bad diff diff %
ydbd size 2 239 406 296 Bytes 2 239 505 472 Bytes +96.9 KiB +0.004%
ydbd stripped size 474 530 296 Bytes 474 549 368 Bytes +18.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru marked this pull request as ready for review February 20, 2025 12:02
@alexvru alexvru enabled auto-merge (squash) February 20, 2025 12:03
@alexvru alexvru merged commit fe62452 into ydb-platform:main Feb 20, 2025
12 checks passed
@alexvru alexvru deleted the distconf/dual-config-mode-impl branch February 20, 2025 12:51
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants