Skip to content

Persist config upon being changed by distconf #14809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Feb 19, 2025

Changelog entry

Persist config upon being changed by distconf

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Configs are now persisted into the config storage directory when updated through distconf mechanism.

Copy link

🟢 2025-02-19 16:19:18 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 19, 2025

2025-02-19 16:21:32 UTC Pre-commit check linux-x86_64-release-asan for 0339d1a has started.
2025-02-19 16:23:17 UTC Artifacts will be uploaded here
2025-02-19 16:26:08 UTC ya make is running...
🟡 2025-02-19 17:31:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12057 11912 0 72 32 41

2025-02-19 17:33:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-19 17:54:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 164 0 3 9 32

2025-02-19 17:55:05 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-19 18:06:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 36 0 0 2 32

🟢 2025-02-19 18:07:05 UTC Build successful.
🟢 2025-02-19 18:07:36 UTC ydbd size 3.6 GiB changed* by +37.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 02fadfa merge: 0339d1a diff diff %
ydbd size 3 894 661 032 Bytes 3 894 698 984 Bytes +37.1 KiB +0.001%
ydbd stripped size 1 363 540 128 Bytes 1 363 548 640 Bytes +8.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) February 19, 2025 16:21
Copy link

github-actions bot commented Feb 19, 2025

2025-02-19 16:23:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0339d1a has started.
2025-02-19 16:23:16 UTC Artifacts will be uploaded here
2025-02-19 16:26:04 UTC ya make is running...
🟡 2025-02-19 17:22:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19369 18005 0 5 1224 135

2025-02-19 17:24:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-19 17:36:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 90 0 0 1 127

🟢 2025-02-19 17:37:09 UTC Build successful.
🟢 2025-02-19 17:37:32 UTC ydbd size 2.1 GiB changed* by +21.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 02fadfa merge: 0339d1a diff diff %
ydbd size 2 238 945 296 Bytes 2 238 967 200 Bytes +21.4 KiB +0.001%
ydbd stripped size 474 411 320 Bytes 474 414 552 Bytes +3.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants