Skip to content

Remove dummy actorsystem config #14782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Feb 19, 2025

Changelog entry

When autoconfig was not assigned, ydbd used a dummy configuration. Now, it is fixed, and ydbd uses autoconfig.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@kruall kruall added the area/actorsystem Actor System related issues label Feb 19, 2025
@kruall kruall requested a review from a team as a code owner February 19, 2025 11:49
@kruall kruall requested a review from CyberROFL February 19, 2025 11:49
Copy link

🟢 2025-02-19 11:52:52 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 19, 2025

2025-02-19 11:59:13 UTC Pre-commit check linux-x86_64-release-asan for fa11192 has started.
2025-02-19 11:59:27 UTC Artifacts will be uploaded here
2025-02-19 12:02:29 UTC ya make is running...
🔴 2025-02-19 14:16:16 UTC Too many tests failed, NOT going to retry
🟡 2025-02-19 14:18:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13437 12455 0 517 419 46

🟢 2025-02-19 14:19:24 UTC Build successful.
🟢 2025-02-19 14:20:12 UTC ydbd size 3.6 GiB changed* by -9.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2872539 merge: fa11192 diff diff %
ydbd size 3 893 387 816 Bytes 3 893 378 160 Bytes -9.4 KiB -0.000%
ydbd stripped size 1 363 137 728 Bytes 1 363 134 848 Bytes -2.8 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 19, 2025

2025-02-19 11:59:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa11192 has started.
2025-02-19 11:59:42 UTC Artifacts will be uploaded here
2025-02-19 12:02:29 UTC ya make is running...
🟡 2025-02-19 13:02:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20756 19402 0 1 1219 134

2025-02-19 13:04:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-19 13:32:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 74 0 0 2 127

🟢 2025-02-19 13:32:49 UTC Build successful.
🟢 2025-02-19 13:33:11 UTC ydbd size 2.1 GiB changed* by -5.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2872539 merge: fa11192 diff diff %
ydbd size 2 238 223 232 Bytes 2 238 217 920 Bytes -5.2 KiB -0.000%
ydbd stripped size 474 291 928 Bytes 474 291 032 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested a review from Enjection February 19, 2025 12:23
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kruall kruall merged commit 8f7f05b into ydb-platform:main Feb 20, 2025
15 of 17 checks passed
@kruall kruall deleted the as/use_autoconfig_when_actor_system_config_isnt_assigned branch February 20, 2025 15:28
Enjection added a commit to Enjection/ydb that referenced this pull request Feb 25, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/actorsystem Actor System related issues not-for-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants