Skip to content

Add assertion for input value in IntervalTo* functions #14762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

Add assertion for input value in IntervalTo* functions #14762

merged 1 commit into from
Feb 19, 2025

Conversation

igormunkin
Copy link
Collaborator

@igormunkin igormunkin commented Feb 18, 2025 •
edited
Loading

This changeset introduces the assertion to be sure that input value fits the TInterval range and make coverity happy.

Changelog category

  • Not for changelog (changelog entry is not required)

@igormunkin igormunkin self-assigned this Feb 18, 2025
@igormunkin igormunkin added the area/yql YQL query language issues label Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 22:13:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6ffbc40 has started.
⚪ 2025-02-18 22:14:48 UTC Artifacts will be uploaded here
⚪ 2025-02-18 22:17:59 UTC ya make is running...
🔴 2025-02-18 22:19:46 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

🟢 2025-02-19 05:21:06 UTC The validation of the Pull Request description is successful.

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 22:19:51 UTC Pre-commit check linux-x86_64-release-asan for 6ffbc40 has started.
⚪ 2025-02-18 22:20:02 UTC Artifacts will be uploaded here
⚪ 2025-02-18 22:22:27 UTC ya make is running...
🟡 2025-02-18 22:54:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1620 1581 0 12 17 10

⚪ 2025-02-18 22:55:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 23:07:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
46 (only retried tests) 34 0 0 5 7

🟢 2025-02-18 23:08:04 UTC Build successful.
🟢 2025-02-18 23:08:21 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a48e948 merge: 6ffbc40 diff diff %
ydbd size 3 892 971 712 Bytes 3 892 971 616 Bytes -96 Bytes -0.000%
ydbd stripped size 1 362 937 728 Bytes 1 362 937 664 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@igormunkin igormunkin force-pushed the YQL-19565-make-coverity-happy-on-datetime-udf branch from 83e4eb2 to b7ec4b8 Compare February 18, 2025 23:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 23:19:49 UTC Pre-commit check linux-x86_64-release-asan for c591ef4 has started.
⚪ 2025-02-18 23:20:01 UTC Artifacts will be uploaded here
⚪ 2025-02-18 23:22:23 UTC ya make is running...
🟡 2025-02-18 23:45:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1620 1596 0 3 11 10

⚪ 2025-02-18 23:45:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 23:57:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30 (only retried tests) 16 0 0 5 9

🟢 2025-02-18 23:57:46 UTC Build successful.
🟢 2025-02-18 23:58:01 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a48e948 merge: c591ef4 diff diff %
ydbd size 3 892 971 712 Bytes 3 892 971 616 Bytes -96 Bytes -0.000%
ydbd stripped size 1 362 937 728 Bytes 1 362 937 664 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 23:19:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for c591ef4 has started.
⚪ 2025-02-18 23:20:04 UTC Artifacts will be uploaded here
⚪ 2025-02-18 23:22:28 UTC ya make is running...
🟢 2025-02-18 23:55:38 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4657 4537 0 0 40 80

🟢 2025-02-18 23:56:04 UTC Build successful.
🟢 2025-02-18 23:56:14 UTC ydbd size 2.1 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a48e948 merge: c591ef4 diff diff %
ydbd size 2 237 664 768 Bytes 2 237 669 264 Bytes +4.4 KiB +0.000%
ydbd stripped size 474 182 680 Bytes 474 186 776 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@igormunkin igormunkin changed the title Add assertion for input value to fit the Interval range Add assertion for input value in IntervalTo* functions Feb 19, 2025
@igormunkin igormunkin marked this pull request as ready for review February 19, 2025 05:22
@igormunkin igormunkin requested a review from a team as a code owner February 19, 2025 05:22
@igormunkin igormunkin force-pushed the YQL-19565-make-coverity-happy-on-datetime-udf branch from b7ec4b8 to c50af67 Compare February 19, 2025 08:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 08:26:40 UTC Pre-commit check linux-x86_64-release-asan for fa7153d has started.
⚪ 2025-02-19 08:26:46 UTC Artifacts will be uploaded here
⚪ 2025-02-19 08:29:15 UTC ya make is running...
🔴 2025-02-19 08:32:46 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 08:36:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa7153d has started.
⚪ 2025-02-19 08:36:29 UTC Artifacts will be uploaded here
⚪ 2025-02-19 08:38:51 UTC ya make is running...
🔴 2025-02-19 08:41:24 UTC Build failed, see the logs. Also see fail summary

@igormunkin igormunkin added the rebase-and-check Rebase PR with the current base branch and check label Feb 19, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 19, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 11:37:50 UTC Pre-commit check linux-x86_64-release-asan for 53f1e8b has started.
⚪ 2025-02-19 12:00:21 UTC Artifacts will be uploaded here
⚪ 2025-02-19 12:02:56 UTC ya make is running...
🔴 2025-02-19 12:06:16 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 11:38:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 53f1e8b has started.
⚪ 2025-02-19 11:38:20 UTC Artifacts will be uploaded here
⚪ 2025-02-19 11:40:41 UTC ya make is running...
🔴 2025-02-19 11:43:24 UTC Build failed, see the logs. Also see fail summary

@igormunkin igormunkin force-pushed the YQL-19565-make-coverity-happy-on-datetime-udf branch from c50af67 to 28584b6 Compare February 19, 2025 15:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 15:35:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a9e350 has started.
⚪ 2025-02-19 15:36:09 UTC Artifacts will be uploaded here
⚪ 2025-02-19 15:38:45 UTC ya make is running...
🟢 2025-02-19 16:18:44 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4659 4521 0 0 51 87

🟢 2025-02-19 16:19:17 UTC Build successful.
🟢 2025-02-19 16:19:28 UTC ydbd size 2.1 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 02fadfa merge: 8a9e350 diff diff %
ydbd size 2 238 945 296 Bytes 2 238 949 792 Bytes +4.4 KiB +0.000%
ydbd stripped size 474 411 320 Bytes 474 415 416 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 15:36:11 UTC Pre-commit check linux-x86_64-release-asan for 8a9e350 has started.
⚪ 2025-02-19 15:36:54 UTC Artifacts will be uploaded here
⚪ 2025-02-19 15:40:03 UTC ya make is running...
🟡 2025-02-19 16:02:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1622 1579 0 10 22 11

⚪ 2025-02-19 16:03:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-19 16:35:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
50 (only retried tests) 39 0 0 3 8

🟢 2025-02-19 16:35:36 UTC Build successful.
🟢 2025-02-19 16:35:52 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 02fadfa merge: 8a9e350 diff diff %
ydbd size 3 894 661 032 Bytes 3 894 660 936 Bytes -96 Bytes -0.000%
ydbd stripped size 1 363 540 128 Bytes 1 363 540 064 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@igormunkin igormunkin merged commit b1f202d into ydb-platform:main Feb 19, 2025
12 checks passed
This was referenced Feb 21, 2025
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@igormunkin
Add assertion for input value in IntervalTo* functions (ydb-platform#…
05cd96b 
…14762)
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@igormunkin igormunkin deleted the YQL-19565-make-coverity-happy-on-datetime-udf branch March 20, 2025 13:22
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@igormunkin @blinkov
Add assertion for input value in IntervalTo* functions (#14762)
3cfdc0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

Assignees

@igormunkin igormunkin

Labels
area/yql YQL query language issues not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igormunkin @vitstn