Skip to content

Fix statement ok assert #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

vgvoleg
Copy link
Collaborator

@vgvoleg vgvoleg commented Feb 18, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Current check relies on bug in python sdk. This commit changed to more straightforward check to assert statement was called without errors

Copy link

github-actions bot commented Feb 18, 2025

🟢 2025-02-18 11:23:42 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 11:20:52 UTC Pre-commit check linux-x86_64-release-asan for e6845ba has started.
2025-02-18 11:21:05 UTC Artifacts will be uploaded here
2025-02-18 11:23:27 UTC ya make is running...
🟢 2025-02-18 11:23:33 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-02-18 11:23:39 UTC Build successful.

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 18, 2025
Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 11:21:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for e6845ba has started.
2025-02-18 11:21:50 UTC Artifacts will be uploaded here
2025-02-18 11:24:11 UTC ya make is running...
🟢 2025-02-18 11:54:00 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 112 0 0 0 1

🟢 2025-02-18 11:54:07 UTC Build successful.
🟡 2025-02-18 11:54:17 UTC ydbd size 2.1 GiB changed* by +258.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0a1a524 merge: e6845ba diff diff %
ydbd size 2 236 147 032 Bytes 2 236 412 048 Bytes +258.8 KiB +0.012%
ydbd stripped size 473 902 008 Bytes 473 936 760 Bytes +33.9 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vgvoleg vgvoleg merged commit 24d8aaa into ydb-platform:main Feb 18, 2025
16 of 18 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants