Fix TEvPatch behaviour #1469
Merged
Fix TEvPatch behaviour #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
Enjection
approved these changes
Jan 31, 2024
|
⚪
|
kruall
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 7, 2024
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Fix bug in TEvPatch event processing pipeline leading to probable corruption of original blob.
Changelog category
Additional information
TEvPatch processing sometimes involves inter-VDisk operation, which uses TSkeletonVPatchActor. This actor reads existing blobs through TEvVGet queries and operates on data received in TEvVGetResult responses. Previously they were delivered as "bytes" protobuf fields, then the logic was changed to use TRope payloads. Also, there was a change that switched internally-stored responses from TString to TRope. Thus it became possible when queries were local and blobs weren't huge that TEvVGetResult delivers rope pointing to Fresh segment of data. And usage of unsafe rope manipulators (introduced as drop-in replacement for const_cast<char*>(TString::data())) led to changing data inside the Fresh segment, instead of making on-demand copy and changing it.
For this bug to happen the following conditions needed to be met for original blob to be possibly corrupted: