Skip to content

VIEW: minor refactoring in import #14664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Feb 17, 2025

Preliminary refactoring before the bugfix (see next PRs for the connected issue).

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@jepett0 jepett0 requested a review from a team as a code owner February 17, 2025 14:33
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 14:34:33 UTC Pre-commit check linux-x86_64-release-asan for 9b13bfd has started.
2025-02-17 14:35:06 UTC Artifacts will be uploaded here
2025-02-17 14:38:23 UTC ya make is running...
🟡 2025-02-17 15:40:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11790 11682 0 51 21 36

2025-02-17 15:41:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-17 15:53:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 110 0 0 9 34

🟢 2025-02-17 15:53:32 UTC Build successful.
🟢 2025-02-17 15:53:56 UTC ydbd size 3.6 GiB changed* by +11.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 609889d merge: 9b13bfd diff diff %
ydbd size 3 890 045 208 Bytes 3 890 057 224 Bytes +11.7 KiB +0.000%
ydbd stripped size 1 361 717 056 Bytes 1 361 720 576 Bytes +3.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 14:34:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9b13bfd has started.
2025-02-17 14:36:40 UTC Artifacts will be uploaded here
2025-02-17 14:39:27 UTC ya make is running...
🟡 2025-02-17 15:27:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19086 17731 0 2 1217 136

2025-02-17 15:29:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-17 15:42:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 77 0 0 4 129

🟢 2025-02-17 15:42:20 UTC Build successful.
🟢 2025-02-17 15:42:39 UTC ydbd size 2.1 GiB changed* by +10.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 609889d merge: 9b13bfd diff diff %
ydbd size 2 236 263 928 Bytes 2 236 274 208 Bytes +10.0 KiB +0.000%
ydbd stripped size 473 848 280 Bytes 473 850 840 Bytes +2.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 enabled auto-merge (squash) February 17, 2025 14:40
@jepett0 jepett0 merged commit b091283 into ydb-platform:main Feb 17, 2025
13 checks passed
@jepett0 jepett0 linked an issue Feb 17, 2025 that may be closed by this pull request
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view import: fix a bug for the dependent view case
2 participants