Skip to content

Make config api from bsconfig api #14617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Feb 19, 2025
Merged

Make config api from bsconfig api #14617

merged 53 commits into from
Feb 19, 2025

Conversation

Enjection
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Enjection Enjection requested review from a team as code owners February 16, 2025 13:28
@Enjection Enjection marked this pull request as draft February 16, 2025 13:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 13:54:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 579fbd2 has started.
⚪ 2025-02-16 13:54:35 UTC Artifacts will be uploaded here
🔴 2025-02-16 13:56:59 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 13:56:33 UTC Pre-commit check linux-x86_64-release-asan for 579fbd2 has started.
⚪ 2025-02-16 13:57:08 UTC Artifacts will be uploaded here
🔴 2025-02-16 13:58:54 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 14:02:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47cb456 has started.
⚪ 2025-02-16 14:02:51 UTC Artifacts will be uploaded here
🔴 2025-02-16 14:05:05 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 14:05:57 UTC Pre-commit check linux-x86_64-release-asan for 47cb456 has started.
⚪ 2025-02-16 14:06:33 UTC Artifacts will be uploaded here
🔴 2025-02-16 14:08:19 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 19:19:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for ec11ebc has started.
⚪ 2025-02-18 19:19:27 UTC Artifacts will be uploaded here
⚪ 2025-02-18 19:22:49 UTC ya make is running...
🟡 2025-02-18 20:18:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28534 25921 0 11 2466 136

🟡 2025-02-18 20:20:13 UTC ydbd size 2.1 GiB changed* by +196.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a48e948 merge: ec11ebc diff diff %
ydbd size 2 237 664 768 Bytes 2 237 865 976 Bytes +196.5 KiB +0.009%
ydbd stripped size 474 182 680 Bytes 474 229 304 Bytes +45.5 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-18 20:20:16 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 19:21:43 UTC Pre-commit check linux-x86_64-release-asan for ec11ebc has started.
⚪ 2025-02-18 19:21:57 UTC Artifacts will be uploaded here
⚪ 2025-02-18 19:25:20 UTC ya make is running...
⚫ 2025-02-18 20:20:02 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 20:22:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5293ea7 has started.
⚪ 2025-02-18 20:22:54 UTC Artifacts will be uploaded here
⚪ 2025-02-18 20:26:40 UTC ya make is running...
🟡 2025-02-18 21:22:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28534 25935 0 2 2462 135

🟡 2025-02-18 21:25:18 UTC ydbd size 2.1 GiB changed* by +204.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a48e948 merge: 5293ea7 diff diff %
ydbd size 2 237 664 768 Bytes 2 237 874 384 Bytes +204.7 KiB +0.009%
ydbd stripped size 474 182 680 Bytes 474 230 392 Bytes +46.6 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-18 21:25:20 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 20:23:28 UTC Pre-commit check linux-x86_64-release-asan for 5293ea7 has started.
⚪ 2025-02-18 20:23:42 UTC Artifacts will be uploaded here
⚪ 2025-02-18 20:26:56 UTC ya make is running...
🟡 2025-02-18 21:25:35 UTC ydbd size 3.6 GiB changed* by +406.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a48e948 merge: 5293ea7 diff diff %
ydbd size 3 892 971 712 Bytes 3 893 387 968 Bytes +406.5 KiB +0.011%
ydbd stripped size 1 362 937 728 Bytes 1 363 094 208 Bytes +152.8 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-18 21:25:38 UTC Check cancelled

@Enjection Enjection marked this pull request as ready for review February 18, 2025 21:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 21:28:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 79e596f has started.
⚪ 2025-02-18 21:28:17 UTC Artifacts will be uploaded here
⚪ 2025-02-18 21:31:45 UTC ya make is running...
🟡 2025-02-18 22:30:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28534 25940 0 1 2462 131

⚪ 2025-02-18 22:32:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 22:51:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
201 (only retried tests) 71 0 0 1 129

🟢 2025-02-18 22:51:37 UTC Build successful.
🟡 2025-02-18 22:52:00 UTC ydbd size 2.1 GiB changed* by +205.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a48e948 merge: 79e596f diff diff %
ydbd size 2 237 664 768 Bytes 2 237 875 584 Bytes +205.9 KiB +0.009%
ydbd stripped size 474 182 680 Bytes 474 230 584 Bytes +46.8 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 21:29:36 UTC Pre-commit check linux-x86_64-release-asan for 79e596f has started.
⚪ 2025-02-18 21:29:49 UTC Artifacts will be uploaded here
⚪ 2025-02-18 21:33:05 UTC ya make is running...
🟡 2025-02-18 22:37:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14296 14221 0 19 18 38

⚪ 2025-02-18 22:38:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 22:57:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
114 (only retried tests) 76 0 0 4 34

🟢 2025-02-18 22:57:09 UTC Build successful.
🟡 2025-02-18 22:57:37 UTC ydbd size 3.6 GiB changed* by +408.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a48e948 merge: 79e596f diff diff %
ydbd size 3 892 971 712 Bytes 3 893 389 792 Bytes +408.3 KiB +0.011%
ydbd stripped size 1 362 937 728 Bytes 1 363 094 720 Bytes +153.3 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 10:30:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for abef353 has started.
⚪ 2025-02-19 10:30:29 UTC Artifacts will be uploaded here
⚪ 2025-02-19 10:33:52 UTC ya make is running...
🟡 2025-02-19 12:03:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28542 25947 0 1 2462 132

⚪ 2025-02-19 12:06:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-19 12:28:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 70 0 0 4 129

🟢 2025-02-19 12:28:13 UTC Build successful.
🟡 2025-02-19 12:28:33 UTC ydbd size 2.1 GiB changed* by +186.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9dda4cb merge: abef353 diff diff %
ydbd size 2 238 312 888 Bytes 2 238 503 512 Bytes +186.2 KiB +0.009%
ydbd stripped size 474 318 488 Bytes 474 353 208 Bytes +33.9 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 10:32:44 UTC Pre-commit check linux-x86_64-release-asan for abef353 has started.
⚪ 2025-02-19 10:32:57 UTC Artifacts will be uploaded here
⚪ 2025-02-19 10:36:12 UTC ya make is running...
🟡 2025-02-19 12:19:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14298 14184 0 61 18 35

⚪ 2025-02-19 12:20:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-19 12:38:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 121 0 0 6 33

🟢 2025-02-19 12:38:17 UTC Build successful.
🟡 2025-02-19 12:38:43 UTC ydbd size 3.6 GiB changed* by +388.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9dda4cb merge: abef353 diff diff %
ydbd size 3 893 509 696 Bytes 3 893 907 800 Bytes +388.8 KiB +0.010%
ydbd stripped size 1 363 182 112 Bytes 1 363 327 776 Bytes +142.2 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection merged commit 193db61 into ydb-platform:main Feb 19, 2025
12 checks passed
Gazizonoki
Gazizonoki reviewed Feb 19, 2025
View reviewed changes
Gazizonoki pushed a commit that referenced this pull request Feb 20, 2025
@Enjection
Fix sdk according review in #14617 (#14831)
2c7f23f
This was referenced Feb 21, 2025
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@Enjection
Make config api from bsconfig api (ydb-platform#14617)
23e4c5b
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@Enjection
Fix sdk according review in ydb-platform#14617 (ydb-platform#14831)
776181c
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@Enjection @blinkov
Make config api from bsconfig api (#14617)
396df3f
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@Enjection @blinkov
Fix sdk according review in #14617 (#14831)
17fe316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gazizonoki Gazizonoki Gazizonoki left review comments

@CyberROFL CyberROFL CyberROFL approved these changes

@pnv1 pnv1 pnv1 approved these changes

Assignees

@Enjection Enjection

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Enjection @CyberROFL @pnv1 @Gazizonoki