Skip to content

Make dump commands read only #14562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Make dump commands read only #14562

merged 1 commit into from
Feb 14, 2025

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Feb 14, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

These commands shouldn't ask for propmt

@pixcc pixcc requested a review from a team as a code owner February 14, 2025 09:15
@pixcc pixcc self-assigned this Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 09:19:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc39af7 has started.
2025-02-14 09:19:34 UTC Artifacts will be uploaded here
2025-02-14 09:21:55 UTC ya make is running...
🟢 2025-02-14 09:40:24 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1064 1053 0 0 5 6

🟢 2025-02-14 09:40:35 UTC Build successful.
🟢 2025-02-14 09:40:46 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 88b1d54 merge: fc39af7 diff diff %
ydbd size 2 233 189 520 Bytes 2 233 189 520 Bytes 0 Bytes 0.000%
ydbd stripped size 473 938 616 Bytes 473 938 616 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 09:19:30 UTC Pre-commit check linux-x86_64-release-asan for fc39af7 has started.
2025-02-14 09:19:42 UTC Artifacts will be uploaded here
2025-02-14 09:22:07 UTC ya make is running...
🟡 2025-02-14 09:35:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
642 621 0 6 9 6

2025-02-14 09:35:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 09:52:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 13 0 4 4 5

2025-02-14 09:52:56 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-14 10:05:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 6 0 4 3 5

🟢 2025-02-14 10:05:24 UTC Build successful.
🟢 2025-02-14 10:05:40 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 88b1d54 merge: fc39af7 diff diff %
ydbd size 3 883 750 960 Bytes 3 883 750 864 Bytes -96 Bytes -0.000%
ydbd stripped size 1 359 918 928 Bytes 1 359 918 864 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc enabled auto-merge (squash) February 14, 2025 09:25
@pixcc pixcc merged commit a27e920 into ydb-platform:main Feb 14, 2025
13 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants