Skip to content

rework node priorities to make dc preference overridable #14554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Feb 13, 2025

Changelog entry

Improved node priority logic in Hive.

Changelog category

  • Improvement

Additional information

Updated node priorities logic to avoid issues when system tablets remain in a datacenter even when all nodes of the datacenter are in a crash loop.

Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 22:58:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for a38b018 has started.
2025-02-13 22:59:24 UTC Artifacts will be uploaded here
2025-02-13 23:02:41 UTC ya make is running...
🟡 2025-02-14 00:04:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19091 17738 0 2 1213 138

2025-02-14 00:05:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-14 00:26:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 79 0 0 2 129

🟢 2025-02-14 00:26:51 UTC Build successful.
🟢 2025-02-14 00:27:11 UTC ydbd size 2.1 GiB changed* by -23.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 28180f6 merge: a38b018 diff diff %
ydbd size 2 232 662 400 Bytes 2 232 638 864 Bytes -23.0 KiB -0.001%
ydbd stripped size 473 850 552 Bytes 473 844 728 Bytes -5.7 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 23:01:10 UTC Pre-commit check linux-x86_64-release-asan for a38b018 has started.
2025-02-13 23:01:14 UTC Artifacts will be uploaded here
2025-02-13 23:04:15 UTC ya make is running...
🟡 2025-02-14 00:30:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11805 11694 0 40 35 36

2025-02-14 00:31:33 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-14 00:44:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 126 0 0 5 35

🟢 2025-02-14 00:44:09 UTC Build successful.
🟢 2025-02-14 00:44:36 UTC ydbd size 3.6 GiB changed* by -38.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 28180f6 merge: a38b018 diff diff %
ydbd size 3 882 848 808 Bytes 3 882 809 032 Bytes -38.8 KiB -0.001%
ydbd stripped size 1 359 665 552 Bytes 1 359 652 048 Bytes -13.2 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke linked an issue Feb 14, 2025 that may be closed by this pull request
2 tasks
@vporyadke vporyadke requested a review from CyberROFL February 14, 2025 08:36
@CyberROFL CyberROFL assigned vporyadke and unassigned vporyadke Feb 14, 2025
Comment on lines -1287 to -1289
for (const ui64 dcId : dcGroup->GetDataCenterNum()) {
indexDC2Group[DataCenterToString(dcId)] = candidateGroups.data() + numGroup;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это точно deprecated? Как можно в этом удостовериться?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced in April 2021, made deprecated in September 2021, internal tracker shows no signs of it ever being set anywhere, and it is not set on any of our main prod clusters.

Copy link

github-actions bot commented Feb 16, 2025

2025-02-16 23:14:01 UTC Pre-commit check linux-x86_64-release-asan for 35e4de1 has started.
2025-02-16 23:14:21 UTC Artifacts will be uploaded here
2025-02-16 23:17:27 UTC ya make is running...
🟡 2025-02-17 00:57:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13764 13643 0 55 30 36

2025-02-17 00:58:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-17 01:11:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 139 0 4 8 32

2025-02-17 01:11:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-17 01:23:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 33 0 4 4 34

🟢 2025-02-17 01:23:41 UTC Build successful.
🟢 2025-02-17 01:24:12 UTC ydbd size 3.6 GiB changed* by -40.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7c2a68c merge: 35e4de1 diff diff %
ydbd size 3 889 415 240 Bytes 3 889 373 880 Bytes -40.4 KiB -0.001%
ydbd stripped size 1 361 429 552 Bytes 1 361 412 048 Bytes -17.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 16, 2025

2025-02-16 23:18:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 35e4de1 has started.
2025-02-16 23:18:24 UTC Artifacts will be uploaded here
2025-02-16 23:21:41 UTC ya make is running...
🟡 2025-02-17 00:56:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27980 25382 0 1 2459 138

2025-02-17 00:59:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-17 01:10:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
214 (only retried tests) 83 0 0 2 129

🟢 2025-02-17 01:11:06 UTC Build successful.
🟢 2025-02-17 01:11:28 UTC ydbd size 2.1 GiB changed* by -21.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7c2a68c merge: 35e4de1 diff diff %
ydbd size 2 235 932 952 Bytes 2 235 911 064 Bytes -21.4 KiB -0.001%
ydbd stripped size 473 766 104 Bytes 473 760 280 Bytes -5.7 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL previously approved these changes Feb 17, 2025
@vporyadke vporyadke requested review from ijon and adameat February 18, 2025 08:57
adameat
adameat previously approved these changes Feb 18, 2025
@vporyadke vporyadke dismissed stale reviews from adameat and CyberROFL via 7e2c1e2 February 18, 2025 12:34
Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 12:38:04 UTC Pre-commit check linux-x86_64-release-asan for b543214 has started.
2025-02-18 12:38:18 UTC Artifacts will be uploaded here
2025-02-18 12:41:24 UTC ya make is running...
🟡 2025-02-18 14:16:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13783 13720 0 20 7 36

2025-02-18 14:17:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 14:37:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 62 0 0 2 34

🟢 2025-02-18 14:37:30 UTC Build successful.
🟢 2025-02-18 14:38:02 UTC ydbd size 3.6 GiB changed* by -33.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e441aea merge: b543214 diff diff %
ydbd size 3 890 761 248 Bytes 3 890 727 008 Bytes -33.4 KiB -0.001%
ydbd stripped size 1 362 114 304 Bytes 1 362 101 408 Bytes -12.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 12:38:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for b543214 has started.
2025-02-18 12:38:18 UTC Artifacts will be uploaded here
2025-02-18 12:41:34 UTC ya make is running...
🟢 2025-02-18 14:19:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28011 25420 0 0 2456 135

🟢 2025-02-18 14:21:34 UTC Build successful.
🟢 2025-02-18 14:21:53 UTC ydbd size 2.1 GiB changed* by -20.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 24d8aaa merge: b543214 diff diff %
ydbd size 2 236 501 936 Bytes 2 236 481 360 Bytes -20.1 KiB -0.001%
ydbd stripped size 473 946 200 Bytes 473 940 568 Bytes -5.5 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-04-16 10:54:11 UTC The validation of the Pull Request description is successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure system tablets are alive when an entire dc is in a crash-loop
3 participants