Skip to content

Remove compatibility with old NBS binaries #14443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

serbel324
Copy link
Collaborator

Changelog category

  • Not for changelog (changelog entry is not required)

@serbel324 serbel324 requested a review from a team as a code owner February 11, 2025 13:35
@serbel324 serbel324 changed the title Update version_definition.cpp Remove compatibility with old NBS binaries Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 13:37:02 UTC Pre-commit check for 55e8a1e has started.
2025-02-11 13:39:51 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-11 14:01:35 UTC Build successful.
2025-02-11 14:01:55 UTC Tests are running...
🔴 2025-02-11 16:07:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10763 10663 0 33 24 43

🟡 2025-02-11 16:08:18 UTC ydbd size 5.6 GiB changed* by +120.6 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: a254002 merge: 55e8a1e diff diff %
ydbd size 6 002 741 216 Bytes 6 002 864 696 Bytes +120.6 KiB +0.002%
ydbd stripped size 1 504 236 640 Bytes 1 504 260 640 Bytes +23.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 13:38:21 UTC Pre-commit check for 55e8a1e has started.
2025-02-11 13:40:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-11 14:19:53 UTC Build successful.
2025-02-11 14:20:09 UTC Tests are running...
🔴 2025-02-11 15:51:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15102 13744 0 20 1300 38

🟡 2025-02-11 15:52:24 UTC ydbd size 8.3 GiB changed* by +198.5 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: a254002 merge: 55e8a1e diff diff %
ydbd size 8 874 098 288 Bytes 8 874 301 536 Bytes +198.5 KiB +0.002%
ydbd stripped size 483 816 072 Bytes 483 821 352 Bytes +5.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@serbel324 serbel324 merged commit df03f29 into stable-24-4 Feb 13, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants