Skip to content

Fix for Decimal PK in CDC #14290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

azevaykin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@azevaykin azevaykin requested a review from a team as a code owner February 6, 2025 17:50
Copy link

github-actions bot commented Feb 6, 2025

2025-02-06 17:54:40 UTC Pre-commit check for 7f7c664 has started.
2025-02-06 17:57:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-06 18:36:52 UTC Build successful.
2025-02-06 18:37:07 UTC Tests are running...
🔴 2025-02-06 20:08:12 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14748 13383 0 16 1302 47

🟢 2025-02-06 20:08:59 UTC ydbd size 8.3 GiB changed* by +3.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 4dbe124 merge: 7f7c664 diff diff %
ydbd size 8 874 094 680 Bytes 8 874 098 688 Bytes +3.9 KiB +0.000%
ydbd stripped size 483 816 328 Bytes 483 816 584 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 6, 2025

2025-02-06 17:54:50 UTC Pre-commit check for 7f7c664 has started.
2025-02-06 17:57:27 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-06 18:20:32 UTC Build successful.
2025-02-06 18:20:47 UTC Tests are running...
🔴 2025-02-06 20:34:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10419 10293 0 44 36 46

🟢 2025-02-06 20:35:28 UTC ydbd size 5.6 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 4dbe124 merge: 7f7c664 diff diff %
ydbd size 6 002 751 488 Bytes 6 002 753 912 Bytes +2.4 KiB +0.000%
ydbd stripped size 1 504 243 936 Bytes 1 504 244 000 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin added the rebase-and-check Rebase PR with the current base branch and check label Feb 7, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

2025-02-07 13:23:58 UTC Pre-commit check for 0ada39c has started.
2025-02-07 13:26:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-07 14:07:15 UTC Build successful.
2025-02-07 14:07:28 UTC Tests are running...
🔴 2025-02-07 15:36:47 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14748 13386 0 15 1302 45

🟢 2025-02-07 15:37:41 UTC ydbd size 8.3 GiB changed* by +8.2 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 4dbe124 merge: 0ada39c diff diff %
ydbd size 8 874 094 680 Bytes 8 874 103 080 Bytes +8.2 KiB +0.000%
ydbd stripped size 483 816 328 Bytes 483 816 712 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 7, 2025

2025-02-07 13:24:01 UTC Pre-commit check for 0ada39c has started.
2025-02-07 13:26:36 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-07 13:49:19 UTC Build successful.
2025-02-07 13:49:49 UTC Tests are running...
🔴 2025-02-07 16:19:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10417 10300 0 38 33 46

🟢 2025-02-07 16:20:40 UTC ydbd size 5.6 GiB changed* by -1.6 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 8cfba18 merge: 0ada39c diff diff %
ydbd size 6 002 755 544 Bytes 6 002 753 888 Bytes -1.6 KiB -0.000%
ydbd stripped size 1 504 244 256 Bytes 1 504 240 224 Bytes -3.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin merged commit d6fd00d into ydb-platform:stable-24-3 Feb 7, 2025
8 of 14 checks passed
@azevaykin azevaykin deleted the stable-24-3 branch February 7, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants